From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C85C433EF for ; Tue, 19 Oct 2021 14:32:38 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 42DF76115A for ; Tue, 19 Oct 2021 14:32:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 42DF76115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EA764119E; Tue, 19 Oct 2021 16:32:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 864A44119D for ; Tue, 19 Oct 2021 16:32:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="228479635" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="228479635" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 07:27:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="526676703" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 19 Oct 2021 07:27:44 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:27:44 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 07:27:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 07:27:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OU3C5g3ZnVw7tDiKKe0ov9VS8O8FFChzIpomfZGmq1aIC+CD3u28s3ky5Sfeu1g4RyvhBGWXQ+ZqcEWuFznmXmNXK5nGvxWAWxVKS7yr4ZVx4Ee4pYXzusLCAYOYZeyqoJzL3oe+9Y9VeRVA4urvqnJKe6WfytDAEsr2avZrYyaLEwP9HDzKityM77G0OJOoSBqPyxWjrRm/5lSzqMe2/XG3mnm+GEtGxcIqswr+2D/i7+j079mR1ZG74x0nB518X3QfZquklIkO9IpgsIoVE2CQCt32JvGC+ERymXDQJh+x+0SKHqC5A07h6IKTtul8mMSaj04X+AjX+FAEp/6Fvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FEq0QxEPnEy1pDS9sYcIfTBaKwuqnWs7cgicgQ8KS7Y=; b=VZDHhwgiCb2S4V/3NqtTKfn/p39jO/UeRqcqntVtO3zxUWMXnpE04ciaZztEsyTK35W2VDg+/1njIq3yA2p6gx4bisZ/zdoz+EpooDyIRnr18SMYx61UEWAGwWr0TQn9q3BcX8EfM0NWOpBD1n3lddzeosC9y59nya2haJGvv5VE1hJYQ1X8R4CUKfndW5h1k9+DHoOg3MVUxoL0QD4Cb6vdx9iVyelzgwBV0in4dl5pqNHhfiLYENXNgD5PA9TYBPEgs3PuHH2UTNk0wvqsEKoDdhqQshqjdSKBStVb2oxT0VL9bNzmDqHIFxAnUS3CgHE1iWdeW4C/HoGBJZTpeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FEq0QxEPnEy1pDS9sYcIfTBaKwuqnWs7cgicgQ8KS7Y=; b=xLVX6lruS5TCjtWHXCHmCYtAidhtNxoEiBTNP4n3YCbpf3b1goYuoR4Lnajn0gNKhP1syfoc60XSZo9iZyYCS42t1gs+QzTqbGoAMAq7lGX0Aso303+GGbFEEBfFlN0NgIQWYN/v3qJxmOmbv0MXXvjlf0SukGpVgsaM/mHlu9k= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3386.namprd11.prod.outlook.com (2603:10b6:5:5c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 14:27:43 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 14:27:43 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" , "Troy, Rebecca" Thread-Topic: [PATCH v3 3/7] cryptodev: move inline APIs into separate structure Thread-Index: AQHXxC5zOSYlIuAiq0O4ieviKPZKYavaK0JggAALRQCAACt8AA== Date: Tue, 19 Oct 2021 14:27:43 +0000 Message-ID: References: <20211011124309.4066491-1-gakhil@marvell.com> <20211018144201.2028022-1-gakhil@marvell.com> <20211018144201.2028022-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 643d9d8e-d0d3-4a50-fb5f-08d9930c9d06 x-ms-traffictypediagnostic: DM6PR11MB3386: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yTexq7l9KjGKly5dQ+T1SksAZLGeIvqwVoJ+iadcTWYZ6mrUYFuXo6LXsVHr56Ztq20rBOCoTZB5+tYwOn10M2NrsYKYhS0KimLTADStY64s9xUv4hcVSLHCVfWYduhxOlDh9RWY9c3E9r8WuuLZH/iLvVF5pSLtW7+FOwdf90oZ+xMYVTH9NaTmUjWEE3Ns269im2dJoP4ZVnQYfVTSE1e8NOM0d07N69+RwgPPZGmTUgqmbOthCfa/cWMlQDaaqpLh2DLecK2mdvmuz4cz9KtPQPd2BXVVVvY//tA0lUWbkf7lJiP9W8j2W5jT9SDNMb2dKEinQoETZ4ZgI115DHkwd5NNuTAJvkZtdKQp0WkJEv/CdevVp2PdUpxIZfwHGR3F3jbUMIl9Eh0ogoTnwGpn9HFOQasZbbXhCWxouzAkUkwIGN8GIwM1yhk+4zYoKJAwLh7jJkigwuTBQL7lTgwhW3JLpY3DO9K8w2GkcRZO9C9kdnHmT8nq6/f0PiLQ6mwQprzSViMZoo/GK1LiYRulUvmD71bo8DKxqmMfgl1BaSiT5l2T0lKrmCVTQ7+Wd7yN/fcrYHCSEOXyBWzQZBV90QVyhCAWLyqNL1VoSsXTQffQsqi5ghc9gh0OaMA5ELTDfbvf0PTwI0Ay8p0upuTjWwLZad+YfFQqgr5NHjxeArqwi+GZ2emH4YdUgBiIVm5NdqD1S7Gk/rv/VhT2GA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(82960400001)(71200400001)(2906002)(107886003)(8676002)(76116006)(110136005)(8936002)(6506007)(122000001)(38070700005)(38100700002)(33656002)(55236004)(54906003)(7416002)(52536014)(26005)(55016002)(5660300002)(186003)(66476007)(83380400001)(316002)(53546011)(66946007)(86362001)(7696005)(9686003)(4326008)(66556008)(66446008)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2rqZ91dU/drAGA2r9FyML85tAjVW8r/JNKgJNlMpWZbGleYBj0QZ733/wbpu?= =?us-ascii?Q?UxF7EmgN+n9RZ2fXG58XzAqMhWvixiC4bzKn2WxIh2EOGQlLJm6xaxLQDxv6?= =?us-ascii?Q?yfTR8Z/jdrzjqUCpaaWX2ZtmgAj2nUDT+/5ZnbOPeBbr/cs3zyx5yd4Ni0Zx?= =?us-ascii?Q?TBS3vtK7qrI3BZ18xzWE6va8Ok9FPHbh2hV5Kzyh2H/6larRVD+s7hL1n0VH?= =?us-ascii?Q?3OClDGtsvXOGNfRCZF26NLr5BxHG2Qae4dY3doTNUm1r36z8mpiwGacQnpCg?= =?us-ascii?Q?xcWtGQyyf4I3cnR9B88rqAoXzMnHdDMGAvGP/Ip0rWDEOQpwWfeDyweiCPO4?= =?us-ascii?Q?1TuJxKl588ZQB5sV6eSdNOUAcOu+dgV0RTeERLGe+gDUqIGIxDnSb7rg3pAm?= =?us-ascii?Q?Me5yaJCu3UgKqRJKO3RehriRp+vm7UY9u32ICc7KWb1IuZEislEjCIZ8PbPK?= =?us-ascii?Q?QpzSxNqK7QM4uJGJfI8beHrDp4QJXlFvOWeBKaUW2yVLCjbRwLZCoRunbldr?= =?us-ascii?Q?3R8/uG+kMDJTR+3RtMMRPyNPjLl56sGV2U79W4a744dfT0QkvLDyxD0EjxKD?= =?us-ascii?Q?rsEgbS4sjsPOK1Nl3jJr0pFFg73JTAOFudAPQndIdyVQRlCQ6GGV+sLBoQFy?= =?us-ascii?Q?wx/o/+UofdNSqGSvuGftS45fmCR4RbzirDwmfMbZcneThWUBnfPHSOi37RUX?= =?us-ascii?Q?KBrXvOq5GWNp71NHhnR9pVWwYU4CK1sKaxAE/U6/gBLQi1w6WxVFMHP/DUmj?= =?us-ascii?Q?QV7NNahj5wr3+qUaGcH5b6+xpyS2N35pu04opt1OVmqy7G1DY+kWZDnRRXXf?= =?us-ascii?Q?xPBe9PglxkD91Hh0tI6k+sl7tP5MGjcTrBFwMEp3bKS7tdSOIRZySS5uQKMk?= =?us-ascii?Q?fEMt3h/RYZTIsX2YQU/cR0CQT1NEH4IeflvUti7hoDlT4L4YBp7P6utORLDl?= =?us-ascii?Q?GxHz1VTrtMvffmPFivK43kaSfWrdt83jv5E/U77YiwKkzqG+wPAXhCgZzsBj?= =?us-ascii?Q?H+Ulnw7GqniYqbaiw7UziL9pO68m/aI7T23UcgICBeyXdIZXNN+1OycB4xee?= =?us-ascii?Q?U2LPeke44lf3I+2RFA/C0AkrEKWYqPSngFtwuHoAg19mqfsOT1cMUBTEK4S8?= =?us-ascii?Q?Tc3s6nbD7fEL7vVjGl2RTodqfOivaZASa9uRB4z6iaCEiGLLVia5LfjRt5IC?= =?us-ascii?Q?/UMQL6WinIw4lnkexeeUGZ8/Whf5ikDS5S15yJIgSYzRhXuvaTcT4I/RrFA5?= =?us-ascii?Q?jqTjQftloUgZ/Mlk8bPXs2gENOAv4LbfFdjIbeFOHwHphwX+rLQMLyWJYmUS?= =?us-ascii?Q?5Lxx6xQSr4/5/7FtjlxOE/rC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 643d9d8e-d0d3-4a50-fb5f-08d9930c9d06 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 14:27:43.0788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qdBGyjuTJVellDb0GbYTqoDZ59g0+0hFa7+MXxRaRlSLzcfRcOUjbRIBgIJo3fnG7/2JofhkvyZikMd3pKiEyoEEvDPKjNL66amH52qdNhk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3386 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 3/7] cryptodev: move inline APIs into separate structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, October 19, 2021 12:50 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: thomas@monjalon.net; david.marchand@redhat.com; hemant.agrawal@nxp.co= m; Anoob Joseph ; De Lara > Guarch, Pablo ; Trahe, Fiona ; Doherty, Declan ; > matan@nvidia.com; g.singh@nxp.com; Zhang, Roy Fan ; jianjay.zhou@huawei.com; asomalap@amd.com; > ruifeng.wang@arm.com; Nicolau, Radu ; ajit.khapar= de@broadcom.com; Nagadheeraj Rottela > ; Ankur Dwivedi ; Power, = Ciara ; Troy, Rebecca > > Subject: RE: [PATCH v3 3/7] cryptodev: move inline APIs into separate str= ucture >=20 > > > diff --git a/lib/cryptodev/rte_cryptodev_core.h > > b/lib/cryptodev/rte_cryptodev_core.h > > > index 1633e55889..e9e9a44b3c 100644 > > > --- a/lib/cryptodev/rte_cryptodev_core.h > > > +++ b/lib/cryptodev/rte_cryptodev_core.h > > > @@ -25,6 +25,35 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void *qp, > > > struct rte_crypto_op **ops, uint16_t nb_ops); > > > /**< Enqueue packets for processing on queue pair of a device. */ > > > > > > +/** > > > + * @internal > > > + * Structure used to hold opaque pointers to internal ethdev Rx/Tx > > > + * queues data. > > > + * The main purpose to expose these pointers at all - allow compiler > > > + * to fetch this data for fast-path cryptodev inline functions in ad= vance. > > > + */ > > > +struct rte_cryptodev_qpdata { > > > + /** points to array of internal queue pair data pointers. */ > > > + void **data; > > > + /** points to array of enqueue callback data pointers */ > > > + struct rte_cryptodev_cb_rcu *enq_cb; > > > + /** points to array of dequeue callback data pointers */ > > > + struct rte_cryptodev_cb_rcu *deq_cb; > > > +}; > > > + > > > +struct rte_crypto_fp_ops { > > > + /** PMD enqueue burst function. */ > > > + enqueue_pkt_burst_t enqueue_burst; > > > + /** PMD dequeue burst function. */ > > > + dequeue_pkt_burst_t dequeue_burst; > > > + /** Internal queue pair data pointers. */ > > > + struct rte_cryptodev_qpdata qp; > > > + /** Reserved for future ops. */ > > > + uintptr_t reserved[4]; > > > > I think it has to be uintptr_t reserved[3]; > > 2 function pointers + 3 data pointers +3 reserved pointers. > > Otherwise it will occupy extra 64B line. >=20 > Yep, I missed decrementing it. Thanks. Will update in v4. Ok. > Please review others also and ack if no comments. I looked through other patches in this set. All looks good to me. With the nit above fixed: Series Acked-by: Konstantin Ananyev > We need to close all the patches(including the control path) > by tomorrow EOD.