From: "Kwapulinski, Piotr" <piotr.kwapulinski@intel.com>
To: Richard Cochran <richardcochran@gmail.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
"K, AshishX" <ashishx.k@intel.com>
Subject: RE: [PATCH net-next v2 1/1] i40e: add support for PTP external synchronization clock
Date: Thu, 22 Jul 2021 12:54:28 +0000 [thread overview]
Message-ID: <DM6PR11MB4610EF80DFA1C2EB2166CE49F3E49@DM6PR11MB4610.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210722114701.GA3439@hoboy.vegasvil.org>
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Thursday, July 22, 2021 1:47 PM
>
> > On Tue, Jul 20, 2021 at 04:23:48PM -0700, Tony Nguyen wrote:
>
> > +/**
> > + * i40e_set_subsystem_device_id - set subsystem device id
> > + * @hw: pointer to the hardware info
> > + *
> > + * Set PCI subsystem device id either from a pci_dev structure or
> > + * a specific FW register.
> > + **/
> > +static inline void i40e_set_subsystem_device_id(struct i40e_hw *hw) {
> > + struct pci_dev *pdev = ((struct i40e_pf *)hw->back)->pdev;
> > +
> > + hw->subsystem_device_id = pdev->subsystem_device ?
> > + pdev->subsystem_device :
> > + (ushort)(rd32(hw, I40E_PFPCI_SUBSYSID) & USHRT_MAX); }
> > +
> > /**
> > * i40e_probe - Device initialization routine
> > * @pdev: PCI device information struct @@ -15262,7 +15281,7 @@
> > static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> > hw->device_id = pdev->device;
> > pci_read_config_byte(pdev, PCI_REVISION_ID, &hw->revision_id);
> > hw->subsystem_vendor_id = pdev->subsystem_vendor;
> > - hw->subsystem_device_id = pdev->subsystem_device;
> > + i40e_set_subsystem_device_id(hw);
>
> What does this have to do with $SUBJECT? Nothing, AFAICT.
It is required to properly handle the pin settings on PF other than 0.
Regards,
Piotr
prev parent reply other threads:[~2021-07-22 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 23:23 [PATCH net-next v2 1/1] i40e: add support for PTP external synchronization clock Tony Nguyen
2021-07-21 16:00 ` patchwork-bot+netdevbpf
2021-07-22 11:47 ` Richard Cochran
2021-07-22 12:54 ` Kwapulinski, Piotr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4610EF80DFA1C2EB2166CE49F3E49@DM6PR11MB4610.namprd11.prod.outlook.com \
--to=piotr.kwapulinski@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ashishx.k@intel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.