All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Quan, Evan" <Evan.Quan@amd.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: RE: [PATCH] drm/amdgpu/smu7: fix CAC setting on TOPAZ
Date: Thu, 8 Apr 2021 04:18:03 +0000	[thread overview]
Message-ID: <DM6PR12MB26192269914A56708CA6FE59E4749@DM6PR12MB2619.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210407133920.314018-1-alexander.deucher@amd.com>

[AMD Public Use]

Reviewed-by: Evan Quan <evan.quan@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Wednesday, April 7, 2021 9:39 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
> Subject: [PATCH] drm/amdgpu/smu7: fix CAC setting on TOPAZ
> 
> We need to enable MC CAC for mclk switching to work.
> 
> Fixes: d765129a719f ("drm/amd/pm: correct sclk/mclk dpm enablement")
> Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla
> b.freedesktop.org%2Fdrm%2Famd%2F-
> %2Fissues%2F1561&amp;data=04%7C01%7Cevan.quan%40amd.com%7C00a
> 251035e6f4c16d63608d8f9ca9928%7C3dd8961fe4884e608e11a82d994e183d%
> 7C0%7C0%7C637533995857826102%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C100
> 0&amp;sdata=gMvcwYRiSFSyYhzXm5OGBxdRGIiPC4%2BkVBmN17dJR8w%3D
> &amp;reserved=0
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> index 301b6769f007..0541bfc81c1b 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1224,7 +1224,8 @@ static int smu7_enable_sclk_mclk_dpm(struct
> pp_hwmgr *hwmgr)
>  		    (hwmgr->chip_id == CHIP_POLARIS10) ||
>  		    (hwmgr->chip_id == CHIP_POLARIS11) ||
>  		    (hwmgr->chip_id == CHIP_POLARIS12) ||
> -		    (hwmgr->chip_id == CHIP_TONGA))
> +		    (hwmgr->chip_id == CHIP_TONGA) ||
> +		    (hwmgr->chip_id == CHIP_TOPAZ))
>  			PHM_WRITE_FIELD(hwmgr->device,
> MC_SEQ_CNTL_3, CAC_EN, 0x1);
> 
> 
> --
> 2.30.2
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=04%7C01%7Cevan.quan%40amd.com%7C00a251035e6f4c16d
> 63608d8f9ca9928%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> 7533995857826102%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=
> AJFxsTzMjqU8IW7%2FL%2BtsPIWFmJb95dyr5pZ7EXnk20g%3D&amp;reserve
> d=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      reply	other threads:[~2021-04-08  4:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 13:39 [PATCH] drm/amdgpu/smu7: fix CAC setting on TOPAZ Alex Deucher
2021-04-08  4:18 ` Quan, Evan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB26192269914A56708CA6FE59E4749@DM6PR12MB2619.namprd12.prod.outlook.com \
    --to=evan.quan@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.