All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Quan, Evan" <Evan.Quan@amd.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Tareque Md . Hanif" <tarequemd.hanif@yahoo.com>
Subject: RE: [PATCH] drm/amdgpu: no DC support for headless chips
Date: Tue, 28 Dec 2021 01:54:41 +0000	[thread overview]
Message-ID: <DM6PR12MB2619DF13DBBB81337AE40CA2E4439@DM6PR12MB2619.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211227171141.1503210-1-alexander.deucher@amd.com>

[AMD Official Use Only]

Reviewed-by: Evan Quan <evan.quan@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Tuesday, December 28, 2021 1:12 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Tareque Md .
> Hanif <tarequemd.hanif@yahoo.com>
> Subject: [PATCH] drm/amdgpu: no DC support for headless chips
> 
> Chips with no display hardware should return false for
> DC support.
> 
> v2: drop Arcturus and Aldebaran
> 
> Fixes: f7f12b25823c0d ("drm/amdgpu: default to true in
> amdgpu_device_asic_has_dc_support")
> Reported-by: Tareque Md.Hanif <tarequemd.hanif@yahoo.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 9dc86c5a1cad..694c3726e0f4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3166,6 +3166,12 @@ static void
> amdgpu_device_detect_sriov_bios(struct amdgpu_device *adev)
>  bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type)
>  {
>  	switch (asic_type) {
> +#ifdef CONFIG_DRM_AMDGPU_SI
> +	case CHIP_HAINAN:
> +#endif
> +	case CHIP_TOPAZ:
> +		/* chips with no display hardware */
> +		return false;
>  #if defined(CONFIG_DRM_AMD_DC)
>  	case CHIP_TAHITI:
>  	case CHIP_PITCAIRN:
> --
> 2.33.1

  reply	other threads:[~2021-12-28  1:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 17:11 [PATCH] drm/amdgpu: no DC support for headless chips Alex Deucher
2021-12-28  1:54 ` Quan, Evan [this message]
2021-12-28  2:43 ` Chen, Guchun
  -- strict thread matches above, loose matches on Subject: below --
2021-12-23 19:19 Alex Deucher
2021-12-24  2:54 ` Chen, Guchun
2021-12-24  6:15   ` Alex Deucher
2021-12-24  8:19     ` Chen, Guchun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB2619DF13DBBB81337AE40CA2E4439@DM6PR12MB2619.namprd12.prod.outlook.com \
    --to=evan.quan@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=tarequemd.hanif@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.