From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5297C433EF for ; Fri, 15 Jul 2022 15:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234933AbiGOPgd (ORCPT ); Fri, 15 Jul 2022 11:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234928AbiGOPgb (ORCPT ); Fri, 15 Jul 2022 11:36:31 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2049.outbound.protection.outlook.com [40.107.212.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6763655091; Fri, 15 Jul 2022 08:36:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgDvHQxlNp/DQ62JEHLCxAUdhedPRRcBes8hNR6JPLzsTUnZjBp4VEHQMXlhDJUxKtIuIkVCoFOPSurMPLUDes6W2Ta8k6Fs2+IQCn4GTLxTWkokkEYU88KB+2EQKzkYu+cVP8cSwiX2a5RtLzNNkRlfgAldDOWwkbU0MObwNQPycK0Y9fJsMJG+h5OfbYre5BjdhVJCCGHwu53sdK9ICTCYErGDWd1uPDm+Kv2PTQzMHPcvCICpaS/EXJr9iuTUjumDlt3kD7lu1ml7AbucbxVYLnrnG3pO6woERsADFlMlu4F0Rfycx2rglzblCb/P837AL8UjDB7pTLV3S+jl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=iOio8FpZiNQv3D7WuN0fIO766op+DPy9q3njYm+Gdp73D4OewgtNH5kZmtoyXRFryHSg6tmI8mP7phyJP+fJ7cbq/UfbW0ICkZNLnm9TStBcL4XYVbYYQlvPwBE7OUQyt316IMB42EYlTSoQzcpR5ajenLSWuoWawOh0cSlh65Ehfkx2FiJieJe1npKFg7lSo6+sINshflr3EVkkDaKgdUeMFGy2jMZVsoNSoEbMv4dqLnYWH0XjgNM1bex7AfWaYOPZ8XVNFGsHpDnokRZm/43WsgYDH99J6CVGZmf5liUlutvF/CyDN/dxV9AHa/uZL5eMywEYvLYtiabiJ45ghQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=GjBtdoWKU8syj4bwwnOhEK/SKbTPROm9G9LzFx5n8nfxhU4FBNxFLs519U4Aj4QvY9hWMCXv19oQQ8N9S0+CsIBBYAilcE54teofHTu2ABUI2Am1hOqzQajgrKyPCnWq8ira63rXsLKHrc+ypiiXHkyUeXrNsi7RZKKso3TFJjQ= Received: from DM6PR12MB2809.namprd12.prod.outlook.com (2603:10b6:5:4a::16) by MWHPR12MB1325.namprd12.prod.outlook.com (2603:10b6:300:f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 15:36:24 +0000 Received: from DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb]) by DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb%5]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 15:36:24 +0000 From: "Mahapatra, Amit Kumar" To: Mark Brown , Michal Simek CC: Amit Kumar Mahapatra , Krzysztof Kozlowski , "p.yadav@ti.com" , "miquel.raynal@bootlin.com" , "richard@nod.at" , "vigneshr@ti.com" , "git@xilinx.com" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "michael@walle.cc" , "linux-mtd@lists.infradead.org" , "git (AMD-Xilinx)" , "Mahapatra, Amit Kumar" Subject: RE: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Topic: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Index: AQHYeZhXApErq+32kkmuJFVVfXogSAG7F8aMAeAoVR8BtmPI/ALXxyQSrJxOXKA= Date: Fri, 15 Jul 2022 15:36:23 +0000 Message-ID: References: <20220606112607.20800-1-amit.kumar-mahapatra@xilinx.com> <20220606112607.20800-2-amit.kumar-mahapatra@xilinx.com> <40110ff8-5c19-bc54-759b-a51a919788eb@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8217ced-9fb9-41df-d0a6-08da6677c646 x-ms-traffictypediagnostic: MWHPR12MB1325:EE_ x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BI7rVEnq2FQO5MUIAzR/uqqI4oY6Rl69/LNYW23MHI3obV69DTNLpUC3zoloP7KSFUoToWK220wUZ4FG7sjxPWutcJNaQxOMCF4OgaZXW2UB4/PTdCkUUkKg4SE/hvIIYsViwoHbTMPKs+BwBWybHccNsWYS24/TBTPVkI3GICtGb/6JBUrK2WlF7kFMVN++GErthgrYDEf/OD3apzxwx75MwD2djAG7qiOa0WAthxVle7u77zCN0YxHKoSsRcgk1vqNAHPho10GLwflawGjpokYQE73vjcqfTBhmEtngK2jsLwQ4bo3fSIHW68NUwhWxyfGpMYhrT/TkJ03/JKX6JEjFpGNAi+PoVvDX5KmlWC+/1t6hnl1vCE9zhSHlZ9WtaD8pAmj615n+LtiqD1W4WCfMY0TYmrpepfUG49TzzIO6UDTLRdmlSCBZ9HRqSfJ0xId/iD8ZXIGD3b0Ywy9BYhwBWmDO13xetDmOXSU4ZpbltVYyDRxBFG5SGRbF7ymUHBTVKQu27qFY0tYZMGQMoY4YtmG3yK6F74QUXHz4wzANKeTYOgGIPH1d6SU9kdn0xP0XppMPioUo0M3adAkecPPwGc9DonO5QQ2slwMNH8uQhwsjYeA4kl2I1r6gR+NThaeiSb5ZoILmbf1juYbjyzbmS8O1Odikl8RDDkDp0C1OOli1wF/K12V3ice07KstmAsVdU8inWA1VGWG0b4ysIGEFPdYp4IA7ZYUtK7KEDYuvRdUTEMqC5faE3gOZgcMaNFKDGaDPXLNJeAeI3M6nYr9gBz2lgW0xvhYt9LqrCpVhoNbfRXIi6r/0yxATU7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2809.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(186003)(4326008)(83380400001)(55016003)(66446008)(64756008)(71200400001)(110136005)(8676002)(76116006)(66556008)(66476007)(26005)(54906003)(2906002)(9686003)(7696005)(66946007)(53546011)(6506007)(86362001)(33656002)(38100700002)(5660300002)(38070700005)(8936002)(478600001)(122000001)(41300700001)(52536014)(7416002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uQGWjl/8Pi7n+dNv3G2TidaoyfyzaWXyj6EmUnJlDcBLmO6Fre2u+axNyjBv?= =?us-ascii?Q?LYN+07Cxffm/oVzSzd2WXCW8FEomABc52V6ZlTztc3gklgQSoBGaZ0EYX9Cd?= =?us-ascii?Q?ZS1zCDFgGoJjUyhfhQoOCRuBZLNzNsJ9BaaGT/zg/NxLTFBWV0YqIsPOztgs?= =?us-ascii?Q?G4TA5tjpQbz0z1WUHTTKbH1NyQE2XGmVAWTp/aesKXnUtsZKLva+l5rKTx7g?= =?us-ascii?Q?2YIq39n4OmNfRc1a6/FIT84GS6n339a6PREKOYz//akV/eil+vemSboJgZ/v?= =?us-ascii?Q?WYVD0bpkF/8CHR+byo4FTkH6xEYUXgepxpWlM5zP/G3ixaOgOs8fwp5m+Uw6?= =?us-ascii?Q?gD4wM8jp2C8Pz5k2znbZoaBsOEk4HR+PL2mjyc57T1PtJX9eDaGk3/q7Maqe?= =?us-ascii?Q?P0Fz7LyG1ONhj+f8S1ggqQHtJsPSkTpsJDBfUDH3QU839cAFP8Zh9L4JcD6v?= =?us-ascii?Q?BiMxix+icikqkfQPLW0ZHFHvDHRmV6XsRnSv/vFctHtx0pbilG0HzKfAsu41?= =?us-ascii?Q?vcvzqaBdV14OVlJXkvp9cxV2GU9vQOkm6OcqPsU4PTA+jZPEjM/FJvPLMIm/?= =?us-ascii?Q?bEVSL31oOYCOgG1lSdbl5SuH+WeJ5ztZ438yjaDbSMEiRzwUyrh8uYLbav5A?= =?us-ascii?Q?FU7k75Jkn7KFyAzYnv6A9CY/S92jtOF0X0lTpDtv7bjWADTAT3ztMfEcnbvB?= =?us-ascii?Q?b4VSkuXbh1sT1hc1EiN3VHOX+6VH48wv6MPZaFfW3tdJIc4wcJrCe2EdRN0V?= =?us-ascii?Q?tr+9W872XbcE0TWT0RM4ordNb9gpptmqxdCfqWJKOW+nHBgWzukPsE6zzNQd?= =?us-ascii?Q?AQ4PFz6Kh1ReDho0U+7b2vYgwO7DWO9phl91el40bYtjOM1kDevWAg1oK/7r?= =?us-ascii?Q?ZELeUd4h+KZdoYSjnWdho9RnkVQY9HHRQHIAlZ9DD2vHYOlxE11YZ1m0wVkM?= =?us-ascii?Q?DXGDToOFWziYLYH+BAK9MY9lch7fG8VSHlMjC9J2DvQ748JZOCfpBI3F4cPL?= =?us-ascii?Q?MVp4AGEiendEUG+tN0XJnh8Iduva9ZTt6QFhovtFSt1ZAZTzO7/Tb0Upq2Z7?= =?us-ascii?Q?6WfoY9VQ0CtCk64jp2S8jtoVop9NVm/IlAK5qoisYY1XzwKWtMeUAQupYSBc?= =?us-ascii?Q?MUiEOUmcirNBA/JZxMIiSTg2XmlQIPo2yZ2g5QhmBV4EeaGt2KQLdcdeUJNB?= =?us-ascii?Q?IsRzAgg3xQfdkI5wm1tytqqHZW80on95J7dBp0NcuVCl8wp31/OXdAwUPNIY?= =?us-ascii?Q?Idzhso8yJjJhi6l/MpwiuiBZvYbd7GQYVcklFKwBEMIIvhjVpF1F/AX5fzSN?= =?us-ascii?Q?Z+TIF1KYHBpK7IPX/DEmvMRkaDw619UfGEKRY6fUAwgpvHqoQEIdXmowBDKZ?= =?us-ascii?Q?yFqEHksIulC7QvzENmZLb8GwbdSmlRv1Ax4PxNbR4lYah2Y87fbYk/3wKGic?= =?us-ascii?Q?/Drwujw4FTuTOImOT0gYEMhsXtN1I7szrfKTQDyeU2pvF6YigsKROnM6UZ1+?= =?us-ascii?Q?JGFzpYLzzT3lQQFkOkq6jhXmfO6oCaqgRUZwAxvT3mUXsHPmZtp/kr2ASsK/?= =?us-ascii?Q?qAsJHnnFNn5B/AyS+/o=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2809.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8217ced-9fb9-41df-d0a6-08da6677c646 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 15:36:23.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ey4ePu/UXhVLwZmC3GXUwLJCyZ49kxaz7T6Kwphe0STYA+8r4dglpCphU6dJrgYm0hikTPMfDnQHdSqza9wU9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1325 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, > -----Original Message----- > From: Mark Brown > Sent: Monday, July 11, 2022 8:23 PM > To: Michal Simek > Cc: Amit Kumar Mahapatra ; Krzysztof > Kozlowski ; p.yadav@ti.com; > miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; > git@xilinx.com; linux-spi@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; michael@walle.c= c; > linux-mtd@lists.infradead.org > Subject: Re: [RFC PATCH 1/2] spi: Add multiple CS support for a single SP= I > device >=20 > On Mon, Jul 11, 2022 at 02:47:54PM +0200, Michal Simek wrote: > > On 6/9/22 13:54, Mark Brown wrote: > > > On Mon, Jun 06, 2022 at 04:56:06PM +0530, Amit Kumar Mahapatra > wrote: >=20 > > > > + u32 cs[SPI_CS_CNT_MAX]; > > > > + u8 idx; > > > > /* Mode (clock phase/polarity/etc.) */ > > > > if (of_property_read_bool(nc, "spi-cpha")) >=20 > > > This is changing the DT binding but doesn't have any updates to the > > > binding document. The binding code also doesn't validate that we > > > don't have too many chip selects. >=20 > > I would like to better understand your request here in connection to > > change in the binding code for validation. > > What exactly do you want to validate? > > That child reg property is not bigger than num-cs in controller node? >=20 > If you are adding support for multiple chip selects in the driver then th= ere > must be some mechanism for expressing that in the bindings which I would > expect to see appear as a change to the binding document. Thank you for the clarification. As per my understanding we would not be needing a new DT=20 property for expressing multi chip select support in the driver. We can use "num-cs" property of the spi controller for=20 broadcasting multi chip select support of the driver. If "num-cs" value is greater than 1 then the driver can support=20 multiple chip selects. Please let us know if you have any other approach in mind. Regards, Amit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BF80C433EF for ; Fri, 15 Jul 2022 15:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sTP7ioL2+AHvzEEpdxfQAChHuGiXHHE+4GeGMxnlJX0=; b=W40UTxgnuLfbP3 OmHm/+gdyyDf1yISX/j+mvpXv9YByPpUhuImnsvhPWXhtIImo5hrwNAXHpbQT0zpoDZpJODXMEJ6g qBHjVxoKZBBJJKqe4uQFaGHf+tpJtziWnYbdiiWz7I17HCpBHIuhxnS5ETqaiBQwRNWlP2sxMGiTD tKTjPdVkr9hefigvP/8bMurEj/2sM/fiPU4CjZoFSbYE0BrURJIXvfGaesR8mgedX0DUrA/BDNPvh IWJb31IB3Ub3bz7ZDcKXz7QMowhTRZWjSfRV9r6WqMWBRj6GskUu5YyvmGBIAI39UtMmhhrqtW8gn yvnWAR5N5hI+chBoqd7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCNN4-008IUN-PJ; Fri, 15 Jul 2022 15:36:50 +0000 Received: from mail-bn1nam07on2070.outbound.protection.outlook.com ([40.107.212.70] helo=NAM02-BN1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCNMp-008I0z-3I; Fri, 15 Jul 2022 15:36:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgDvHQxlNp/DQ62JEHLCxAUdhedPRRcBes8hNR6JPLzsTUnZjBp4VEHQMXlhDJUxKtIuIkVCoFOPSurMPLUDes6W2Ta8k6Fs2+IQCn4GTLxTWkokkEYU88KB+2EQKzkYu+cVP8cSwiX2a5RtLzNNkRlfgAldDOWwkbU0MObwNQPycK0Y9fJsMJG+h5OfbYre5BjdhVJCCGHwu53sdK9ICTCYErGDWd1uPDm+Kv2PTQzMHPcvCICpaS/EXJr9iuTUjumDlt3kD7lu1ml7AbucbxVYLnrnG3pO6woERsADFlMlu4F0Rfycx2rglzblCb/P837AL8UjDB7pTLV3S+jl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=iOio8FpZiNQv3D7WuN0fIO766op+DPy9q3njYm+Gdp73D4OewgtNH5kZmtoyXRFryHSg6tmI8mP7phyJP+fJ7cbq/UfbW0ICkZNLnm9TStBcL4XYVbYYQlvPwBE7OUQyt316IMB42EYlTSoQzcpR5ajenLSWuoWawOh0cSlh65Ehfkx2FiJieJe1npKFg7lSo6+sINshflr3EVkkDaKgdUeMFGy2jMZVsoNSoEbMv4dqLnYWH0XjgNM1bex7AfWaYOPZ8XVNFGsHpDnokRZm/43WsgYDH99J6CVGZmf5liUlutvF/CyDN/dxV9AHa/uZL5eMywEYvLYtiabiJ45ghQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=GjBtdoWKU8syj4bwwnOhEK/SKbTPROm9G9LzFx5n8nfxhU4FBNxFLs519U4Aj4QvY9hWMCXv19oQQ8N9S0+CsIBBYAilcE54teofHTu2ABUI2Am1hOqzQajgrKyPCnWq8ira63rXsLKHrc+ypiiXHkyUeXrNsi7RZKKso3TFJjQ= Received: from DM6PR12MB2809.namprd12.prod.outlook.com (2603:10b6:5:4a::16) by MWHPR12MB1325.namprd12.prod.outlook.com (2603:10b6:300:f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 15:36:24 +0000 Received: from DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb]) by DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb%5]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 15:36:24 +0000 From: "Mahapatra, Amit Kumar" To: Mark Brown , Michal Simek CC: Amit Kumar Mahapatra , Krzysztof Kozlowski , "p.yadav@ti.com" , "miquel.raynal@bootlin.com" , "richard@nod.at" , "vigneshr@ti.com" , "git@xilinx.com" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "michael@walle.cc" , "linux-mtd@lists.infradead.org" , "git (AMD-Xilinx)" , "Mahapatra, Amit Kumar" Subject: RE: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Topic: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Index: AQHYeZhXApErq+32kkmuJFVVfXogSAG7F8aMAeAoVR8BtmPI/ALXxyQSrJxOXKA= Date: Fri, 15 Jul 2022 15:36:23 +0000 Message-ID: References: <20220606112607.20800-1-amit.kumar-mahapatra@xilinx.com> <20220606112607.20800-2-amit.kumar-mahapatra@xilinx.com> <40110ff8-5c19-bc54-759b-a51a919788eb@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8217ced-9fb9-41df-d0a6-08da6677c646 x-ms-traffictypediagnostic: MWHPR12MB1325:EE_ x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BI7rVEnq2FQO5MUIAzR/uqqI4oY6Rl69/LNYW23MHI3obV69DTNLpUC3zoloP7KSFUoToWK220wUZ4FG7sjxPWutcJNaQxOMCF4OgaZXW2UB4/PTdCkUUkKg4SE/hvIIYsViwoHbTMPKs+BwBWybHccNsWYS24/TBTPVkI3GICtGb/6JBUrK2WlF7kFMVN++GErthgrYDEf/OD3apzxwx75MwD2djAG7qiOa0WAthxVle7u77zCN0YxHKoSsRcgk1vqNAHPho10GLwflawGjpokYQE73vjcqfTBhmEtngK2jsLwQ4bo3fSIHW68NUwhWxyfGpMYhrT/TkJ03/JKX6JEjFpGNAi+PoVvDX5KmlWC+/1t6hnl1vCE9zhSHlZ9WtaD8pAmj615n+LtiqD1W4WCfMY0TYmrpepfUG49TzzIO6UDTLRdmlSCBZ9HRqSfJ0xId/iD8ZXIGD3b0Ywy9BYhwBWmDO13xetDmOXSU4ZpbltVYyDRxBFG5SGRbF7ymUHBTVKQu27qFY0tYZMGQMoY4YtmG3yK6F74QUXHz4wzANKeTYOgGIPH1d6SU9kdn0xP0XppMPioUo0M3adAkecPPwGc9DonO5QQ2slwMNH8uQhwsjYeA4kl2I1r6gR+NThaeiSb5ZoILmbf1juYbjyzbmS8O1Odikl8RDDkDp0C1OOli1wF/K12V3ice07KstmAsVdU8inWA1VGWG0b4ysIGEFPdYp4IA7ZYUtK7KEDYuvRdUTEMqC5faE3gOZgcMaNFKDGaDPXLNJeAeI3M6nYr9gBz2lgW0xvhYt9LqrCpVhoNbfRXIi6r/0yxATU7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2809.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(186003)(4326008)(83380400001)(55016003)(66446008)(64756008)(71200400001)(110136005)(8676002)(76116006)(66556008)(66476007)(26005)(54906003)(2906002)(9686003)(7696005)(66946007)(53546011)(6506007)(86362001)(33656002)(38100700002)(5660300002)(38070700005)(8936002)(478600001)(122000001)(41300700001)(52536014)(7416002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uQGWjl/8Pi7n+dNv3G2TidaoyfyzaWXyj6EmUnJlDcBLmO6Fre2u+axNyjBv?= =?us-ascii?Q?LYN+07Cxffm/oVzSzd2WXCW8FEomABc52V6ZlTztc3gklgQSoBGaZ0EYX9Cd?= =?us-ascii?Q?ZS1zCDFgGoJjUyhfhQoOCRuBZLNzNsJ9BaaGT/zg/NxLTFBWV0YqIsPOztgs?= =?us-ascii?Q?G4TA5tjpQbz0z1WUHTTKbH1NyQE2XGmVAWTp/aesKXnUtsZKLva+l5rKTx7g?= =?us-ascii?Q?2YIq39n4OmNfRc1a6/FIT84GS6n339a6PREKOYz//akV/eil+vemSboJgZ/v?= =?us-ascii?Q?WYVD0bpkF/8CHR+byo4FTkH6xEYUXgepxpWlM5zP/G3ixaOgOs8fwp5m+Uw6?= =?us-ascii?Q?gD4wM8jp2C8Pz5k2znbZoaBsOEk4HR+PL2mjyc57T1PtJX9eDaGk3/q7Maqe?= =?us-ascii?Q?P0Fz7LyG1ONhj+f8S1ggqQHtJsPSkTpsJDBfUDH3QU839cAFP8Zh9L4JcD6v?= =?us-ascii?Q?BiMxix+icikqkfQPLW0ZHFHvDHRmV6XsRnSv/vFctHtx0pbilG0HzKfAsu41?= =?us-ascii?Q?vcvzqaBdV14OVlJXkvp9cxV2GU9vQOkm6OcqPsU4PTA+jZPEjM/FJvPLMIm/?= =?us-ascii?Q?bEVSL31oOYCOgG1lSdbl5SuH+WeJ5ztZ438yjaDbSMEiRzwUyrh8uYLbav5A?= =?us-ascii?Q?FU7k75Jkn7KFyAzYnv6A9CY/S92jtOF0X0lTpDtv7bjWADTAT3ztMfEcnbvB?= =?us-ascii?Q?b4VSkuXbh1sT1hc1EiN3VHOX+6VH48wv6MPZaFfW3tdJIc4wcJrCe2EdRN0V?= =?us-ascii?Q?tr+9W872XbcE0TWT0RM4ordNb9gpptmqxdCfqWJKOW+nHBgWzukPsE6zzNQd?= =?us-ascii?Q?AQ4PFz6Kh1ReDho0U+7b2vYgwO7DWO9phl91el40bYtjOM1kDevWAg1oK/7r?= =?us-ascii?Q?ZELeUd4h+KZdoYSjnWdho9RnkVQY9HHRQHIAlZ9DD2vHYOlxE11YZ1m0wVkM?= =?us-ascii?Q?DXGDToOFWziYLYH+BAK9MY9lch7fG8VSHlMjC9J2DvQ748JZOCfpBI3F4cPL?= =?us-ascii?Q?MVp4AGEiendEUG+tN0XJnh8Iduva9ZTt6QFhovtFSt1ZAZTzO7/Tb0Upq2Z7?= =?us-ascii?Q?6WfoY9VQ0CtCk64jp2S8jtoVop9NVm/IlAK5qoisYY1XzwKWtMeUAQupYSBc?= =?us-ascii?Q?MUiEOUmcirNBA/JZxMIiSTg2XmlQIPo2yZ2g5QhmBV4EeaGt2KQLdcdeUJNB?= =?us-ascii?Q?IsRzAgg3xQfdkI5wm1tytqqHZW80on95J7dBp0NcuVCl8wp31/OXdAwUPNIY?= =?us-ascii?Q?Idzhso8yJjJhi6l/MpwiuiBZvYbd7GQYVcklFKwBEMIIvhjVpF1F/AX5fzSN?= =?us-ascii?Q?Z+TIF1KYHBpK7IPX/DEmvMRkaDw619UfGEKRY6fUAwgpvHqoQEIdXmowBDKZ?= =?us-ascii?Q?yFqEHksIulC7QvzENmZLb8GwbdSmlRv1Ax4PxNbR4lYah2Y87fbYk/3wKGic?= =?us-ascii?Q?/Drwujw4FTuTOImOT0gYEMhsXtN1I7szrfKTQDyeU2pvF6YigsKROnM6UZ1+?= =?us-ascii?Q?JGFzpYLzzT3lQQFkOkq6jhXmfO6oCaqgRUZwAxvT3mUXsHPmZtp/kr2ASsK/?= =?us-ascii?Q?qAsJHnnFNn5B/AyS+/o=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2809.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8217ced-9fb9-41df-d0a6-08da6677c646 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 15:36:23.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ey4ePu/UXhVLwZmC3GXUwLJCyZ49kxaz7T6Kwphe0STYA+8r4dglpCphU6dJrgYm0hikTPMfDnQHdSqza9wU9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1325 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_083635_168154_A6D336D9 X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hello Mark, > -----Original Message----- > From: Mark Brown > Sent: Monday, July 11, 2022 8:23 PM > To: Michal Simek > Cc: Amit Kumar Mahapatra ; Krzysztof > Kozlowski ; p.yadav@ti.com; > miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; > git@xilinx.com; linux-spi@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; michael@walle.cc; > linux-mtd@lists.infradead.org > Subject: Re: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI > device > > On Mon, Jul 11, 2022 at 02:47:54PM +0200, Michal Simek wrote: > > On 6/9/22 13:54, Mark Brown wrote: > > > On Mon, Jun 06, 2022 at 04:56:06PM +0530, Amit Kumar Mahapatra > wrote: > > > > > + u32 cs[SPI_CS_CNT_MAX]; > > > > + u8 idx; > > > > /* Mode (clock phase/polarity/etc.) */ > > > > if (of_property_read_bool(nc, "spi-cpha")) > > > > This is changing the DT binding but doesn't have any updates to the > > > binding document. The binding code also doesn't validate that we > > > don't have too many chip selects. > > > I would like to better understand your request here in connection to > > change in the binding code for validation. > > What exactly do you want to validate? > > That child reg property is not bigger than num-cs in controller node? > > If you are adding support for multiple chip selects in the driver then there > must be some mechanism for expressing that in the bindings which I would > expect to see appear as a change to the binding document. Thank you for the clarification. As per my understanding we would not be needing a new DT property for expressing multi chip select support in the driver. We can use "num-cs" property of the spi controller for broadcasting multi chip select support of the driver. If "num-cs" value is greater than 1 then the driver can support multiple chip selects. Please let us know if you have any other approach in mind. Regards, Amit ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D199FC433EF for ; Fri, 15 Jul 2022 15:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c1pBCPQsL63GFCgHY4TTINpFIus1ww/Jyhqf5wS3EaI=; b=SHim0CIBQkgaul 96I+8eziDUrQPB9ToRju7pkSXz+IHfe5Hx6OZLtuN68CJhOu2b+WSQXVzvdG4/7eZ03Nmr+1Xizeg Z0YfcMxsh8CzUbqWY9558TIKsj7FkYBLfCdhgJywsqbVRz48zfob5r6/m4XK07QbJv46V9Z2YXCzM +TTQni0WjSR1d9BjueIdAdNMgAr4MgIy1CQ4lfdEJfgtneNsVAm2lMIItcaUimKJRI9LWYIzfiQ0r d/hdIMJJiE/PppD5rJNQ7V3a54OZGbpZaMFNsPqOX2clLfG/0r4DcffZzp8P2xXDNKYObvzS5MZWQ CuXupL5RtfjTD0zcmFiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCNMs-008ICW-Tf; Fri, 15 Jul 2022 15:36:39 +0000 Received: from mail-bn1nam07on2070.outbound.protection.outlook.com ([40.107.212.70] helo=NAM02-BN1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCNMp-008I0z-3I; Fri, 15 Jul 2022 15:36:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgDvHQxlNp/DQ62JEHLCxAUdhedPRRcBes8hNR6JPLzsTUnZjBp4VEHQMXlhDJUxKtIuIkVCoFOPSurMPLUDes6W2Ta8k6Fs2+IQCn4GTLxTWkokkEYU88KB+2EQKzkYu+cVP8cSwiX2a5RtLzNNkRlfgAldDOWwkbU0MObwNQPycK0Y9fJsMJG+h5OfbYre5BjdhVJCCGHwu53sdK9ICTCYErGDWd1uPDm+Kv2PTQzMHPcvCICpaS/EXJr9iuTUjumDlt3kD7lu1ml7AbucbxVYLnrnG3pO6woERsADFlMlu4F0Rfycx2rglzblCb/P837AL8UjDB7pTLV3S+jl0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=iOio8FpZiNQv3D7WuN0fIO766op+DPy9q3njYm+Gdp73D4OewgtNH5kZmtoyXRFryHSg6tmI8mP7phyJP+fJ7cbq/UfbW0ICkZNLnm9TStBcL4XYVbYYQlvPwBE7OUQyt316IMB42EYlTSoQzcpR5ajenLSWuoWawOh0cSlh65Ehfkx2FiJieJe1npKFg7lSo6+sINshflr3EVkkDaKgdUeMFGy2jMZVsoNSoEbMv4dqLnYWH0XjgNM1bex7AfWaYOPZ8XVNFGsHpDnokRZm/43WsgYDH99J6CVGZmf5liUlutvF/CyDN/dxV9AHa/uZL5eMywEYvLYtiabiJ45ghQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MEnDKXwHMiQtef28w+sZKEDLQzVOMg9VaLmuUnp8lH8=; b=GjBtdoWKU8syj4bwwnOhEK/SKbTPROm9G9LzFx5n8nfxhU4FBNxFLs519U4Aj4QvY9hWMCXv19oQQ8N9S0+CsIBBYAilcE54teofHTu2ABUI2Am1hOqzQajgrKyPCnWq8ira63rXsLKHrc+ypiiXHkyUeXrNsi7RZKKso3TFJjQ= Received: from DM6PR12MB2809.namprd12.prod.outlook.com (2603:10b6:5:4a::16) by MWHPR12MB1325.namprd12.prod.outlook.com (2603:10b6:300:f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 15:36:24 +0000 Received: from DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb]) by DM6PR12MB2809.namprd12.prod.outlook.com ([fe80::fcd1:f8aa:6c69:eacb%5]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 15:36:24 +0000 From: "Mahapatra, Amit Kumar" To: Mark Brown , Michal Simek CC: Amit Kumar Mahapatra , Krzysztof Kozlowski , "p.yadav@ti.com" , "miquel.raynal@bootlin.com" , "richard@nod.at" , "vigneshr@ti.com" , "git@xilinx.com" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "michael@walle.cc" , "linux-mtd@lists.infradead.org" , "git (AMD-Xilinx)" , "Mahapatra, Amit Kumar" Subject: RE: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Topic: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI device Thread-Index: AQHYeZhXApErq+32kkmuJFVVfXogSAG7F8aMAeAoVR8BtmPI/ALXxyQSrJxOXKA= Date: Fri, 15 Jul 2022 15:36:23 +0000 Message-ID: References: <20220606112607.20800-1-amit.kumar-mahapatra@xilinx.com> <20220606112607.20800-2-amit.kumar-mahapatra@xilinx.com> <40110ff8-5c19-bc54-759b-a51a919788eb@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8217ced-9fb9-41df-d0a6-08da6677c646 x-ms-traffictypediagnostic: MWHPR12MB1325:EE_ x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BI7rVEnq2FQO5MUIAzR/uqqI4oY6Rl69/LNYW23MHI3obV69DTNLpUC3zoloP7KSFUoToWK220wUZ4FG7sjxPWutcJNaQxOMCF4OgaZXW2UB4/PTdCkUUkKg4SE/hvIIYsViwoHbTMPKs+BwBWybHccNsWYS24/TBTPVkI3GICtGb/6JBUrK2WlF7kFMVN++GErthgrYDEf/OD3apzxwx75MwD2djAG7qiOa0WAthxVle7u77zCN0YxHKoSsRcgk1vqNAHPho10GLwflawGjpokYQE73vjcqfTBhmEtngK2jsLwQ4bo3fSIHW68NUwhWxyfGpMYhrT/TkJ03/JKX6JEjFpGNAi+PoVvDX5KmlWC+/1t6hnl1vCE9zhSHlZ9WtaD8pAmj615n+LtiqD1W4WCfMY0TYmrpepfUG49TzzIO6UDTLRdmlSCBZ9HRqSfJ0xId/iD8ZXIGD3b0Ywy9BYhwBWmDO13xetDmOXSU4ZpbltVYyDRxBFG5SGRbF7ymUHBTVKQu27qFY0tYZMGQMoY4YtmG3yK6F74QUXHz4wzANKeTYOgGIPH1d6SU9kdn0xP0XppMPioUo0M3adAkecPPwGc9DonO5QQ2slwMNH8uQhwsjYeA4kl2I1r6gR+NThaeiSb5ZoILmbf1juYbjyzbmS8O1Odikl8RDDkDp0C1OOli1wF/K12V3ice07KstmAsVdU8inWA1VGWG0b4ysIGEFPdYp4IA7ZYUtK7KEDYuvRdUTEMqC5faE3gOZgcMaNFKDGaDPXLNJeAeI3M6nYr9gBz2lgW0xvhYt9LqrCpVhoNbfRXIi6r/0yxATU7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2809.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(366004)(186003)(4326008)(83380400001)(55016003)(66446008)(64756008)(71200400001)(110136005)(8676002)(76116006)(66556008)(66476007)(26005)(54906003)(2906002)(9686003)(7696005)(66946007)(53546011)(6506007)(86362001)(33656002)(38100700002)(5660300002)(38070700005)(8936002)(478600001)(122000001)(41300700001)(52536014)(7416002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uQGWjl/8Pi7n+dNv3G2TidaoyfyzaWXyj6EmUnJlDcBLmO6Fre2u+axNyjBv?= =?us-ascii?Q?LYN+07Cxffm/oVzSzd2WXCW8FEomABc52V6ZlTztc3gklgQSoBGaZ0EYX9Cd?= =?us-ascii?Q?ZS1zCDFgGoJjUyhfhQoOCRuBZLNzNsJ9BaaGT/zg/NxLTFBWV0YqIsPOztgs?= =?us-ascii?Q?G4TA5tjpQbz0z1WUHTTKbH1NyQE2XGmVAWTp/aesKXnUtsZKLva+l5rKTx7g?= =?us-ascii?Q?2YIq39n4OmNfRc1a6/FIT84GS6n339a6PREKOYz//akV/eil+vemSboJgZ/v?= =?us-ascii?Q?WYVD0bpkF/8CHR+byo4FTkH6xEYUXgepxpWlM5zP/G3ixaOgOs8fwp5m+Uw6?= =?us-ascii?Q?gD4wM8jp2C8Pz5k2znbZoaBsOEk4HR+PL2mjyc57T1PtJX9eDaGk3/q7Maqe?= =?us-ascii?Q?P0Fz7LyG1ONhj+f8S1ggqQHtJsPSkTpsJDBfUDH3QU839cAFP8Zh9L4JcD6v?= =?us-ascii?Q?BiMxix+icikqkfQPLW0ZHFHvDHRmV6XsRnSv/vFctHtx0pbilG0HzKfAsu41?= =?us-ascii?Q?vcvzqaBdV14OVlJXkvp9cxV2GU9vQOkm6OcqPsU4PTA+jZPEjM/FJvPLMIm/?= =?us-ascii?Q?bEVSL31oOYCOgG1lSdbl5SuH+WeJ5ztZ438yjaDbSMEiRzwUyrh8uYLbav5A?= =?us-ascii?Q?FU7k75Jkn7KFyAzYnv6A9CY/S92jtOF0X0lTpDtv7bjWADTAT3ztMfEcnbvB?= =?us-ascii?Q?b4VSkuXbh1sT1hc1EiN3VHOX+6VH48wv6MPZaFfW3tdJIc4wcJrCe2EdRN0V?= =?us-ascii?Q?tr+9W872XbcE0TWT0RM4ordNb9gpptmqxdCfqWJKOW+nHBgWzukPsE6zzNQd?= =?us-ascii?Q?AQ4PFz6Kh1ReDho0U+7b2vYgwO7DWO9phl91el40bYtjOM1kDevWAg1oK/7r?= =?us-ascii?Q?ZELeUd4h+KZdoYSjnWdho9RnkVQY9HHRQHIAlZ9DD2vHYOlxE11YZ1m0wVkM?= =?us-ascii?Q?DXGDToOFWziYLYH+BAK9MY9lch7fG8VSHlMjC9J2DvQ748JZOCfpBI3F4cPL?= =?us-ascii?Q?MVp4AGEiendEUG+tN0XJnh8Iduva9ZTt6QFhovtFSt1ZAZTzO7/Tb0Upq2Z7?= =?us-ascii?Q?6WfoY9VQ0CtCk64jp2S8jtoVop9NVm/IlAK5qoisYY1XzwKWtMeUAQupYSBc?= =?us-ascii?Q?MUiEOUmcirNBA/JZxMIiSTg2XmlQIPo2yZ2g5QhmBV4EeaGt2KQLdcdeUJNB?= =?us-ascii?Q?IsRzAgg3xQfdkI5wm1tytqqHZW80on95J7dBp0NcuVCl8wp31/OXdAwUPNIY?= =?us-ascii?Q?Idzhso8yJjJhi6l/MpwiuiBZvYbd7GQYVcklFKwBEMIIvhjVpF1F/AX5fzSN?= =?us-ascii?Q?Z+TIF1KYHBpK7IPX/DEmvMRkaDw619UfGEKRY6fUAwgpvHqoQEIdXmowBDKZ?= =?us-ascii?Q?yFqEHksIulC7QvzENmZLb8GwbdSmlRv1Ax4PxNbR4lYah2Y87fbYk/3wKGic?= =?us-ascii?Q?/Drwujw4FTuTOImOT0gYEMhsXtN1I7szrfKTQDyeU2pvF6YigsKROnM6UZ1+?= =?us-ascii?Q?JGFzpYLzzT3lQQFkOkq6jhXmfO6oCaqgRUZwAxvT3mUXsHPmZtp/kr2ASsK/?= =?us-ascii?Q?qAsJHnnFNn5B/AyS+/o=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2809.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8217ced-9fb9-41df-d0a6-08da6677c646 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 15:36:23.9548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ey4ePu/UXhVLwZmC3GXUwLJCyZ49kxaz7T6Kwphe0STYA+8r4dglpCphU6dJrgYm0hikTPMfDnQHdSqza9wU9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1325 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_083635_168154_A6D336D9 X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Mark, > -----Original Message----- > From: Mark Brown > Sent: Monday, July 11, 2022 8:23 PM > To: Michal Simek > Cc: Amit Kumar Mahapatra ; Krzysztof > Kozlowski ; p.yadav@ti.com; > miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; > git@xilinx.com; linux-spi@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; michael@walle.cc; > linux-mtd@lists.infradead.org > Subject: Re: [RFC PATCH 1/2] spi: Add multiple CS support for a single SPI > device > > On Mon, Jul 11, 2022 at 02:47:54PM +0200, Michal Simek wrote: > > On 6/9/22 13:54, Mark Brown wrote: > > > On Mon, Jun 06, 2022 at 04:56:06PM +0530, Amit Kumar Mahapatra > wrote: > > > > > + u32 cs[SPI_CS_CNT_MAX]; > > > > + u8 idx; > > > > /* Mode (clock phase/polarity/etc.) */ > > > > if (of_property_read_bool(nc, "spi-cpha")) > > > > This is changing the DT binding but doesn't have any updates to the > > > binding document. The binding code also doesn't validate that we > > > don't have too many chip selects. > > > I would like to better understand your request here in connection to > > change in the binding code for validation. > > What exactly do you want to validate? > > That child reg property is not bigger than num-cs in controller node? > > If you are adding support for multiple chip selects in the driver then there > must be some mechanism for expressing that in the bindings which I would > expect to see appear as a change to the binding document. Thank you for the clarification. As per my understanding we would not be needing a new DT property for expressing multi chip select support in the driver. We can use "num-cs" property of the spi controller for broadcasting multi chip select support of the driver. If "num-cs" value is greater than 1 then the driver can support multiple chip selects. Please let us know if you have any other approach in mind. Regards, Amit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel