All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhuo, Qingqing (Lillian)" <Qingqing.Zhuo@amd.com>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Wang, Chao-kai \(Stylon\)" <Stylon.Wang@amd.com>,
	"Cyr, Aric" <Aric.Cyr@amd.com>,
	"Jacob, Anson" <Anson.Jacob@amd.com>,
	"Li, Sun peng \(Leo\)" <Sunpeng.Li@amd.com>,
	"Lakha, Bhawanpreet" <Bhawanpreet.Lakha@amd.com>,
	"Lin, Wayne" <Wayne.Lin@amd.com>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	"Li, Roman" <Roman.Li@amd.com>,
	"Chiu, Solomon" <Solomon.Chiu@amd.com>,
	"Pillai, Aurabindo" <Aurabindo.Pillai@amd.com>,
	"Leung, Martin" <Martin.Leung@amd.com>,
	"Lipski, Mikita" <Mikita.Lipski@amd.com>,
	"Wentland, Harry" <Harry.Wentland@amd.com>,
	"Gutierrez, Agustin" <Agustin.Gutierrez@amd.com>,
	"Kotarac, Pavle" <Pavle.Kotarac@amd.com>
Subject: RE: [PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr
Date: Mon, 22 Nov 2021 17:15:53 +0000	[thread overview]
Message-ID: <DM6PR12MB33061790756C46BF6D6DC4F2FB9F9@DM6PR12MB3306.namprd12.prod.outlook.com> (raw)
In-Reply-To: <BL1PR12MB514434CD840471692E9894A2F79F9@BL1PR12MB5144.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 4540 bytes --]

[Public]

Hi Alex,

Thank you for the advice! Last week's DC candidate has in fact already been merged to upstream, but I will bring up your suggestion to the patch author for review.

Thank you,
Lillian
From: Deucher, Alexander <Alexander.Deucher@amd.com>
Sent: Monday, November 22, 2021 10:38 AM
To: Zhuo, Qingqing (Lillian) <Qingqing.Zhuo@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; Cyr, Aric <Aric.Cyr@amd.com>; Chiu, Solomon <Solomon.Chiu@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Leung, Martin <Martin.Leung@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Li, Roman <Roman.Li@amd.com>; Jacob, Anson <Anson.Jacob@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Lin, Wayne <Wayne.Lin@amd.com>; Lipski, Mikita <Mikita.Lipski@amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Gutierrez, Agustin <Agustin.Gutierrez@amd.com>; Kotarac, Pavle <Pavle.Kotarac@amd.com>
Subject: Re: [PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr


[Public]

Do you want to change the ASICREV_IS_BEIGE_GOBY_P() check to else if as well?  maybe something like:

if (ASICREV_IS_SIENNA_CICHLID_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) ||
    ASICREV_IS_DIMGREY_CAVEFISH_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) ||
     ASICREV_IS_BEIGE_GOBY_P(clk_mgr_base->ctx->asic_id.hw_internal_rev))
         dcn3_clk_mgr_destroy(clk_mgr);

Alex
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org<mailto:amd-gfx-bounces@lists.freedesktop.org>> on behalf of Qingqing Zhuo <qingqing.zhuo@amd.com<mailto:qingqing.zhuo@amd.com>>
Sent: Friday, November 19, 2021 2:43 PM
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>>
Cc: Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com<mailto:Stylon.Wang@amd.com>>; Cyr, Aric <Aric.Cyr@amd.com<mailto:Aric.Cyr@amd.com>>; Chiu, Solomon <Solomon.Chiu@amd.com<mailto:Solomon.Chiu@amd.com>>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com<mailto:Sunpeng.Li@amd.com>>; Wentland, Harry <Harry.Wentland@amd.com<mailto:Harry.Wentland@amd.com>>; Zhuo, Qingqing (Lillian) <Qingqing.Zhuo@amd.com<mailto:Qingqing.Zhuo@amd.com>>; Leung, Martin <Martin.Leung@amd.com<mailto:Martin.Leung@amd.com>>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com<mailto:Rodrigo.Siqueira@amd.com>>; Li, Roman <Roman.Li@amd.com<mailto:Roman.Li@amd.com>>; Jacob, Anson <Anson.Jacob@amd.com<mailto:Anson.Jacob@amd.com>>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com<mailto:Aurabindo.Pillai@amd.com>>; Lin, Wayne <Wayne.Lin@amd.com<mailto:Wayne.Lin@amd.com>>; Lipski, Mikita <Mikita.Lipski@amd.com<mailto:Mikita.Lipski@amd.com>>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com<mailto:Bhawanpreet.Lakha@amd.com>>; Gutierrez, Agustin <Agustin.Gutierrez@amd.com<mailto:Agustin.Gutierrez@amd.com>>; Kotarac, Pavle <Pavle.Kotarac@amd.com<mailto:Pavle.Kotarac@amd.com>>
Subject: [PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr

From: Martin Leung <Martin.Leung@amd.com<mailto:Martin.Leung@amd.com>>

[Why & How]
when changing some code we accidentally
changed else if-> if. reverting that.

Reviewed-by: Aric Cyr <Aric.Cyr@amd.com<mailto:Aric.Cyr@amd.com>>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com<mailto:qingqing.zhuo@amd.com>>
Signed-off-by: Martin Leung <Martin.Leung@amd.com<mailto:Martin.Leung@amd.com>>
---
 drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
index 26f96ee32472..9200c8ce02ba 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
@@ -308,8 +308,7 @@ void dc_destroy_clk_mgr(struct clk_mgr *clk_mgr_base)
         case FAMILY_NV:
                 if (ASICREV_IS_SIENNA_CICHLID_P(clk_mgr_base->ctx->asic_id.hw_internal_rev)) {
                         dcn3_clk_mgr_destroy(clk_mgr);
-               }
-               if (ASICREV_IS_DIMGREY_CAVEFISH_P(clk_mgr_base->ctx->asic_id.hw_internal_rev)) {
+               } else if (ASICREV_IS_DIMGREY_CAVEFISH_P(clk_mgr_base->ctx->asic_id.hw_internal_rev)) {
                         dcn3_clk_mgr_destroy(clk_mgr);
                 }
                 if (ASICREV_IS_BEIGE_GOBY_P(clk_mgr_base->ctx->asic_id.hw_internal_rev)) {
--
2.25.1

[-- Attachment #2: Type: text/html, Size: 10352 bytes --]

  reply	other threads:[~2021-11-22 17:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 19:43 [PATCH 00/16] DC Patches November 22nd, 2021 Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 01/16] drm/amd/display: Fix DPIA outbox timeout after GPU reset Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 02/16] drm/amd/display: based on flag reset z10 function pointer Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 03/16] drm/amd/display: Run full global validation in dc_commit_state Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 04/16] drm/amd/display: enable seamless boot for DCN301 Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 05/16] drm/amd/display: Set plane update flags for all planes in reset Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 06/16] drm/amd/display: fixed an error related to 4:2:0/4:2:2 DSC Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 07/16] drm/amd/display: Reset link encoder assignments for GPU reset Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 08/16] drm/amd/display: Rename dcn_validate_bandwidth to dcn10_validate_bandwidth Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 09/16] drm/amd/display: retain/release at proper places in link_enc assignment Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 10/16] drm/amd/display: fix accidental casting enum to bool Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 11/16] drm/amd/display: Display object info table changes Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 12/16] drm/amd/display: Fixed DSC would not PG after removing DSC stream Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 13/16] drm/amd/display: Fix ODM combine issue with fast boot Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr Qingqing Zhuo
2021-11-22 15:38   ` Deucher, Alexander
2021-11-22 17:15     ` Zhuo, Qingqing (Lillian) [this message]
2021-11-19 19:43 ` [PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.94 Qingqing Zhuo
2021-11-19 19:43 ` [PATCH 16/16] drm/amd/display: 3.2.163 Qingqing Zhuo
2021-11-22 14:27 ` [PATCH 00/16] DC Patches November 22nd, 2021 Wheeler, Daniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB33061790756C46BF6D6DC4F2FB9F9@DM6PR12MB3306.namprd12.prod.outlook.com \
    --to=qingqing.zhuo@amd.com \
    --cc=Agustin.Gutierrez@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Anson.Jacob@amd.com \
    --cc=Aric.Cyr@amd.com \
    --cc=Aurabindo.Pillai@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Martin.Leung@amd.com \
    --cc=Mikita.Lipski@amd.com \
    --cc=Pavle.Kotarac@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Roman.Li@amd.com \
    --cc=Solomon.Chiu@amd.com \
    --cc=Stylon.Wang@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=Wayne.Lin@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.