From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E923C07E9D for ; Mon, 26 Sep 2022 11:54:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B5C384DC4; Mon, 26 Sep 2022 13:53:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="L782uw17"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 67EC283869; Mon, 26 Sep 2022 08:45:46 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C429283869 for ; Mon, 26 Sep 2022 08:45:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=venkatesh.abbarapu@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y+7Py5VBRfzcOauoYsfi912iCo4Ko0Gg0bhlAfNz6O80MDUYIfwOULRfYl5UuGwIHZydNf9aewdWBeVQMNRf0yh8PYBMjmqKFjiuj8T3aOqj95AxjGFkstP9yrj5IUsDTMgUa1a0HMGSi+wwem+JI4Nl5CV6cQVHlc4Ppn6/5lPhGa8K6VW59yCmgwuotlgqmHTUIvtB5Uj7OqZhovGY4xZNkVK6pRgtJoALfNpDXNKmUOz+BD816Vh4JbdM/aaw5/yTmgr8MbD4ltGhP0fNqRShwHVqJQS9XtKarDrwZ/ajPB43FAXztOoJRUj1ah6scdZu5rwjJPeLxVes/ctQtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqhyzYUiql8j8UDL8Nk0jLcpdX8msR7IaugxDJ1d+Vw=; b=lT+Qg3brhq6J3MowetiCAfLIFNT4CVL2PIhZqlJp2PpT2Vl6dc95vN3lkKCHfPHPOGJKaBmTkKnOr/oRCzJR9+TxhevQykrqc4Hp28Au9gpvk8XPsTpY0rc/Xghqjd70Bio5G1GUT16FW6YthTzhaZM6T348x0OlsqE0r7EO3UuOziMKeVfy49mTz7YPYtzGytmnovYs8c3W3TMRVzXPjWpb4X/WYXWVIw2Dp5ETX6m3xqUE3wUl0y5sU5gmuiH8yWTL2QpDsdv2kZnxdsP4QEnb0lS/cqxEE6byakM9vvyzCTGqECgn3NlqpT7ofgiXVlAgoZK1RozFUTb1f14tkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqhyzYUiql8j8UDL8Nk0jLcpdX8msR7IaugxDJ1d+Vw=; b=L782uw17jY1iHMxjSDtsGfAbw+6qKQEpT0zT5ZgxEMH4+wlLTNkIjYc8KkJzjf8m8R3/vZkvZIplslr7ZCxG4lxU90qiakEBa1Fk/I1IBpZCWNGYG/gAC+1eHjSX9T9RzP/oXdQAC29qMG0O13dnFXOtAZkF56A14RB4g3e9aDk= Received: from DM6PR12MB3738.namprd12.prod.outlook.com (2603:10b6:5:1c7::17) by BY5PR12MB4066.namprd12.prod.outlook.com (2603:10b6:a03:207::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 06:45:27 +0000 Received: from DM6PR12MB3738.namprd12.prod.outlook.com ([fe80::4128:1bea:a97c:336c]) by DM6PR12MB3738.namprd12.prod.outlook.com ([fe80::4128:1bea:a97c:336c%6]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 06:45:27 +0000 From: "Abbarapu, Venkatesh" To: "Abbarapu, Venkatesh" , "u-boot@lists.denx.de" CC: "Simek, Michal" , "git@xilinx.com" Subject: RE: [v2 UBOOT PATCH 1/3] xilinx: common: Fix static checker warnings Thread-Topic: [v2 UBOOT PATCH 1/3] xilinx: common: Fix static checker warnings Thread-Index: AQHY0XDWBm3YQLSdtk6CiuUsh5Mu2a3xRClw Date: Mon, 26 Sep 2022 06:45:26 +0000 Message-ID: References: <20220926062504.2205-1-venkatesh.abbarapu@amd.com> In-Reply-To: <20220926062504.2205-1-venkatesh.abbarapu@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3738:EE_|BY5PR12MB4066:EE_ x-ms-office365-filtering-correlation-id: b4aa8f75-dfc5-4b2f-40a1-08da9f8ab230 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lEhkWo/uCH/zitivALaQVnhVsvl4fsxP5T3eYJ5nVpPjh+kB0VktRKXFjSzsSzAH2JFWjSmHI8bs6ur5k3FskmEV0mLomVNEqUIINGyPo+hkXV7vBDbbdt7gIAYBS1JYp3ffl+E8W87aYr9jlxiTZKGKXDnr3dcrfUx9OjCxI8t4Rj585ZXna2WdIW6jix2QrlBDQqnxZDWN34J2NCE69EJVH+Czg8lRcjcejUD2K9fw5o2FKEl4nAttsFR/1QSS+YovCbHGh3dujXnPDdYGUsF+lfRaNrm6JFqnCLqFFQIcczVRd87xSXHVF43+UENFYm1GRa0Dk/7ALnLYX651cp49h860jxtH3RJVst4xDfNoZZWXd5+skseZmrVgivL7AhKFhY+TGSajRg8Hp+I/GQou27rXbmzO011Yv14Xo2P5/j8wjWXHbHmBVyz5EpmJDsZ8b1tgKYiiLhyFLJldFOjUj11Livcb2fG1s7rgm60q9DcnHOLNXHObwlKxKMEyJfb9n72dZhKDry8FlaJCUdVIe7eygHentbUMF9ONHagoxtTYdwYu1HZfPjTSJBrQHflr2+Yf+uOai4l/YtX51ZQ4HCi6sh813X2A9zT0TvdyZ7ZBz6laNFdyIAT+vE4kjIM3es8bmbhnSNWU1BzTYP1aHp4VX907ms4s/qxmfOo9ze9HPz+5KYt17CvtgY2OKHruf7+Jh4PSYVaelboVTnTP/KNLW8u47XDPzxxjAN2N+BuifgMMvf4p+t0AyHJ+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3738.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199015)(55016003)(54906003)(110136005)(66946007)(66476007)(66446008)(64756008)(71200400001)(478600001)(66556008)(8676002)(316002)(4326008)(76116006)(86362001)(33656002)(107886003)(122000001)(41300700001)(83380400001)(26005)(9686003)(5660300002)(52536014)(6506007)(8936002)(53546011)(7696005)(2906002)(38100700002)(38070700005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9oOzNkAVueCBAogmOehVCFsc3MyrTeByZLNoN2/Jz7dICq0+5IOUc2cvzcs+?= =?us-ascii?Q?9D79ChY3+kIv0kIzp3zNagZ4DX2PsW4q5zONf9tDiV9UgFCcBAXsz0qIbp1l?= =?us-ascii?Q?/3PzZnJXowsKwRVGrUmQtAfd3/zd23LhA46Gr3lUTzAUTxJzfYVxJ9NnbsJZ?= =?us-ascii?Q?PDrQrChbqaEP3tkZNKwPeYE3j0vK8kfhkVeJukFV1BzUqt8GO+VMcH66TYOE?= =?us-ascii?Q?GXK2VTBx0kXI5oLej57KX6lAJPNT34ZWlb5bWB7rEdc5BSYb3LHdDXVX+zYX?= =?us-ascii?Q?Fn3xALwzqJN4ENtUTgdQMuKFaWEt7Ls4ki9EqujDLX5Q0sxcdJhwkMLS2x/D?= =?us-ascii?Q?ESvM0bMfx08VmRilSSg3miP6NlEXTH+r6LRa6IzrzME6kLSWma/YAv6jSn3G?= =?us-ascii?Q?NUubTJuN4TtLKWiJj/6PR2WqzMi2O3jj5nY71veaeQQp+tN53vHsE4FZHvJf?= =?us-ascii?Q?s5DEhGe07rgR7RNI04bJLRoETzwhVIZXuPL8k+udRl+p4akxhDFuX0bHGmz/?= =?us-ascii?Q?Mwi6VvazR1hOekpx0AqglVhc5qW8XsKgfWXtl85MsyQcgpiR///xU7svVl6B?= =?us-ascii?Q?vzUaxTKRc6xEF5zDKrNAH2TETWpLsxyEoZzpqCtm8BYM8P55u+f22pYJq0vB?= =?us-ascii?Q?/p5mcPkvy2if9mHohGRAFHb/NXNQeoowmvhl/G80feK+epfN+BzjfzL06vsZ?= =?us-ascii?Q?r42vT2LAEEh8of4g9MNlPqPAJQniHxlPNAswYHLvGvMWesmMt55Kcf9fnyXi?= =?us-ascii?Q?oiRRgiNDdVy+wNTOoz76I4nKjxnx6EGMInzdrI8i4Khal51DixWqkylG4cKh?= =?us-ascii?Q?DlpbqSyuyMYjax9lKtsCYn3dygR2C/kVrwoJez60o5wEl69q/0CSVGJDbO/V?= =?us-ascii?Q?3rfU0i/w6yCfINjhY6rEg0vbvzPQaVCfJx/qUWnOcylmZYlCmf0yBxOz4OL/?= =?us-ascii?Q?67pRHpw4y859jDFGTpfpOgLRwu2aoI2716DWd6+Talm14GxDywZh6W8a+xQY?= =?us-ascii?Q?NkUOKAuKFMKsiOiPw6yQdNo82E+WKQEg2egkJkvhZosM/0yndXKZVb/hEo3B?= =?us-ascii?Q?gDwRdWZitDjIeVxJawPATBNG8FVDm9V5CIIpD3TbzruFWoZwBAYttnxo6Vtd?= =?us-ascii?Q?MzQBYCCP7RkvGvyXK2cnEZhfYNelyZ8xXDAWCMOn70uPxs+ubU3Kw3aMHkm5?= =?us-ascii?Q?gAxg0YIvYyNlu9E7rvMnWqK10Zdk8fWc8d07Gz27ZFsXKKR8eQLILXjGZCqv?= =?us-ascii?Q?WGsCaPzkyfvBsnp8Gb0vBrzGSv16Y/sXIqlssWrjDwCjQ3Lhw9VOodMDg140?= =?us-ascii?Q?BmdrtnDAF0XCaFZoAe3zsaq3l9xF7no/WZhsuHq7GY7CWQjtMextb5By14Og?= =?us-ascii?Q?oqKfaq9OpqMFeb7Ki8+gSTZuOo1CxgEJxtJs+/pKDJ1/JA0EcpX8n/B/bfjI?= =?us-ascii?Q?cpealMBwQCM45P0p4khQ+1TlVRlShwyP2GnC34QA8ZO0fthI9TJ6UetqbGEi?= =?us-ascii?Q?uoD00fUzeOsDI808Jx7fdADjxi+GXmdDrm20avHcwbLSKUxkiNj6mQhwAPk5?= =?us-ascii?Q?JrVimlf+BkP8nWHucw0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3738.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4aa8f75-dfc5-4b2f-40a1-08da9f8ab230 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2022 06:45:27.0000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +qumsW11qfCMNygCpRv3lr5z7ncUQNK49fyTrRvrXo+0XrEL9dDaxQLN/gInKTg/Aa3CUVdMp1EF9dPwZ78oiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4066 X-Mailman-Approved-At: Mon, 26 Sep 2022 13:53:20 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Please ignore this patch. Thanks Venkatesh > -----Original Message----- > From: Venkatesh Yadav Abbarapu > Sent: Monday, September 26, 2022 11:55 AM > To: u-boot@lists.denx.de > Cc: Simek, Michal ; git@xilinx.com > Subject: [v2 UBOOT PATCH 1/3] xilinx: common: Fix static checker warnings >=20 > Avoid signed extension for uuid and byte. >=20 > Eliminate the below smatch warnings: > board/xilinx/common/board.c:128 xilinx_eeprom_legacy_cleanup() > warn: impossible condition '(byte =3D=3D 255) =3D> ((-128)-127 =3D=3D 255= )' >=20 > board/xilinx/common/board.c:466 board_late_init_xilinx() > warn: argument 3 to %02x specifier has type 'char' > board/xilinx/common/board.c:466 board_late_init_xilinx() > warn: argument 4 to %02x specifier has type 'char' >=20 > Signed-off-by: Venkatesh Yadav Abbarapu > > --- > board/xilinx/common/board.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c > index 9b4aded466..2b6ead5269 100644 > --- a/board/xilinx/common/board.c > +++ b/board/xilinx/common/board.c > @@ -119,7 +119,7 @@ struct xilinx_legacy_format { static void > xilinx_eeprom_legacy_cleanup(char *eeprom, int size) { > int i; > - char byte; > + unsigned char byte; >=20 > for (i =3D 0; i < size; i++) { > byte =3D eeprom[i]; > @@ -458,8 +458,8 @@ int board_late_init_xilinx(void) > desc->serial); >=20 > if (desc->uuid[0]) { > - char uuid[UUID_STR_LEN + 1]; > - char *t =3D desc->uuid; > + unsigned char uuid[UUID_STR_LEN + 1]; > + unsigned char *t =3D desc->uuid; >=20 > memset(uuid, 0, UUID_STR_LEN + 1); >=20 > -- > 2.17.1