From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: RE: [PATCH] app/testpmd: fix flex item input link parsing
Date: Mon, 14 Mar 2022 08:48:05 +0000 [thread overview]
Message-ID: <DM6PR12MB37537433275213ABAA50764ADF0F9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220310055953.32380-1-getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, March 10, 2022 8:00
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org; Xiaoyun Li <xiaoyun.li@intel.com>; Aman Singh
> <aman.deep.singh@intel.com>; Yuying Zhang <yuying.zhang@intel.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH] app/testpmd: fix flex item input link parsing
>
> Testpmd reads flex item configuration from a JSON file.
> Flex item input link description is stored in testpmd flow item format. For
> example, `eth type is 0x0800`.
> The item description is placed into a general testpmd CLI flow rule command
> template and parsed to convert string into flow item object.
>
> The patch adds the `actions` section to the flow rule template.
>
> Cc: stable@dpdk.org
>
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
> app/test-pmd/cmd_flex_item.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c
> index 9050825a81..78a89c0f8a 100644
> --- a/app/test-pmd/cmd_flex_item.c
> +++ b/app/test-pmd/cmd_flex_item.c
> @@ -133,7 +133,8 @@ flex_link_item_parse(const char *src, struct
> rte_flow_item *item)
> struct rte_flow_item *pattern;
> struct rte_flow_action *actions;
>
> - sprintf(flow_rule, "flow create 0 pattern %s / end", src);
> + sprintf(flow_rule,
> + "flow create 0 pattern %s / end actions drop / end", src);
> src = flow_rule;
> ret = flow_parse(src, (void *)data, sizeof(data),
> &attr, &pattern, &actions);
> --
> 2.35.1
next prev parent reply other threads:[~2022-03-14 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 5:59 [PATCH] app/testpmd: fix flex item input link parsing Gregory Etelson
2022-03-14 8:48 ` Slava Ovsiienko [this message]
2022-03-14 21:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB37537433275213ABAA50764ADF0F9@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.