Re: [alsa-devel] [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver

From: "RAVULAPATI, VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: "pierre-louis.bossart@linux.intel.com"
	<pierre-louis.bossart@linux.intel.com>,
	"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
	MANAGEM..." <alsa-devel@alsa-project.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	YueHaibing <yuehaibing@huawei.com>, Takashi Iwai <tiwai@suse.com>,
	"djkurtz@google.com" <djkurtz@google.com>,
	"Mukunda,  Vijendar" <Vijendar.Mukunda@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver
Date: Sat, 28 Dec 2019 02:01:27 +0000	[thread overview]
Message-ID: <DM6PR12MB3868304F748AD00C4AEF8688E7250@DM6PR12MB3868.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191227225555.GA3897@sirena.org.uk>

[AMD Official Use Only - Internal Distribution Only]

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Mark Brown <broonie@kernel.org>
Sent: Saturday 28 December 2019, 4:26 AM
To: RAVULAPATI, VISHNU VARDHAN RAO
Cc: Deucher, Alexander; djkurtz@google.com; pierre-louis.bossart@linux.intel.com; Liam Girdwood; Jaroslav Kysela; Takashi Iwai; Mukunda, Vijendar; YueHaibing; Kuninori Morimoto; Dan Carpenter; open list; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...
Subject: Re: [PATCH 1/6] ASoC: amd: Refactoring of DAI from DMA driver

On Fri, Dec 27, 2019 at 06:20:50PM +0530, Ravulapati Vishnu vardhan rao wrote:
> ASoC: PCM DMA driver should only have dma ops.
> So Removed all DAI related functionality.Refactoring
> the PCM DMA diver code.Added new file containing only DAI ops

This breaks the build:

It's unfortunate.i noticed but applied the same in 2/6 assuming that the same as 1/6.

  CC      sound/soc/amd/raven/acp3x-i2s.o
In file included from sound/soc/amd/raven/pci-acp3x.c:13:
sound/soc/amd/raven/acp3x.h: In function ‘acp_get_byte_count’:
sound/soc/amd/raven/acp3x.h:94:19: error: ‘SNDRV_PCM_STREAM_PLAYBACK’ undeclared (first use in this function)
  if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/amd/raven/acp3x.h:94:19: note: each undeclared identifier is reported only once for each function it appears in

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel