From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431F2C43460 for ; Tue, 13 Apr 2021 15:46:20 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id C19866128C for ; Tue, 13 Apr 2021 15:46:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C19866128C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2617161134; Tue, 13 Apr 2021 17:46:18 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2070.outbound.protection.outlook.com [40.107.101.70]) by mails.dpdk.org (Postfix) with ESMTP id 3FE4B161130 for ; Tue, 13 Apr 2021 17:46:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUH/9w5K7qW2H/EZIkV4zy7TFqtW8VwjF5YfLEwhJjNNApnu2Bw6NG5hajVlVSWxTtGbImqOucwt6uKj8iUN+gsW7zxReyDTvFuJTT+0LGeDl38/Dx5xmkOJlRqegCKdXolcjr/grCGAvy7ccM8D9Vo7XpMfqBOHy3TJEMAFS3iuRHQG1brMtInANmef1Yrnc4hdb3Od45cIH5yBZztMuoQTWk/3SbkkuzZi/MGKwouy5lsS2UwVLBV61k7KYQeEuXizOij5y+mWrxU2UbaD6v12lwKZE27q0RLXjTo0lNitpk9dvqbhJRJAzb8f+rHel1VxX/fDyPwPIeYTHWmVjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gvwd579G37b+X5nphcABiM3FqSNrhmu3/X+aZtxEaBA=; b=iElk4csfxBz6OpIieRxolF49YKhDntfOPDnx0hLGZ5mW6PjqHxcGz1UPWa/jAmD7A+Zbt4mbIB2OjrdXKrRwwNbmDB0TIH5gdW81yW6hSd/Yw8dQrufFj93rtalsA8bSxMEO1sKcwmQsd8os7ZCNoRice310ezpu8soERN8JkDW/KuyH+tArZkzhMoOY2MfthXnhIBg5+zy8nWH2c+1+XDX5pnyHhBzdA6YEXNGebK1jNBguT47Yhrm2I1baUZ+vuLzRVF19dhN87T37wQ/eJlKObpzhFiFbe1Tmhnb2uY0dbfw1JH1S12fj731jMCOa6xOwE2ziG0HkPoBY1uWGHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gvwd579G37b+X5nphcABiM3FqSNrhmu3/X+aZtxEaBA=; b=GdN6lFDdKPj09fyLPsX2LcLyAcJTv/6PxqCZ7MfcR0loP4d51LwXLcJu9x6ISd64a75jpR9+FD34rNxlSKCL3xMIvf8uztGEaH3CR8phuedPCCnM7dy18W3wPyqsXhVZKmp8fRb1QYrhXQMW9TdzQPYC+Cy6rRVd8WOQB/YZtIJJOF/UtdmgPN0ri2EQjzFOiXxbNQhZD+eR9Td68C2gTpPekKNCvefPg2i5AwJG6YEB3dHWsdcR67KC9QGU5q2h9Ga+WRAxGcBqpP0t0AEVTh+o2yCfBQFmHMsmvDOvqjOq0tQVP9/uBMBXZp2Hh8ZfiozeI1ReuLaD14TYVnU3Pw== Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB4044.namprd12.prod.outlook.com (2603:10b6:5:21d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Tue, 13 Apr 2021 15:46:15 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 15:46:15 +0000 From: Li Zhang To: Ferruh Yigit , "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , "cristian.dumitrescu@intel.com" , "lironh@marvell.com" , "jerinj@marvell.com" CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Raslan Darawsheh , Roni Bar Yanai Thread-Topic: [PATCH v4 0/4] Support PPS(packet per second) on meter Thread-Index: AQHXME9IyjHnh4csZUG0lgiFL3sv+6qyRXFAgAADxoCAAE4YUA== Date: Tue, 13 Apr 2021 15:46:15 +0000 Message-ID: References: <20210331085405.1445546-1-lizh@nvidia.com> <20210413035046.28578-1-lizh@nvidia.com> <1b88ae6e-addf-cfde-1179-d3f4a2506122@intel.com> In-Reply-To: <1b88ae6e-addf-cfde-1179-d3f4a2506122@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8de3f32-79eb-4837-1b33-08d8fe9345d7 x-ms-traffictypediagnostic: DM6PR12MB4044: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AIOkN/DvlW5PUAYm6Kw1IZ9zuiEXdISLO+4tsiBoztJxwKOMlganhTt52mvI9IaMe7Qhe5IVoOzNf3U/Nqp0q+pRWAZ5g3xEZwfglu8/fknIRdRsPMc55N8or3htNvxZTXJSOMPyPx7505d/zM62C53ONfj8OQ/kxbClhOe+hM94t1kVmDSboTRjaQLXYk1YLgJVQ+tGb6FcaznriD3d4yZZRD4PyIyTkRcLcXLVC8TRul/U8eZD84zU5CV9sUrqvDJj4Q33pJ137FubPiqYVnDF+PlYJwp+MVJq51INBZACqO61MHLzBsURGIo/6ezEMffs7nVJJfnOkBvrw/ycBfDIP1FOvl8SATSSGEY0X7wdY2oqMNJ8q3tYPEj36EzZAZD572Kw8CAhbP8Bvnm7cOqE7mm4KInPlxbPTaSGqLXnAY4BTEDzbPmHnLf9Kywp4nFKZC1iotWjBH1FkbuP4rkhnkIKMopSXsOUor2BI7V82JdXkFUX3xhLT1nC3uUgFCHVAPxTlR7XFzVdhML2WNCZ/tHPGG/P3ptVrLw/d0s81HSrCPXSgjGg/k5KJbHbf+A1NE+s6377gIoQ2ebTELvvB/vB2Rg9gQCArTSUerr/2VlR07/8wE4BigZnkdI3NwicT7UixXgBNIo281v/b8cYFoW2e9O9VLVI/HEKDcjRooUKKwcJ+Oo9yClHx/8p x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(33656002)(83380400001)(26005)(316002)(122000001)(478600001)(53546011)(66946007)(66556008)(71200400001)(54906003)(52536014)(7696005)(86362001)(8676002)(66446008)(55016002)(107886003)(186003)(76116006)(966005)(2906002)(8936002)(4326008)(9686003)(64756008)(110136005)(6506007)(38100700002)(66476007)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?fof+Q2i2aBJYB/VRWcGordbxh164zGg/tVpsrKtFbvU2cEIhC4RG4KxtbPeR?= =?us-ascii?Q?6i3bMhwP9avQSvbPo0Aqek7lUhAfmYZ8KbnjPsaaqZV+0hYH+BkY4xPVmOmW?= =?us-ascii?Q?DCPPwWjBLtYwM875HbjE6B/DMjIkgofryIKWTH3vStXqdQCBOIapy8F2BFpY?= =?us-ascii?Q?Fs4SD1v4NvetdGBcOOqJMdFCTsCnUbZfaNAFUcDjGaeaZZjZoROGL4J0mGAH?= =?us-ascii?Q?FtbeqN8wlbxk89nPM+CT+mOn/VukLFaVbI7Khkd5inANSRyy5/uq3VYe0rBr?= =?us-ascii?Q?kU3JnvXDVxFiSkXBxEyhgKLQ3QQQ+BQE23tssADcyKEyaQakCYE52qqvx9ws?= =?us-ascii?Q?L/RyKGBAwAXyfEuVkL1o0FP/cVs7JqMiGUAUeEP6w8GnMOLQMLqKo7ZegHpg?= =?us-ascii?Q?hVYCbH3wcARomFBp6AZ6omswkapZWeTqSK992fN+v8DfZwcAIzqg2U0DOYjT?= =?us-ascii?Q?AUMHXLIerUb3c7g5DXk02cWkExRZIcFZ5SzOlqRsPOyif3Gco9hgBxTXVsAI?= =?us-ascii?Q?xII2W26XXYYPhiHo4x3mdRYP+Hq1UIOROGyKX9R40GthgjsBPV9yJV5L3OFd?= =?us-ascii?Q?OZItGN8ZS0frY/j1MyFnQCnQBjl8RY/nRVoKBZfwrKgbX+xYEFoiVrWByZb3?= =?us-ascii?Q?IS0PN3N29ncfKttDr6UEYdUOvFZl7F5YE1HxNdB3aetW00LvdiN9ytdO244F?= =?us-ascii?Q?lza7W2WwqpsTXjJGiKpnfIbVRfFTxuPvlyo1q+9pnuwyhLsRKOF68MEGoLt3?= =?us-ascii?Q?HaGmbBcuktUsEAJ/BISADfeFhP2zkeX15OJ1OurojTAUs8rdZfE1YRfw4ERf?= =?us-ascii?Q?VoPZOnn19ZdJO5RHOYar5MNPFIpjRIHfCX4BuL6jm47755Oh3Z4rrYjLZEsm?= =?us-ascii?Q?h4Adb4LHKz/RNCMzq7XAGj3UuixTV4dmpkuY3Fz0U632mo+RgXhc1CSpLZTb?= =?us-ascii?Q?Vv/ThjbtldtPQJOZ2ntuPaXb8gV1/O5P/QppAW7EW2WW1xaFe2eJAOoqU0RE?= =?us-ascii?Q?QMenEQdE8rcjUudOoEXaDY5z9PcROlSEbsZuH2k0hyj3uBbXjbfw7TTNDLkz?= =?us-ascii?Q?Dt/nOfVArvSx7xYOQ3w1hja0EHDt6yryhybxVKmUPl3HQVI2WiKu4BipqPTC?= =?us-ascii?Q?3YnC7vdccMPT8nIWTXMGf3d9ughIJOtCUu5LYJBusXSh8+x92rQM819cTfOL?= =?us-ascii?Q?asoIoIxTFFa5g/SFB6s66TLVDeCiCNGzBGe1LkqEtQHKlGqAjC9x3n34zLJ7?= =?us-ascii?Q?Jo0XZ3rfptw8QZN+LRIDdxAyn0H/27lRHSVwDHLkf2VQ+6KvQoAt927ZASgV?= =?us-ascii?Q?W2mEeYOt855td3bPCWjEhAEN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8de3f32-79eb-4837-1b33-08d8fe9345d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 15:46:15.6814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dKKKT4iEjGoYJZE9MwV7PAezjSCz2bKzSfp8VNF72IgCn59o9LO6d6uQp6F/ZyPb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4044 Subject: Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 7:06 PM > To: Li Zhang ; dekelp@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > cristian.dumitrescu@intel.com; lironh@marvell.com; jerinj@marvell.com > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > Raslan Darawsheh ; Roni Bar Yanai > > Subject: Re: [PATCH v4 0/4] Support PPS(packet per second) on meter >=20 > External email: Use caution opening links or attachments >=20 >=20 > On 4/13/2021 12:02 PM, Li Zhang wrote: > > Hi Ferruh, > > > >> -----Original Message----- > >> From: Ferruh Yigit > >> Sent: Tuesday, April 13, 2021 6:25 PM > >> To: Li Zhang ; dekelp@nvidia.com; Ori Kam > >> ; Slava Ovsiienko ; Matan > >> Azrad ; Shahaf Shuler ; > >> cristian.dumitrescu@intel.com; lironh@marvell.com; jerinj@marvell.com > >> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; > >> Raslan Darawsheh ; Roni Bar Yanai > >> > >> Subject: Re: [PATCH v4 0/4] Support PPS(packet per second) on meter > >> > >> External email: Use caution opening links or attachments > >> > >> > >> On 4/13/2021 4:50 AM, Li Zhang wrote: > >>> Currently meter algorithms only supports rate is bytes per second(BPS= ). > >>> Add packet_mode flag in meter profile parameters data structure. > >>> So that it can meter traffic by packet per second. > >>> > >>> When packet_mode is 0, the profile rates and bucket sizes are > >>> specified in bytes per second and bytes when packet_mode is not 0, > >>> the profile rates and bucket sizes are specified in packets and > >>> packets per second. > >>> > >>> Add the necessary checks to the existing drivers implementing the > >>> rte_mtr API to makes sure that profiles with packet_mode set to TRUE > >>> are rejected. > >>> > >>> RFC ("adds support PPS(packet per second) on meter") > >>> > https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769 > >>> - > >> 2 > >>> -lizh@nvidia.com/ > >>> > >>> Depends-on: series=3D16301 ("Support meter policy API ") > >>> https://patchwork.dpdk.org/project/dpdk/list/?series=3D16301 > >>> > >> > >> Hi Li, > >> > >> I am not clear with the dependency chain, can you please clarify, > >> > >> 1) Is this set depends to series-16301? Because it compiles fine > >> after conflict resolved, I can see in your repo there is an order, > >> but if there is no functional/logical dependency you can set this > >> patch exactly on top of HEAD (removing the series-16301 in between), s= o > the CI will be enabled. > > > > I will delete series-16301. > > But it will merge conflict when series-16301 merged after it. > > >=20 > Please send both this patch, and series-16301 on top of latest head, this > enables CI for both. >=20 > When merging them we can handle the conflict, based on which one merged > first, or can ask you to rebase the second one but for this case it does = not look > too complex to resolve ourselves. >=20 Got it and will sent it on V5 patch. > >> 2) According its cover letter series-16301 depends on mlx ASO patch, > >> this makes all ethdev patches dependent to mlx5 set, I guess that is > >> wrong, can you please confirm? > >> > >> Above (1) is more important, since series-16301 not fully acked, it > >> is blocking me to proceed. > >> > >>> V2: create a unified patch that contains both the series with > >>> the API changes and the series with the necessary error > >>> checks in the > >> drivers. > >>> V3: Fix comments about commit-log. > >>> V4: Fix comments about Depends-on and rebase. > >>> > >>> Li Zhang (4): > >>> ethdev: add packet mode in meter profile structure > >>> app/testpmd: add meter profile packet mode option > >>> net/softnic: check meter packet mode > >>> net/mvpp2: check meter packet mode > >>> > >>> app/test-pmd/cmdline_mtr.c | 40 ++++++++- > >>> doc/guides/rel_notes/release_21_05.rst | 12 +++ > >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++---- > >>> drivers/net/mvpp2/mrvl_mtr.c | 6 ++ > >>> drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++ > >>> lib/librte_ethdev/rte_mtr.h | 90 +++++++++++++++++= +--- > >>> 6 files changed, 159 insertions(+), 28 deletions(-) > >>> > >