From: Manish Chopra <manishc@marvell.com>
To: Benjamin Poirier <bpoirier@suse.com>
Cc: GR-Linux-NIC-Dev <GR-Linux-NIC-Dev@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next 01/16] qlge: Remove irq_cnt
Date: Wed, 26 Jun 2019 13:21:52 +0000 [thread overview]
Message-ID: <DM6PR18MB2697291D4195683CC42EA194ABE20@DM6PR18MB2697.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190626113619.GA27420@f1>
> In msix mode there's no need to explicitly disable completion interrupts, they
> are reliably auto-masked, according to my observations.
> I tested this on two QLE8142 adapters.
>
> Do you have reason to believe this might not always be the case?
How did you check auto-masking of MSI-X interrupts ?
I was just wondering about the below comment in ql_disable_completion_interrupt(), where for MSI-X it does disable completion intr for zeroth intr.
Seems special case for zeroth intr in MSI-X particular to this device.
/* HW disables for us if we're MSIX multi interrupts and
* it's not the default (zeroeth) interrupt.
*/
if (likely(test_bit(QL_MSIX_ENABLED, &qdev->flags) && intr))
return 0;
next prev parent reply other threads:[~2019-06-26 13:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 7:48 [PATCH net-next 01/16] qlge: Remove irq_cnt Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 02/16] qlge: Remove page_chunk.last_flag Benjamin Poirier
2019-06-26 9:12 ` Manish Chopra
2019-06-17 7:48 ` [PATCH net-next 03/16] qlge: Deduplicate lbq_buf_size Benjamin Poirier
2019-06-26 9:24 ` [EXT] " Manish Chopra
2019-06-26 11:37 ` Benjamin Poirier
2019-06-26 15:42 ` Willem de Bruijn
2019-06-28 8:57 ` Benjamin Poirier
2019-06-28 14:56 ` Willem de Bruijn
2019-06-17 7:48 ` [PATCH net-next 04/16] qlge: Remove bq_desc.maplen Benjamin Poirier
2019-06-26 9:31 ` Manish Chopra
2019-06-17 7:48 ` [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size Benjamin Poirier
2019-06-26 9:36 ` [EXT] " Manish Chopra
2019-06-26 11:39 ` Benjamin Poirier
2019-06-26 15:35 ` Willem de Bruijn
2019-06-17 7:48 ` [PATCH net-next 06/16] qlge: Remove useless dma synchronization calls Benjamin Poirier
2019-06-17 9:44 ` [EXT] " Manish Chopra
2019-06-18 2:51 ` Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 07/16] qlge: Deduplicate rx buffer queue management Benjamin Poirier
2019-06-27 10:02 ` [EXT] " Manish Chopra
2019-07-09 2:10 ` Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 08/16] qlge: Fix dma_sync_single calls Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 09/16] qlge: Remove rx_ring.type Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 10/16] qlge: Factor out duplicated expression Benjamin Poirier
2019-06-23 17:59 ` David Miller
2019-06-23 18:00 ` David Miller
2019-06-24 7:52 ` Benjamin Poirier
2019-06-25 18:32 ` Manish Chopra
2019-06-28 8:52 ` Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 11/16] qlge: Remove qlge_bq.len & size Benjamin Poirier
2019-06-27 10:47 ` Manish Chopra
2019-07-09 6:52 ` Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 12/16] qlge: Remove useless memset Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 13/16] qlge: Replace memset with assignment Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 14/16] qlge: Update buffer queue prod index despite oom Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 15/16] qlge: Refill rx buffers up to multiple of 16 Benjamin Poirier
2019-06-17 7:48 ` [PATCH net-next 16/16] qlge: Refill empty buffer queues from wq Benjamin Poirier
2019-06-27 14:18 ` [EXT] " Manish Chopra
2019-07-10 1:18 ` Benjamin Poirier
2019-06-17 16:49 ` [PATCH net-next 01/16] qlge: Remove irq_cnt Manish Chopra
2019-06-26 8:59 ` Manish Chopra
2019-06-26 11:36 ` Benjamin Poirier
2019-06-26 13:21 ` Manish Chopra [this message]
2019-07-05 8:33 ` Benjamin Poirier
2019-07-15 1:40 ` Benjamin Poirier
2019-07-15 9:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR18MB2697291D4195683CC42EA194ABE20@DM6PR18MB2697.namprd18.prod.outlook.com \
--to=manishc@marvell.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=bpoirier@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.