From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE827C433EF for ; Tue, 14 Sep 2021 08:07:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 684046103B for ; Tue, 14 Sep 2021 08:07:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 684046103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wFK7WpqQ/v0th/TT/Ju0urwIliMF7XctPpoMd+MkqZ0=; b=30Od+ZVvaEBFKF GcOJDQuC0CQVQBe+VnYtBEWadQayg5y4sYxF8JxEhWM8Q1zCY8C9qS4mHYZm6zkN/RmsfKn2hST8h e9np5qyx8QrLNBoH2cKNe4N9R1J32nVabK4pGQirt10nJSF8bav2PP3zUkJMemk0ofe0im9dl1svM aBuubsFNKpfFyjzfQmiiFxazl7l/an/qfnAkK/SN8zTkrk1K/2PjvHSF1ROs+R3r9sF+0d3Manix+ r3vnP4hqQ2l9j/9PnqdRMWwt6VaaFXePCt/m/muR0gFrWnkIADF0lCw+9aJPiuqEDt1mVgFfbXI8n 62ShS0HosYpFg1JyAaGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ3TT-004cqe-9O; Tue, 14 Sep 2021 08:07:27 +0000 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174] helo=mx0b-0016f401.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ3TP-004coa-RX for linux-nvme@lists.infradead.org; Tue, 14 Sep 2021 08:07:25 +0000 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18E5pYrE004455; Tue, 14 Sep 2021 01:07:05 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-0016f401.pphosted.com with ESMTP id 3b2ny3gfgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 01:07:05 -0700 Received: from m0045849.ppops.net (m0045849.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18E84JP0018271; Tue, 14 Sep 2021 01:07:04 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0a-0016f401.pphosted.com with ESMTP id 3b2ny3gfgq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 01:07:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEdYvlQPG3ZBW7Zf1ckhAhLa63Wy3UrmWfx7npyE9Vly+h9pFnk+74DTCzi2rVU8kGkidb5uoACwBE0td2xeFKobrK4qR/pDqfQH7BqquvdbFlXVxElxPtOUDo84B4cZCeTpydSpRFEFRFCtPFRzfI4NKzaLpGadbymcMEJWUET/tmww5L0QWhXqBsmPr2Z4AsuCYZoZduHPHYDCPN2V1UmWaiC3RPoYYNUyA0E5YW322XNVoeIvfGtkkXvLKluVwKnUWOrOMSQOFDuGPN+1X/MmI3Achhlv5uJscad/PZrx4b+HVFJGJrALHFRegXUUTkCHGK9jonKsfwoRCrj5Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+bJWdgiySW9nJM5XnjciuAXCU6Ev801urERDAl0nDwk=; b=Wcqc75FuagtIT6W4+MTTlQ98HVvDzOhuXZQ/X59OkPttSpBFig86QkYfGBPChr+LOQsPTDIwQQuUEfuT2ugOnICa/L+fLSqs8XqC5r9bs6VTAofAk2mQNy7mviR0coHOWmrAjbiAsy1eGBkOSv0o0JROLDEGFFNLo0quHzmnUi06Kwkpu6pKgmS8H27H+5X4T3Q0s5ZuncSIvwvx2vl5UR23AF/GRrK33wFBPAX15hJrRA1ZkLkoK17ZEbhNa3+K+imSBh3gtisChMRC1s/Pe+NYYSsrbX+5rEE0+ucHrUjjEA8oAnWrLwKhBb0y7PmRg3TjJ+xbHsqV2twTws54Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bJWdgiySW9nJM5XnjciuAXCU6Ev801urERDAl0nDwk=; b=t9TXJBD25EXvRHWECYt23WArcwykGaZlBJ0BlphbAxCY0Y7NJq0DW7rlJAXJfmtRjovFK/Ztz1RhIpBjbxzVA0kBiWBE3PduqzDvH01DFjUrqjvQ5xuIEo2ID/FJGXDuRGVuYFBIV4vKaAiQ2mX+KVK0Ubr+vQvukVYMdPCr15Q= Received: from DM6PR18MB3034.namprd18.prod.outlook.com (2603:10b6:5:18c::32) by DM5PR18MB0988.namprd18.prod.outlook.com (2603:10b6:3:29::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Tue, 14 Sep 2021 08:07:02 +0000 Received: from DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::f1e4:800f:dec0:61d3]) by DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::f1e4:800f:dec0:61d3%6]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 08:07:02 +0000 From: Saurav Kashyap To: Ming Lei , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "hch@lst.de" CC: Nilesh Javali , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , GR-QLogic-Storage-Upstream , "james.smart@broadcom.com" , "axboe@fb.com" , "kbusch@kernel.org" Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Topic: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Index: AQHXmB5nQhsPGOkOI0qGifl5VUdIxquBVlsAgACqKsCAAAR/AIABpizwgBS26kCACujCgA== Date: Tue, 14 Sep 2021 08:07:02 +0000 Message-ID: References: <20210823125649.16061-1-njavali@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c00dde4-8ba0-42e0-fade-08d97756a295 x-ms-traffictypediagnostic: DM5PR18MB0988: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UCP+LKWMo5cyL3tl70m/P4SogLD7fDZBnJF4mKFvV48Ner8CXhUK0db9ek/Rl6a+jdvBpw42iJofh6fNAA63CCuZQv1z4ndzporX36TJCR/I5N1uoEl/yxQ8TA3pD8V53Z+YyLrNEKi6Jik/e62U36pbaAuLafoXgo/pW5heo+8e+8KxzLljsEAi/EjbuiCEPLsjF8v2Q5lTh5vq3oDt8SMbUPorNKTGzQiP1w/aRBBZXMwRda1eA/6NAVb023aUk0qeeCqBIIWNkMxV7FFcE8lll0zj7RvBro3lUqUCEBu904e4gJab5IJNdXzmIuCYW1FdMM/I4m9NxOIii/CVTeopjMhQfOrA3Aot4kvn8QmTB8/anWk8jDPlqvWND0wXqbbPfoYJCsLehXCVq7uvaa8n9Gm4hmtGlAyyfS2gn+uwHNR2AUapOaVSbzMujG9DM+0Crpl8xAivVDUtv+BgNlSgXNloOZEN8pmsVAuhx5mp8RZXBZJOEzXdVf0Jwjmm5Tii9OAIpRFKFsO5yRnWUYktc5SSTLjfxHZX2H167txlguF/E18QyEyVRfTrO+1+q9VGQRL4Ig8AKvdDGJ+u3XtBOdhn9QMQVFED/cUGkrNmRPmcHl9KekaXtd8mM0eIR1lMYreo6cK3SeS37L8lWK1V61sf+w1It0B/YQFJBdTfiK4/KUQlKFwz/VX9T08/h0vDzjLG1ROZQPfZhOy4C4HVbfx640rEs0FfPVV9yviKCU3do4lGCMTr/TizwoQYu+0gIveX/Byh9lb1xiPv5uHk8LTR30axeKkcmUkRr8M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR18MB3034.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(8936002)(52536014)(478600001)(186003)(19627235002)(83380400001)(38100700002)(122000001)(71200400001)(66446008)(7696005)(38070700005)(5660300002)(55016002)(6506007)(8676002)(966005)(110136005)(54906003)(2906002)(4326008)(86362001)(53546011)(66476007)(66556008)(64756008)(66946007)(9686003)(76116006)(316002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B1hoo0gzhJatDo0F49NoI5tsgnGTqJMMovmFGGDcH4svDNnXGI5HzeUGWK/E?= =?us-ascii?Q?DTRjvChLWvd5qJ2p7mbJ+DcNPwkYzU/oPP5T7dBhDLxauy+ZAQvsEoDRmiBL?= =?us-ascii?Q?9cmgCMMGDevSIHYqzQJT4FwrzzD2NngxoGRzMqqY9TVOYRew+TKBzLNtMTUD?= =?us-ascii?Q?/R+k68MLIIyifhkbW8FdiQWdAxE2G9iGDwz+g/csqySIiDZ9NEDG/ChD3dJy?= =?us-ascii?Q?MGa83JASlNHSYzMPM92xXaXcncqZIUZJ+y/8LjigPvYSkbUHaVL8vMdjnVya?= =?us-ascii?Q?izkb1e0MqwbSjVh/jfcIat8dKdeYOEJu/pcx3hCCZ8rvyTlK1n9naa/qdX9k?= =?us-ascii?Q?qggNVHnmukSBUoKVTOV/KyBNGMjJXPxtEMgjdep6pAhlTnJ6w67U4DAE06oe?= =?us-ascii?Q?geDbfl+8M2HW1a3Z7sCmhEeNCXMEgqyf7AgArLyV9PVV98ZHAqH1JGT4o++D?= =?us-ascii?Q?AoOwt3IFotUEezEqFXD7T9+WW1/rzct1bD6lcdj2/q4Hhxjo6Y3kOiAS4P5+?= =?us-ascii?Q?TjhtlfyVGaoS/qqbhJEY7MzhZEDTXZqNQCNRtbjZ/B8fSaeEe6Pj50i8SN8D?= =?us-ascii?Q?k3qQVtu/tvIeEYL5BF1wCfGTzB0hHlmVpou0V5ojTbOwIPO+/EH8C7wmb6V8?= =?us-ascii?Q?Zv6IqXtyK8yxlf6vWn8iFQ6KfcxSCa0s//p/rK6pUgV43UFhoTXBGCIDT8Og?= =?us-ascii?Q?LpTymES61NZbGK4jGBMp2JcJK0i1ES3l8isQH4JTTFUsm0YtGE7Q+eBEsYQn?= =?us-ascii?Q?zM1EFLOeClR7FtUDHC/kDegYHyikqIgO16sWX+iqmv0V1Ag5OzHp+HryWaQ7?= =?us-ascii?Q?GhaDgEaZSoYIrAHDfqZnUvbmlLItxFHGGRT4WlaMxTZYAGZHJ6NZod0H6URr?= =?us-ascii?Q?wbUb21wIos0gIt5hHeYC0YVgQTugwQKGo07NNfokz+mXL/Jdr1ukna2w3Il2?= =?us-ascii?Q?73C64/na7OTE3HOID5O5R6I2rZ/exYe/dFUI6Q8yH1Wvvde0pKaixflkdhJW?= =?us-ascii?Q?rxIpKlbDvIeiJgJES5QnDKftFxbW0YJ8ydAw4CxokhcVIvX45ssuu4wRePwc?= =?us-ascii?Q?lxlZ7DBcgHNPJR/WDNGSrPRYExdKgbk4gEro/loKGEpYqxbs74obsscGWcr/?= =?us-ascii?Q?NSTzL07+47RiRDxc/1Hsujop+nsKSl24SHOS+Uo2pUKxCBNrZSA7Knv92IAJ?= =?us-ascii?Q?TMxrQiBcIcnY3P6mF4ePihSALVlq3b+kgyjPfLhXR4muueOpRxKbFK7/5rhU?= =?us-ascii?Q?vGcAF03jIAdUysAwivnLWt1wUMoa3EGvKZdgnbyAKjY6A7X13rcr1bt6CTxV?= =?us-ascii?Q?e6OMwpHLrc7iKKTCJplFrYO6YA38IOo2+OMJwyijaeeBJl2JaEh3r7VN5tfM?= =?us-ascii?Q?P7uvOD73RJrJTfIAf+cQsMvgo2wV?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c00dde4-8ba0-42e0-fade-08d97756a295 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 08:07:02.6977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MjSbcE1yo4HmFoKD+U5x8c+NKHzDVKaEuSYYZfOMbzVepw5UcinBI1PByf4x9jYbQTsxPyfeAbvLHTj/ejHUMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB0988 X-Proofpoint-ORIG-GUID: LGG-Mk7Nc6-UELx0s0pTU8h0hVSFlMzh X-Proofpoint-GUID: agU6KousxLf9zlXeLHYK6FDzJqKBto62 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-14_02,2021-09-09_01,2020-04-07_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_010724_048677_B2BFB1E0 X-CRM114-Status: GOOD ( 30.75 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi Sagi/Christoph, I haven't heard anything on this and there are no review comments on this patch set, kindly include this in nvme tree. Thanks, ~Saurav > -----Original Message----- > From: Saurav Kashyap > Sent: Tuesday, September 7, 2021 2:48 PM > To: Ming Lei ; Sagi Grimberg ; > linux-nvme@lists.infradead.org > Cc: Nilesh Javali ; martin.petersen@oracle.com; linux- > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream Upstream@marvell.com> > Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > Hi, > > Can I get a review for this patch set? > > Thanks, > ~Saurav > > > -----Original Message----- > > From: Saurav Kashyap > > Sent: Wednesday, August 25, 2021 10:29 AM > > To: Ming Lei > > Cc: Sagi Grimberg ; Nilesh Javali ; > > martin.petersen@oracle.com; linux-nvme@lists.infradead.org; linux- > > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > Upstream@marvell.com> > > Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > Hi Ming, > > Comments inline > > > > > -----Original Message----- > > > From: Ming Lei > > > Sent: Tuesday, August 24, 2021 9:17 AM > > > To: Saurav Kashyap > > > Cc: Sagi Grimberg ; Nilesh Javali > ; > > > martin.petersen@oracle.com; linux-nvme@lists.infradead.org; linux- > > > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > > Upstream@marvell.com> > > > Subject: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > External Email > > > > > > ---------------------------------------------------------------------- > > > On Tue, Aug 24, 2021 at 03:38:24AM +0000, Saurav Kashyap wrote: > > > > Hi Sagi, > > > > Comments inline > > > > > > > > > -----Original Message----- > > > > > From: Sagi Grimberg > > > > > Sent: Monday, August 23, 2021 10:51 PM > > > > > To: Nilesh Javali ; martin.petersen@oracle.com; > > > linux- > > > > > nvme@lists.infradead.org; Ming Lei > > > > > Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream QLogic- > > > > > Storage-Upstream@marvell.com> > > > > > Subject: Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > > > > > > > > > > On 8/23/21 5:56 AM, Nilesh Javali wrote: > > > > > > Currently nvme fc doesn't support map queue functionality. This patch > > > > > > set adds map_queue functionality to nvme_fc_mq_ops and > > > > > > nvme_fc_port_template, providing an option to LLDs to map queues > > > > > > similar to SCSI. For qla2xxx, minimum 10% improvement is noticed > > > > > > with this change as it helps in reducing cpu thrashing. > > > > > > > > > > Does this make nvme-fc use managed irq? > > > > > > > > qla2xxx driver uses pci_alloc_irq_vectors_affinity to have affinity with > each > > > MSI-X vector. Currently nvme queue are not mapped based on affinity and > irq > > > offset. The change is to use blk_mq_pci_map_queues for mapping, this > > function > > > consider irq affinity as well as irq offset. > > > > > > > > > > OK, got it. Even though without this patchset, nvme-fc actually relies > > > on managed irq since qla2xxx driver uses pci_alloc_irq_vectors_affinity. > > > > > > Now the patchset[1] isn't good for addressing the issue in > > > blk_mq_alloc_request_hctx(). > > > > Can you please elaborate on this? Is there something needs to be done from > my > > side? > > > > Thanks, > > ~Saurav > > > > > > [1] https://urldefense.proofpoint.com/v2/url?u=https- > > > 3A__lore.kernel.org_linux-2Dblock_YR7demOSG6MKFVAF-40T590_T_- > > > > > > 23t&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=ZHZbmY_LbM3DUZK_BDO1 > > > OITP3ot_Vkb_5w- > > > > > > gas5TBMQ&m=CqFDnfAsZphubKXkUx5gsRF6RZ2Qe6sxWkYq4pBfFD0&s=2Nba > > > EUI5eB6_R6PxW8ld1Xn2OU3_UdD6D30uvFAWhow&e= > > > > > > > > > Thanks, > > > Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB14CC433EF for ; Tue, 14 Sep 2021 08:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B29D1610A2 for ; Tue, 14 Sep 2021 08:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231454AbhINIKN (ORCPT ); Tue, 14 Sep 2021 04:10:13 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:12054 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230477AbhINIIy (ORCPT ); Tue, 14 Sep 2021 04:08:54 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18E5pYrE004455; Tue, 14 Sep 2021 01:07:05 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-0016f401.pphosted.com with ESMTP id 3b2ny3gfgw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 01:07:05 -0700 Received: from m0045849.ppops.net (m0045849.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18E84JP0018271; Tue, 14 Sep 2021 01:07:04 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0a-0016f401.pphosted.com with ESMTP id 3b2ny3gfgq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 01:07:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEdYvlQPG3ZBW7Zf1ckhAhLa63Wy3UrmWfx7npyE9Vly+h9pFnk+74DTCzi2rVU8kGkidb5uoACwBE0td2xeFKobrK4qR/pDqfQH7BqquvdbFlXVxElxPtOUDo84B4cZCeTpydSpRFEFRFCtPFRzfI4NKzaLpGadbymcMEJWUET/tmww5L0QWhXqBsmPr2Z4AsuCYZoZduHPHYDCPN2V1UmWaiC3RPoYYNUyA0E5YW322XNVoeIvfGtkkXvLKluVwKnUWOrOMSQOFDuGPN+1X/MmI3Achhlv5uJscad/PZrx4b+HVFJGJrALHFRegXUUTkCHGK9jonKsfwoRCrj5Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+bJWdgiySW9nJM5XnjciuAXCU6Ev801urERDAl0nDwk=; b=Wcqc75FuagtIT6W4+MTTlQ98HVvDzOhuXZQ/X59OkPttSpBFig86QkYfGBPChr+LOQsPTDIwQQuUEfuT2ugOnICa/L+fLSqs8XqC5r9bs6VTAofAk2mQNy7mviR0coHOWmrAjbiAsy1eGBkOSv0o0JROLDEGFFNLo0quHzmnUi06Kwkpu6pKgmS8H27H+5X4T3Q0s5ZuncSIvwvx2vl5UR23AF/GRrK33wFBPAX15hJrRA1ZkLkoK17ZEbhNa3+K+imSBh3gtisChMRC1s/Pe+NYYSsrbX+5rEE0+ucHrUjjEA8oAnWrLwKhBb0y7PmRg3TjJ+xbHsqV2twTws54Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+bJWdgiySW9nJM5XnjciuAXCU6Ev801urERDAl0nDwk=; b=t9TXJBD25EXvRHWECYt23WArcwykGaZlBJ0BlphbAxCY0Y7NJq0DW7rlJAXJfmtRjovFK/Ztz1RhIpBjbxzVA0kBiWBE3PduqzDvH01DFjUrqjvQ5xuIEo2ID/FJGXDuRGVuYFBIV4vKaAiQ2mX+KVK0Ubr+vQvukVYMdPCr15Q= Received: from DM6PR18MB3034.namprd18.prod.outlook.com (2603:10b6:5:18c::32) by DM5PR18MB0988.namprd18.prod.outlook.com (2603:10b6:3:29::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Tue, 14 Sep 2021 08:07:02 +0000 Received: from DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::f1e4:800f:dec0:61d3]) by DM6PR18MB3034.namprd18.prod.outlook.com ([fe80::f1e4:800f:dec0:61d3%6]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 08:07:02 +0000 From: Saurav Kashyap To: Ming Lei , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "hch@lst.de" CC: Nilesh Javali , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , GR-QLogic-Storage-Upstream , "james.smart@broadcom.com" , "axboe@fb.com" , "kbusch@kernel.org" Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Topic: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support Thread-Index: AQHXmB5nQhsPGOkOI0qGifl5VUdIxquBVlsAgACqKsCAAAR/AIABpizwgBS26kCACujCgA== Date: Tue, 14 Sep 2021 08:07:02 +0000 Message-ID: References: <20210823125649.16061-1-njavali@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c00dde4-8ba0-42e0-fade-08d97756a295 x-ms-traffictypediagnostic: DM5PR18MB0988: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UCP+LKWMo5cyL3tl70m/P4SogLD7fDZBnJF4mKFvV48Ner8CXhUK0db9ek/Rl6a+jdvBpw42iJofh6fNAA63CCuZQv1z4ndzporX36TJCR/I5N1uoEl/yxQ8TA3pD8V53Z+YyLrNEKi6Jik/e62U36pbaAuLafoXgo/pW5heo+8e+8KxzLljsEAi/EjbuiCEPLsjF8v2Q5lTh5vq3oDt8SMbUPorNKTGzQiP1w/aRBBZXMwRda1eA/6NAVb023aUk0qeeCqBIIWNkMxV7FFcE8lll0zj7RvBro3lUqUCEBu904e4gJab5IJNdXzmIuCYW1FdMM/I4m9NxOIii/CVTeopjMhQfOrA3Aot4kvn8QmTB8/anWk8jDPlqvWND0wXqbbPfoYJCsLehXCVq7uvaa8n9Gm4hmtGlAyyfS2gn+uwHNR2AUapOaVSbzMujG9DM+0Crpl8xAivVDUtv+BgNlSgXNloOZEN8pmsVAuhx5mp8RZXBZJOEzXdVf0Jwjmm5Tii9OAIpRFKFsO5yRnWUYktc5SSTLjfxHZX2H167txlguF/E18QyEyVRfTrO+1+q9VGQRL4Ig8AKvdDGJ+u3XtBOdhn9QMQVFED/cUGkrNmRPmcHl9KekaXtd8mM0eIR1lMYreo6cK3SeS37L8lWK1V61sf+w1It0B/YQFJBdTfiK4/KUQlKFwz/VX9T08/h0vDzjLG1ROZQPfZhOy4C4HVbfx640rEs0FfPVV9yviKCU3do4lGCMTr/TizwoQYu+0gIveX/Byh9lb1xiPv5uHk8LTR30axeKkcmUkRr8M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR18MB3034.namprd18.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(8936002)(52536014)(478600001)(186003)(19627235002)(83380400001)(38100700002)(122000001)(71200400001)(66446008)(7696005)(38070700005)(5660300002)(55016002)(6506007)(8676002)(966005)(110136005)(54906003)(2906002)(4326008)(86362001)(53546011)(66476007)(66556008)(64756008)(66946007)(9686003)(76116006)(316002)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B1hoo0gzhJatDo0F49NoI5tsgnGTqJMMovmFGGDcH4svDNnXGI5HzeUGWK/E?= =?us-ascii?Q?DTRjvChLWvd5qJ2p7mbJ+DcNPwkYzU/oPP5T7dBhDLxauy+ZAQvsEoDRmiBL?= =?us-ascii?Q?9cmgCMMGDevSIHYqzQJT4FwrzzD2NngxoGRzMqqY9TVOYRew+TKBzLNtMTUD?= =?us-ascii?Q?/R+k68MLIIyifhkbW8FdiQWdAxE2G9iGDwz+g/csqySIiDZ9NEDG/ChD3dJy?= =?us-ascii?Q?MGa83JASlNHSYzMPM92xXaXcncqZIUZJ+y/8LjigPvYSkbUHaVL8vMdjnVya?= =?us-ascii?Q?izkb1e0MqwbSjVh/jfcIat8dKdeYOEJu/pcx3hCCZ8rvyTlK1n9naa/qdX9k?= =?us-ascii?Q?qggNVHnmukSBUoKVTOV/KyBNGMjJXPxtEMgjdep6pAhlTnJ6w67U4DAE06oe?= =?us-ascii?Q?geDbfl+8M2HW1a3Z7sCmhEeNCXMEgqyf7AgArLyV9PVV98ZHAqH1JGT4o++D?= =?us-ascii?Q?AoOwt3IFotUEezEqFXD7T9+WW1/rzct1bD6lcdj2/q4Hhxjo6Y3kOiAS4P5+?= =?us-ascii?Q?TjhtlfyVGaoS/qqbhJEY7MzhZEDTXZqNQCNRtbjZ/B8fSaeEe6Pj50i8SN8D?= =?us-ascii?Q?k3qQVtu/tvIeEYL5BF1wCfGTzB0hHlmVpou0V5ojTbOwIPO+/EH8C7wmb6V8?= =?us-ascii?Q?Zv6IqXtyK8yxlf6vWn8iFQ6KfcxSCa0s//p/rK6pUgV43UFhoTXBGCIDT8Og?= =?us-ascii?Q?LpTymES61NZbGK4jGBMp2JcJK0i1ES3l8isQH4JTTFUsm0YtGE7Q+eBEsYQn?= =?us-ascii?Q?zM1EFLOeClR7FtUDHC/kDegYHyikqIgO16sWX+iqmv0V1Ag5OzHp+HryWaQ7?= =?us-ascii?Q?GhaDgEaZSoYIrAHDfqZnUvbmlLItxFHGGRT4WlaMxTZYAGZHJ6NZod0H6URr?= =?us-ascii?Q?wbUb21wIos0gIt5hHeYC0YVgQTugwQKGo07NNfokz+mXL/Jdr1ukna2w3Il2?= =?us-ascii?Q?73C64/na7OTE3HOID5O5R6I2rZ/exYe/dFUI6Q8yH1Wvvde0pKaixflkdhJW?= =?us-ascii?Q?rxIpKlbDvIeiJgJES5QnDKftFxbW0YJ8ydAw4CxokhcVIvX45ssuu4wRePwc?= =?us-ascii?Q?lxlZ7DBcgHNPJR/WDNGSrPRYExdKgbk4gEro/loKGEpYqxbs74obsscGWcr/?= =?us-ascii?Q?NSTzL07+47RiRDxc/1Hsujop+nsKSl24SHOS+Uo2pUKxCBNrZSA7Knv92IAJ?= =?us-ascii?Q?TMxrQiBcIcnY3P6mF4ePihSALVlq3b+kgyjPfLhXR4muueOpRxKbFK7/5rhU?= =?us-ascii?Q?vGcAF03jIAdUysAwivnLWt1wUMoa3EGvKZdgnbyAKjY6A7X13rcr1bt6CTxV?= =?us-ascii?Q?e6OMwpHLrc7iKKTCJplFrYO6YA38IOo2+OMJwyijaeeBJl2JaEh3r7VN5tfM?= =?us-ascii?Q?P7uvOD73RJrJTfIAf+cQsMvgo2wV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB3034.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c00dde4-8ba0-42e0-fade-08d97756a295 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 08:07:02.6977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MjSbcE1yo4HmFoKD+U5x8c+NKHzDVKaEuSYYZfOMbzVepw5UcinBI1PByf4x9jYbQTsxPyfeAbvLHTj/ejHUMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB0988 X-Proofpoint-ORIG-GUID: LGG-Mk7Nc6-UELx0s0pTU8h0hVSFlMzh X-Proofpoint-GUID: agU6KousxLf9zlXeLHYK6FDzJqKBto62 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-14_02,2021-09-09_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Sagi/Christoph, I haven't heard anything on this and there are no review comments on this p= atch set, kindly include this in nvme tree. Thanks, ~Saurav > -----Original Message----- > From: Saurav Kashyap > Sent: Tuesday, September 7, 2021 2:48 PM > To: Ming Lei ; Sagi Grimberg ; > linux-nvme@lists.infradead.org > Cc: Nilesh Javali ; martin.petersen@oracle.com; linu= x- > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream Upstream@marvell.com> > Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support >=20 > Hi, >=20 > Can I get a review for this patch set? >=20 > Thanks, > ~Saurav >=20 > > -----Original Message----- > > From: Saurav Kashyap > > Sent: Wednesday, August 25, 2021 10:29 AM > > To: Ming Lei > > Cc: Sagi Grimberg ; Nilesh Javali ; > > martin.petersen@oracle.com; linux-nvme@lists.infradead.org; linux- > > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > Upstream@marvell.com> > > Subject: RE: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues suppor= t > > > > Hi Ming, > > Comments inline > > > > > -----Original Message----- > > > From: Ming Lei > > > Sent: Tuesday, August 24, 2021 9:17 AM > > > To: Saurav Kashyap > > > Cc: Sagi Grimberg ; Nilesh Javali > ; > > > martin.petersen@oracle.com; linux-nvme@lists.infradead.org; linux- > > > scsi@vger.kernel.org; GR-QLogic-Storage-Upstream > > Upstream@marvell.com> > > > Subject: [EXT] Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > External Email > > > > > > ---------------------------------------------------------------------= - > > > On Tue, Aug 24, 2021 at 03:38:24AM +0000, Saurav Kashyap wrote: > > > > Hi Sagi, > > > > Comments inline > > > > > > > > > -----Original Message----- > > > > > From: Sagi Grimberg > > > > > Sent: Monday, August 23, 2021 10:51 PM > > > > > To: Nilesh Javali ; martin.petersen@oracle.c= om; > > > linux- > > > > > nvme@lists.infradead.org; Ming Lei > > > > > Cc: linux-scsi@vger.kernel.org; GR-QLogic-Storage-Upstream QLogic- > > > > > Storage-Upstream@marvell.com> > > > > > Subject: Re: [PATCH 0/2] qla2xxx - add nvme map_queues support > > > > > > > > > > > > > > > On 8/23/21 5:56 AM, Nilesh Javali wrote: > > > > > > Currently nvme fc doesn't support map queue functionality. This= patch > > > > > > set adds map_queue functionality to nvme_fc_mq_ops and > > > > > > nvme_fc_port_template, providing an option to LLDs to map queue= s > > > > > > similar to SCSI. For qla2xxx, minimum 10% improvement is notice= d > > > > > > with this change as it helps in reducing cpu thrashing. > > > > > > > > > > Does this make nvme-fc use managed irq? > > > > > > > > qla2xxx driver uses pci_alloc_irq_vectors_affinity to have affinity= with > each > > > MSI-X vector. Currently nvme queue are not mapped based on affinity a= nd > irq > > > offset. The change is to use blk_mq_pci_map_queues for mapping, this > > function > > > consider irq affinity as well as irq offset. > > > > > > > > > > OK, got it. Even though without this patchset, nvme-fc actually relie= s > > > on managed irq since qla2xxx driver uses pci_alloc_irq_vectors_affini= ty. > > > > > > Now the patchset[1] isn't good for addressing the issue in > > > blk_mq_alloc_request_hctx(). > > > > Can you please elaborate on this? Is there something needs to be done f= rom > my > > side? > > > > Thanks, > > ~Saurav > > > > > > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > > > 3A__lore.kernel.org_linux-2Dblock_YR7demOSG6MKFVAF-40T590_T_- > > > > > > 23t&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DZHZbmY_LbM3DUZK_BDO1 > > > OITP3ot_Vkb_5w- > > > > > > gas5TBMQ&m=3DCqFDnfAsZphubKXkUx5gsRF6RZ2Qe6sxWkYq4pBfFD0&s=3D2Nba > > > EUI5eB6_R6PxW8ld1Xn2OU3_UdD6D30uvFAWhow&e=3D > > > > > > > > > Thanks, > > > Ming