All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ravich, Leonid" <Leonid.Ravich@dell.com>
To: Jason Yan <yanaijie@huawei.com>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"dave.jiang@intel.com" <dave.jiang@intel.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Cc: Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH] dmaengine: ioat: Make two symbols static
Date: Sat, 12 Sep 2020 07:40:15 +0000	[thread overview]
Message-ID: <DM6PR19MB26820B0B8BDDEFD7E94A72AF98250@DM6PR19MB2682.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20200912072158.602585-1-yanaijie@huawei.com>

Looks good to me 

> From: dmaengine-owner@vger.kernel.org <dmaengine-
> Sent: Saturday, 12 September 2020 10:22
> 
> This eliminates the following sparse warning:
> 
> drivers/dma/ioat/dma.c:29:5: warning: symbol 'completion_timeout' was
> not declared. Should it be static?
> drivers/dma/ioat/dma.c:33:5: warning: symbol 'idle_timeout' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/dma/ioat/dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index a814b200299b..8cce4e059b7a 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -26,11 +26,11 @@
> 
>  #include "../dmaengine.h"
> 
> -int completion_timeout = 200;
> +static int completion_timeout = 200;
>  module_param(completion_timeout, int, 0644);
>  MODULE_PARM_DESC(completion_timeout,
>  		"set ioat completion timeout [msec] (default 200 [msec])");
> -int idle_timeout = 2000;
> +static int idle_timeout = 2000;
>  module_param(idle_timeout, int, 0644);
>  MODULE_PARM_DESC(idle_timeout,
>  		"set ioat idel timeout [msec] (default 2000 [msec])");
> --
> 2.25.4


  reply	other threads:[~2020-09-12  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  7:21 [PATCH] dmaengine: ioat: Make two symbols static Jason Yan
2020-09-12  7:40 ` Ravich, Leonid [this message]
2020-09-14 15:36 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR19MB26820B0B8BDDEFD7E94A72AF98250@DM6PR19MB2682.namprd19.prod.outlook.com \
    --to=leonid.ravich@dell.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hulkci@huawei.com \
    --cc=vkoul@kernel.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.