From: "Grupi, Elad" <Elad.Grupi@dell.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: RE: [PATCH] nvme-tcp: proper handling of tcp socket closing flows
Date: Fri, 29 Jan 2021 00:01:34 +0000 [thread overview]
Message-ID: <DM6PR19MB4011CDB6E299B8EB3F25AC0AEFB99@DM6PR19MB4011.namprd19.prod.outlook.com> (raw)
In-Reply-To: <53c6c0f6-99f7-ca1b-c205-05f7a03c1785@grimberg.me>
That's not what I meant.
My concern is release_work races with accept_work.
nvmet_tcp_alloc_queue is called from accept_work context and still accessing the queue struct after setting sk callbacks.
-----Original Message-----
From: Sagi Grimberg <sagi@grimberg.me>
Sent: Friday, 29 January 2021 1:54
To: Grupi, Elad; linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-tcp: proper handling of tcp socket closing flows
[EXTERNAL EMAIL]
> Release work might get invoked if nvmet_tcp_set_queue_sock is completed successfully and set sk_user_data, but sk_state_change is triggered by network stack before queue_work_on is invoked. That case - there is a race between release_work and accept_work.
This is just like any other case where release_work races with io_work.
That is not an exception from other cases which release_work will need to fence from.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-29 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 15:27 [PATCH] nvme-tcp: proper handling of tcp socket closing flows elad.grupi
2021-01-28 22:03 ` Sagi Grimberg
2021-01-28 23:07 ` Grupi, Elad
2021-01-28 23:33 ` Sagi Grimberg
2021-01-28 23:43 ` Grupi, Elad
2021-01-28 23:54 ` Sagi Grimberg
2021-01-29 0:01 ` Grupi, Elad [this message]
2021-01-29 0:07 ` Sagi Grimberg
2021-01-31 15:47 ` Grupi, Elad
2021-01-29 22:10 ` Sagi Grimberg
2021-01-31 15:47 ` Grupi, Elad
-- strict thread matches above, loose matches on Subject: below --
2021-01-26 15:37 elad.grupi
2021-01-28 7:54 ` Sagi Grimberg
2021-01-28 15:27 ` Grupi, Elad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR19MB4011CDB6E299B8EB3F25AC0AEFB99@DM6PR19MB4011.namprd19.prod.outlook.com \
--to=elad.grupi@dell.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.