From: "Aloka Dixit (QUIC)" <quic_alokad@quicinc.com>
To: 'Johannes Berg' <johannes@sipsolutions.net>,
"Aloka Dixit (QUIC)" <quic_alokad@quicinc.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Vikram Kandukuri (QUIC)" <quic_vikram@quicinc.com>,
"Jia Ding (QUIC)" <quic_jiad@quicinc.com>,
"Karthikeyan Periyasamy (QUIC)" <quic_periyasa@quicinc.com>,
"Muna Sinada (QUIC)" <quic_msinada@quicinc.com>,
"Sriram R (QUIC)" <quic_srirrama@quicinc.com>,
"Veerendranath Jakkam (QUIC)" <quic_vjakkam@quicinc.com>,
Aloka Dixit <alokad@qti.qualcomm.com>
Subject: RE: [PATCH 2/6] nl80211: add support to advertise driver's EHT capabilities
Date: Thu, 10 Feb 2022 15:57:38 +0000 [thread overview]
Message-ID: <DM8PR02MB7958662AC1065ED1D409AA90FE2F9@DM8PR02MB7958.namprd02.prod.outlook.com> (raw)
In-Reply-To: <bdc46437131fc41a1e3217099ca9395ca3c63b41.camel@sipsolutions.net>
> We did something like that in our patches:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20220204230119.b0eeb527d761.I2413a37c8f7d2d6d638038a3d95360a3fce0114d@changeid/
> https://patchwork.kernel.org/project/linux-wireless/patch/20220204230119.1ee92202ac30.Id30a3ef2844b296efbd5486fe1da9ca36a95c5cf@changeid/
>
> Not overlapping wastes like 4 bytes of memory, I think I can live with
> that, vs. the extra complexity? If you overlap you need another bit to
> indicate which one you're using ...
>
OTOH, that means we need to unwrap it in userspace, which is also
strange ... So yeah I'm changing it to a union.
Johannes
My comment was actually about your Patches but realized I hadn't subscribed this email with the mailing list so never got emails for those.
So replied here (as I am in cc), just pasted wrong link 😊
But yeah, union would work.
Thanks.
next prev parent reply other threads:[~2022-02-10 15:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 9:04 [PATCH 0/6] cfg80211/nl80211: add support for EHT Veerendranath Jakkam
2021-12-22 9:04 ` [PATCH 1/6] ieee80211: add EHT capabilities element definitions Veerendranath Jakkam
2021-12-22 9:04 ` [PATCH 2/6] nl80211: add support to advertise driver's EHT capabilities Veerendranath Jakkam
2022-02-10 5:14 ` Aloka Dixit (QUIC)
2022-02-10 8:26 ` Johannes Berg
2022-02-10 11:17 ` Johannes Berg
2022-02-10 15:57 ` Aloka Dixit (QUIC) [this message]
2022-02-10 16:29 ` Johannes Berg
2021-12-22 9:04 ` [PATCH 3/6] nl80211: add support to send EHT capabilities from userspace Veerendranath Jakkam
2022-02-03 12:45 ` Johannes Berg
2022-02-04 7:12 ` Veerendranath Jakkam
2022-02-04 8:11 ` Johannes Berg
2022-02-04 14:37 ` Veerendranath Jakkam
2022-02-04 14:43 ` Johannes Berg
2022-02-04 17:43 ` Veerendranath Jakkam
2022-02-04 17:45 ` Johannes Berg
2022-02-04 18:28 ` Veerendranath Jakkam
2022-02-03 12:47 ` Johannes Berg
2022-02-04 7:18 ` Veerendranath Jakkam
2021-12-22 9:04 ` [PATCH 4/6] cfg80211: Add support for EHT 320 MHz channel width Veerendranath Jakkam
2021-12-22 9:04 ` [PATCH 5/6] nl80211: add support for 320MHz channel limitation Veerendranath Jakkam
2021-12-22 9:04 ` [PATCH 6/6] nl80211: add EHT MCS support Veerendranath Jakkam
2022-02-04 14:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR02MB7958662AC1065ED1D409AA90FE2F9@DM8PR02MB7958.namprd02.prod.outlook.com \
--to=quic_alokad@quicinc.com \
--cc=alokad@qti.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jiad@quicinc.com \
--cc=quic_msinada@quicinc.com \
--cc=quic_periyasa@quicinc.com \
--cc=quic_srirrama@quicinc.com \
--cc=quic_vikram@quicinc.com \
--cc=quic_vjakkam@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.