From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Vidya Sagar Velumuri <vvelumuri@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Akhil Goyal <gakhil@marvell.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
Date: Sun, 31 Oct 2021 22:06:32 +0000 [thread overview]
Message-ID: <DM8PR11MB55919FC45F410AF42C3563FB84899@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BY3PR18MB4628C0219C81F0498F3DDFB2A7889@BY3PR18MB4628.namprd18.prod.outlook.com>
Hi Sagar,
Thanks for flagging this. I submitted a patch fixing the IV of the test vectors I pushed (it didn't change the output):
http://patches.dpdk.org/project/dpdk/patch/20211031220421.52181-1-pablo.de.lara.guarch@intel.com/
Could you check if they work for you?
Thanks,
Pablo
From: Vidya Sagar Velumuri <vvelumuri@marvell.com>
Sent: Saturday, October 30, 2021 1:26 PM
To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Ankur Dwivedi <adwivedi@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
Hi Pablo,
Tried the test vector zuc256_test_case_auth_1 and the digest did not match with the generated digest in our platform.
As per spec, IV[i] for i = 17 to\x14 24 are 6-bit string occupying the 6 least signi cant bits of a byte.
But in the vectors, The values in the IV(byte -17 to 24) are > 0x3f.
Could you please elaborate how these bytes are considered for generation of digest.
Regards
Sagar
________________________________
From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com<mailto:pablo.de.lara.guarch@intel.com>>
Sent: 29 October 2021 18:07
To: Vidya Sagar Velumuri <vvelumuri@marvell.com<mailto:vvelumuri@marvell.com>>; Ankur Dwivedi <adwivedi@marvell.com<mailto:adwivedi@marvell.com>>; Anoob Joseph <anoobj@marvell.com<mailto:anoobj@marvell.com>>; Tejasree Kondoj <ktejasree@marvell.com<mailto:ktejasree@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com<mailto:ndabilpuram@marvell.com>>; Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>; Doherty, Declan <declan.doherty@intel.com<mailto:declan.doherty@intel.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
External Email
----------------------------------------------------------------------
Hi Vidya,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org<mailto:dev-bounces@dpdk.org>> On Behalf Of Vidya Sagar Velumuri
> Sent: Wednesday, October 27, 2021 9:41 AM
> To: adwivedi@marvell.com<mailto:adwivedi@marvell.com>; anoobj@marvell.com<mailto:anoobj@marvell.com>; ktejasree@marvell.com<mailto:ktejasree@marvell.com>;
> ndabilpuram@marvell.com<mailto:ndabilpuram@marvell.com>; gakhil@marvell.com<mailto:gakhil@marvell.com>; Doherty, Declan
> <declan.doherty@intel.com<mailto:declan.doherty@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>
> Subject: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key
>
> Fix the IV and MAC in the test vectors added for zuc 256-bit key
>
> Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys)
>
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com<mailto:vvelumuri@marvell.com>>
The new vectors are failing for us. Could you check if the ones we added work for you?
Thanks,
Pablo
next prev parent reply other threads:[~2021-10-31 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:40 [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key Vidya Sagar Velumuri
2021-10-28 7:10 ` Akhil Goyal
2021-10-29 12:37 ` De Lara Guarch, Pablo
2021-10-30 12:25 ` Vidya Sagar Velumuri
2021-10-31 22:06 ` De Lara Guarch, Pablo [this message]
2021-11-01 10:23 ` Vidya Sagar Velumuri
2021-11-02 4:40 ` Vidya Sagar Velumuri
2021-11-02 11:17 ` De Lara Guarch, Pablo
2021-11-03 6:55 ` [dpdk-dev] [PATCH v2] " Vidya Sagar Velumuri
2021-11-03 9:28 ` De Lara Guarch, Pablo
2021-11-03 9:31 ` [dpdk-dev] [PATCH v3] " Vidya Sagar Velumuri
2021-11-04 10:52 ` Akhil Goyal
2021-11-04 12:18 ` De Lara Guarch, Pablo
2021-11-04 18:38 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB55919FC45F410AF42C3563FB84899@DM8PR11MB5591.namprd11.prod.outlook.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=ktejasree@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=vvelumuri@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.