From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544D6C433EF for ; Wed, 13 Oct 2021 09:54:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 97CA860F21 for ; Wed, 13 Oct 2021 09:54:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 97CA860F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE126410DA; Wed, 13 Oct 2021 11:54:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3E50540150 for ; Wed, 13 Oct 2021 11:54:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="250807411" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="250807411" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 02:54:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="626283047" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2021 02:54:14 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 02:54:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 02:54:13 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 02:54:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dyhMbjrQHzHFM/Px+7n0/Gsq/MTZtBwduHo6IDmM34Ab3h+4VvMyUQeiYWcVopPP/OPemq04LARSDxhwuyuc75TQ/XktZ8uP1IJE/pIDhf2c1E+7Ll2Ai+0IJIELZ7QDtzWQsqEapwEWbb+WIDzWPKXjmTiq/d70rb2OkcQ6soJZIbx778OMWLco9uJWx1jyCJ99YDtFsxlGRmqXvAsLA0bbHbGsU1PdOH6s9K9W83MYEFm0Dbkd2Aq0gEvG1qWiCipM77OPJ1aEbJiVZB7PTQeMqf/IOJe7T0pVYMtfEZZNiadk/YgecgnZ9bflwvqkqmCapA5PEMQg6nQ8Y1TUeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5E7euTKcgUl/8rfGcEPKZytus0yPuMSSTnIJO/eBeh4=; b=YspaASegO5SUPM6o6pur6hIJxhIVIgSu+FkIyM2MiUny4SZE6iNkor8uoQis+EeNpZ+1ZdrjQHoil5R3XvdQNOR4gW2uMJwm/fZLHZfkfR+DCKpjKNuiPaTDaqLrlsfmcyJVBv7toOXJ8yiCvFb0s2QugPrVHztRYTXE5QzPCHfXTHscThHYhSVY0fin7ba/pEyGm1L6s9C21KuFD/VautzFLk8YD1QsfxoMOp7GWKXo4ZvLY8Qij39WonUofGUBCLMpDNFjO/RDr+/bZM+P+I9RVcdi8QwEdSCwgRrkIZI3M+2UPCW17EVZHaD2F8uLXtI+9XFY4v7pWHXxYN/WyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5E7euTKcgUl/8rfGcEPKZytus0yPuMSSTnIJO/eBeh4=; b=PuTzLlQDPMSZw9PV9IhuGM7rOZtV1D+eal49Yqrbf7FUdU9b/pnA51ydaa4E9nsv6PnOCtAJrQVuz6jtzRXF7M0Eht0Zvqq8mfBhIDhthhNoPCXwqpQuBLrZic9xCyGtLWlGCe//Pim2zhfe/14JdLPV6HANh7KoE7oETcectI4= Received: from DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) by DM8PR11MB5590.namprd11.prod.outlook.com (2603:10b6:8:32::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Wed, 13 Oct 2021 09:54:05 +0000 Received: from DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::102c:6b2f:161b:479e]) by DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::102c:6b2f:161b:479e%3]) with mapi id 15.20.4587.027; Wed, 13 Oct 2021 09:54:05 +0000 From: "Wang, Jie1X" To: Ori Kam , "dev@dpdk.org" CC: "Yigit, Ferruh" , NBU-Contact-Thomas Monjalon , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash Thread-Index: AQHXv1N+v/b3XTh2/UGc8uP60m4VXqvPfemAgAEWjbCAABJ8gIAAA2Jg Date: Wed, 13 Oct 2021 09:54:05 +0000 Message-ID: References: <20210924151705.287571-1-jie1x.wang@intel.com> <20211012102508.275790-1-jie1x.wang@intel.com> <20211012102508.275790-3-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af9c7c00-bb8d-463a-7da2-08d98e2f64de x-ms-traffictypediagnostic: DM8PR11MB5590: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y8PO0sueswq3t5PWZ8YXT7mowBzuYzEOkeP4Hqr/zzmKAebnah6ZMraRMChUTvSI+bVK5Duw2TejFHu6GDQp4I20T/TlQOlG8zHmYBQGv4N2kKuIQr7k+vKfU5J08O3GwQmgvpIB5HD4PUDz4fscUry7vnA9nEwN7dfdQ5tE0M1NuLjmRZZaDYqZeVVsKg70SjNUmaK4ig/K1Z4O0wShr2UdIVMh9cI/Pj7TsDFo9jO+80EvoygkmlinEg37KXhg1FziTkSLDQkaDe9eAWX1xcinz6ohzD7y+ByJDy3W30nj54MiITOTt8kV7vn7hSJ3Hdvs5f0rp2rci9ikf0cQcbX9nModQWtFvzYA09hUdPO26j/SNTcwELVeY9lQUbMHcqAU/dozeexohkmLMJdPehkNMTvauEDF5+vUyBgqD3Hdtr0nEe+dfjefMbgp9nJ0k90y/Prc1dEnBkcX+m3yvg94ZqaV4dXVHHHnvHCoN6w4XS6wdfkzlYCNuEOqEsTmuKtz+svp18mb6ZtkXfBpwFZNq4/xYvGXFvFsqTODC9B0/Ya7NtCKe7pPpRwLdghIrxWFbDIKoEXW+6f5zFnGUxpBy+jmJ+hTD42R/ocdMOGEx9Z2ULR/YEMcPlHil9v/JgDNrmXFW78k3xhjsttfNYefBGjo18NJwL2hB+uwrPgOKSldRdOw4t58E3GRHuhtKRkwnDXY/sspS/YIfsAkBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(53546011)(5660300002)(26005)(186003)(83380400001)(66446008)(54906003)(71200400001)(55016002)(38100700002)(66556008)(33656002)(2906002)(82960400001)(122000001)(4326008)(8936002)(38070700005)(316002)(64756008)(9686003)(86362001)(6506007)(107886003)(8676002)(7696005)(110136005)(66946007)(508600001)(52536014)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DkhoH4LsvHzUZlJcNN1ai0oX7v3DqWx4u3qxi58Ww3N/QmzoM11GuhMcn7oL?= =?us-ascii?Q?UDKg5PGpH2ngftMP5Addesde8E6ldE8y2dxArOW3kmjZXJ0lreybA339ByM9?= =?us-ascii?Q?okKn+GnMvhpnSyWVbifwVLiYYNdIYlb0JNiRor7dF8/I5oPJZtmJMnqKxtgR?= =?us-ascii?Q?pIh2a3H+xHI/zptqK2uo0VMjLOm2VEPo7zYMl9bgs2+OQVOswvgyF31XyqD/?= =?us-ascii?Q?3K8ixFowDmB48zVYs/lQE3c5zPCpt6KmxfgD8EmBeBjk4M9PyDLkNJK9Sy4R?= =?us-ascii?Q?JonJ3HsKik8yaibpY75XJIpunPg6NLSduy+ws0iySl+cunhSYA4H8yLNDBuw?= =?us-ascii?Q?7xDrjrUW/T++Oo7tzmsO+9QyMZgUa46pLxpzodtqVJ3oHKuwsTVykRwBQ3h5?= =?us-ascii?Q?/y51yOrDdlvehAEtCTDd4B1H8Qn3OmbJ68ztw6yVKu2rP822JoxcvJiSBAhE?= =?us-ascii?Q?SwGZ6S0dXPf4x7Zwb9DzbYybIPasygGs5JJ5Y/LLGPWMFr+qKqpEDGYKMc+j?= =?us-ascii?Q?1MVVsKxIscv1n6DYkD/wkTTu/3SbrE0jgEyyAFL4Q6SwRZcQpjCchDMCo7Vz?= =?us-ascii?Q?Jzi6Xb9sMU/x5vszlJiGm6cAAZioquM3rWwkCogBBie5OGd+qi9zeFS+pT+f?= =?us-ascii?Q?cgHFZ3axSuD2J8/yU4nh90eMZGTOsJKs/KLBG408uX9DhctT+TljbY8tseBc?= =?us-ascii?Q?OgGe3T2qe8O0/72Ci6FMdNEwS1jWtX5bjpmQ6aAYpxrmhqpSxxw0I3R2B9m8?= =?us-ascii?Q?fXEr5EZG1cL/shNM7/GuOMQFMCtZlulPgdkDsxgYKVwmn2NBKfp/QijJzk1X?= =?us-ascii?Q?QCHXZr43frvsr68BPYz7Ra7RQmCR1SewgkdnW0D3DXXxsr3a5u7Sn8JMQJ70?= =?us-ascii?Q?4k3nI8SgkRD3NsepPU7UW7OPmReVNMfvGliXW4ryGvxCql5m6SNxZykgAmBq?= =?us-ascii?Q?My/CC2FUplOYLK2vIELxwZHxeIOtBVc11DhO5Qp/6peLCjZCsCeNYX8XfO9E?= =?us-ascii?Q?x1BKfBmzJFikCh3CzMiWXnBeA5cqJ6YgFnypdoROlXsK3dPDsK6yoQ7v4PhT?= =?us-ascii?Q?vj3R9sLGQrfGuiTG9BvBS1rbx/EuUMXI5W0JKiWL+xmVC3Yin4+8P4APkeS8?= =?us-ascii?Q?M+XetREdlOjRT5EUyr6r+L62Q3B1XcSPx02ugD3/GQE3/FOWwV53Ev51YqPY?= =?us-ascii?Q?x9ScKefk/4F/JgRN5/CEaZ8G6Gjs1HMavkSpH79fCCuefiZhkqCv8YfUdNxg?= =?us-ascii?Q?aSguYlXQYC2vOgPQoSPsyki3f2TJ4tx8bt+5iiBNGSN58eUTGI9fTsoJdQPi?= =?us-ascii?Q?qpc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af9c7c00-bb8d-463a-7da2-08d98e2f64de X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 09:54:05.5321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FqXSmDvxU3kReI/rr9GvTkkLkIshyVDBv/SYZApSisvjmgL5UP0qnzSCs0Je4gre6+Tcv4lRdOc/0oCjRTljOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5590 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ori Kam > Sent: Wednesday, October 13, 2021 5:15 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yigit, Ferruh ; NBU-Contact-Thomas Monjalon > ; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjin= g > ; Xing, Beilei ; Wu, Wenjun= 1 > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUD= P > RSS Hash >=20 > Hi Wang, >=20 > > -----Original Message----- > > From: Wang, Jie1X > > Sent: Wednesday, October 13, 2021 11:16 AM > > > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > PPPoL2TPv2oUDP RSS Hash > > > > > > > > > -----Original Message----- > > > From: Ori Kam > > > Sent: Tuesday, October 12, 2021 11:32 PM > > > To: Wang, Jie1X ; dev@dpdk.org > > > Cc: Yigit, Ferruh ; NBU-Contact-Thomas > > > Monjalon ; andrew.rybchenko@oktetlabs.ru; Li, > > > Xiaoyun ; Yang, SteveX > > > ; Wu, Jingjing ; Xing, > > > Beilei ; Wu, Wenjun1 > > > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > PPPoL2TPv2oUDP RSS Hash > > > > > > Hi Jie, > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Jie Wang > > > > Sent: Tuesday, October 12, 2021 1:25 PM > > > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support > > > > PPPoL2TPv2oUDP RSS Hash > > > > > > > > Add support for test-pmd to parse protocol pattern L2TPv2 and PPP. > > > > > > > > Signed-off-by: Wenjun Wu > > > > Signed-off-by: Jie Wang > > > > --- > > > > app/test-pmd/cmdline_flow.c | 34 > > > > ++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 34 insertions(+) > > > > > > > > diff --git a/app/test-pmd/cmdline_flow.c > > > > b/app/test-pmd/cmdline_flow.c index > > > > bb22294dd3..3c9bcabd97 100644 > > > > --- a/app/test-pmd/cmdline_flow.c > > > > +++ b/app/test-pmd/cmdline_flow.c > > > > @@ -299,6 +299,8 @@ enum index { > > > > ITEM_GENEVE_OPT_TYPE, > > > > ITEM_GENEVE_OPT_LENGTH, > > > > ITEM_GENEVE_OPT_DATA, > > > > + ITEM_PPP, > > > > + ITEM_L2TPV2, > > > > ITEM_INTEGRITY, > > > > ITEM_INTEGRITY_LEVEL, > > > > ITEM_INTEGRITY_VALUE, > > > > @@ -997,6 +999,8 @@ static const enum index next_item[] =3D { > > > > ITEM_AH, > > > > ITEM_PFCP, > > > > ITEM_ECPRI, > > > > + ITEM_PPP, > > > > + ITEM_L2TPV2, > > > > > > Why in the middle? > > > > > > > Ok, I will update it. > > > > > > ITEM_GENEVE_OPT, > > > > ITEM_INTEGRITY, > > > > ITEM_CONNTRACK, > > > > @@ -1368,6 +1372,16 @@ static const enum index item_integrity_lv[] = =3D { > > > > ZERO, > > > > }; > > > > > > > > +static const enum index item_ppp[] =3D { > > > > + ITEM_NEXT, > > > > + ZERO, > > > > +}; > > > > + > > > > +static const enum index item_l2tpv2[] =3D { > > > > + ITEM_NEXT, > > > > + ZERO, > > > > +}; > > > > + > > > > static const enum index next_action[] =3D { > > > > ACTION_END, > > > > ACTION_VOID, > > > > @@ -3579,6 +3593,20 @@ static const struct token token_list[] =3D { > > > > (sizeof(struct rte_flow_item_geneve_opt), > > > > ITEM_GENEVE_OPT_DATA_SIZE)), > > > > }, > > > > + [ITEM_PPP] =3D { > > > > + .name =3D "ppp", > > > > + .help =3D "match ppp header", > > > > + .priv =3D PRIV_ITEM(PPP, sizeof(struct rte_flow_item_ppp)), > > > > + .next =3D NEXT(item_ppp), > > > > + .call =3D parse_vc, > > > > + }, > > > > + [ITEM_L2TPV2] =3D { > > > > + .name =3D "l2tpv2", > > > > + .help =3D "match l2tpv2 header", > > > > + .priv =3D PRIV_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2))= , > > > > + .next =3D NEXT(item_l2tpv2), > > > > + .call =3D parse_vc, > > > > + }, > > > > [ITEM_INTEGRITY] =3D { > > > > .name =3D "integrity", > > > > .help =3D "match packet integrity", @@ -8343,6 +8371,12 @@ > > > > flow_item_default_mask(const struct > > > rte_flow_item *item) > > > > case RTE_FLOW_ITEM_TYPE_PFCP: > > > > mask =3D &rte_flow_item_pfcp_mask; > > > > break; > > > > + case RTE_FLOW_ITEM_TYPE_L2TPV2: > > > > + mask =3D &rte_flow_item_l2tpv2_mask; > > > > + break; > > > > + case RTE_FLOW_ITEM_TYPE_PPP: > > > > + mask =3D &rte_flow_item_ppp_mask; > > > > + break; > > > > default: > > > > break; > > > > } > > > > -- > > > > 2.25.1 > > > > > > Maybe I'm missing something but I don't see that you added the > > > ability to match on any of the header fields value. > > > You also didn't update the code of encap (from my understanding this > > > is a tunnel > > > header) > > > > > > Best, > > > Ori > > > > Hi Ori, > > > > This feature is only support for iavf enable PPPoL2TPv2oUDP rss. So it > > doesn't need to add the ability to match on any of the header fields va= lue and > the code of encap. > > > > I'm not sure if it is necessary to add these. >=20 > You added a lot of fields in the rte_flow and you don't give any way to t= est them. > also Iike I said in previous patch what is the relation between matching = items to > RSS? > You didn't add it to the RSS possible support. >=20 > Best, > Ori The feature apply a RSS rule on L2TP data packet (include PPP over L2TP) wi= th inner IP / port as input set. It doesn't need match any L2TP field.