From: "Khor, Swee Aun" <swee.aun.khor@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Romli, Khairul Anuar" <khairul.anuar.romli@intel.com>,
"Khor, Swee Aun" <swee.aun.khor@intel.com>,
"Mazlan, Hazwan Arif" <hazwan.arif.mazlan@intel.com>,
"Kasireddy, Vivek" <vivek.kasireddy@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"eblake@redhat.com" <eblake@redhat.com>,
"armbru@redhat.com" <armbru@redhat.com>
Subject: RE: [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor'.
Date: Thu, 24 Jun 2021 00:56:28 +0000 [thread overview]
Message-ID: <DM8PR11MB571751EF8FB44E601757843AAF079@DM8PR11MB5717.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210623123351.irmwdawwktbvkdsb@sirius.home.kraxel.org>
Hi Gerd,
I am able to compile the code without error with my v3 patch. I don't see my patch showing up in https://patchew.org/QEMU/ , is it due to this compilation error?
I tried to change from %ld -> %lld but I encountered compilation error this time.
../ui/gtk.c: In function 'gtk_display_init':
../ui/gtk.c:2300:25: error: format '%lld' expects argument of type 'long long int', but argument 2 has type 'int64_t' {aka 'long int'} [-Werror=format=]
2300 | warn_report("Failed to enable full screen on monitor %lld. "
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
......
2303 | opts->u.gtk.full_screen_on_monitor, monitor_n);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int64_t {aka long int}
cc1: all warnings being treated as errors
Suspect it is due to variants of host machine, I think I will change it to use PRId64 which is more generic for all platform like below. What you think?
warn_report("Failed to enable full screen on monitor %" PRId64 ". "
"Current total number of monitors is %d, "
"please verify full-screen-on-monitor option value.",
opts->u.gtk.full_screen_on_monitor, monitor_n);
or you prefer casting ? This seems working as well.
warn_report("Failed to enable full screen on monitor %lld . "
"Current total number of monitors is %d, "
"please verify full-screen-on-monitor option value.",
(long long)opts->u.gtk.full_screen_on_monitor, monitor_n);
Regards,
SweeAun
-----Original Message-----
From: Gerd Hoffmann <kraxel@redhat.com>
Sent: Wednesday, June 23, 2021 8:34 PM
To: Khor, Swee Aun <swee.aun.khor@intel.com>
Cc: qemu-devel@nongnu.org; armbru@redhat.com; eblake@redhat.com; Romli, Khairul Anuar <khairul.anuar.romli@intel.com>; Kasireddy, Vivek <vivek.kasireddy@intel.com>; Mazlan, Hazwan Arif <hazwan.arif.mazlan@intel.com>; Khor@sirius.home.kraxel.org
Subject: Re: [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor'.
On Wed, Jun 23, 2021 at 04:27:44PM +0800, Khor, Swee Aun wrote:
> This lets user select monitor number to display QEMU in full screen
> with -display gtk,full-screen-on-monitor=<value>.
../../ui/gtk.c: In function 'gtk_display_init':
../../ui/gtk.c:2300:25: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'int64_t' {aka 'long long int'} [-Werror=format=]
2300 | warn_report("Failed to enable full screen on monitor %ld. "
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
......
2303 | opts->u.gtk.full_screen_on_monitor, monitor_n);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| int64_t {aka long long int}
take care,
Gerd
next prev parent reply other threads:[~2021-06-24 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210623082744.24421-1-swee.aun.khor@intel.com>
2021-06-23 12:33 ` [PATCH v3] ui/gtk: New -display gtk option 'full-screen-on-monitor' Gerd Hoffmann
2021-06-24 0:56 ` Khor, Swee Aun [this message]
2021-06-24 8:48 ` Gerd Hoffmann
2021-06-24 8:51 ` Khor, Swee Aun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB571751EF8FB44E601757843AAF079@DM8PR11MB5717.namprd11.prod.outlook.com \
--to=swee.aun.khor@intel.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hazwan.arif.mazlan@intel.com \
--cc=khairul.anuar.romli@intel.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.