RE: [PATCH v7 3/4] vdpa: Support for configuring max VQ pairs for a device

From: Eli Cohen <elic@nvidia.com>
To: David Ahern <dsahern@kernel.org>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"si-wei.liu@oracle.com" <si-wei.liu@oracle.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
	"lulu@redhat.com" <lulu@redhat.com>,
	Parav Pandit <parav@nvidia.com>
Subject: RE: [PATCH v7 3/4] vdpa: Support for configuring max VQ pairs for a device
Date: Mon, 14 Mar 2022 15:35:46 +0000	[thread overview]
Message-ID: <DM8PR12MB5400C9467A4EA3895CAB1AD9AB0F9@DM8PR12MB5400.namprd12.prod.outlook.com> (raw)
In-Reply-To: <6d9e4118-ee4d-0398-0db5-bd3521122734@kernel.org>

> 
> On 3/13/22 11:12 AM, Eli Cohen wrote:
> > @@ -290,6 +295,14 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
> >
> >  			NEXT_ARG_FWD();
> >  			o_found |= VDPA_OPT_VDEV_MTU;
> > +		} else if ((matches(*argv, "max_vqp")  == 0) && (o_optional & VDPA_OPT_MAX_VQP)) {
> > +			NEXT_ARG_FWD();
> > +			err = vdpa_argv_u16(vdpa, argc, argv, &opts->max_vqp);
> > +			if (err)
> > +				return err;
> > +
> > +			NEXT_ARG_FWD();
> > +			o_found |= VDPA_OPT_MAX_VQP;
> >  		} else {
> >  			fprintf(stderr, "Unknown option \"%s\"\n", *argv);
> >  			return -EINVAL;
> 
> new options require an update to the man page. That should have been
> included in this set. Please make sure that happens on future sets.

OK, since you already asked to send a new version, I will include.