Re: [OE-core] [hardknott][PATCH] bitbake: server: Fix early parsing errors preventing zombie bitbake

Re: [OE-core] [hardknott][PATCH] bitbake: server: Fix early parsing errors preventing zombie bitbake

[Chris Laplante]

Hello,

> If the client process never sends cooker data, the server timeout will be 0.0,
> not None. This will prevent the server from exiting, as it is waiting for a new
> client. In particular, the client will disconnect with a bad "INHERIT" line, such
> as:
> 
>     INHERIT += "this-class-does-not-exist"
> 
> Instead of checking explicitly for None, check for a false value, which means
> either 0.0 or None.
> 
> (Bitbake rev: 7668057f8565655611de23d143432d1c05dae3ce)
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 881005ec405f26b8f7f4b41505d69579e83b69c4)

Was this the correct for me to request application of this patch to hardknott branch? I've never tried to submit a patch to something other than master.

No rush obviously, just wanted to check that I was doing it right.

Thanks,
Chris 

Re: [OE-core] [hardknott][PATCH] bitbake: server: Fix early parsing errors preventing zombie bitbake

[Anuj Mittal]

On Wed, 2021-09-08 at 17:27 +0000, Chris Laplante via
lists.openembedded.org wrote:
> Hello,
> 
> > If the client process never sends cooker data, the server timeout
> > will be 0.0,
> > not None. This will prevent the server from exiting, as it is
> > waiting for a new
> > client. In particular, the client will disconnect with a bad
> > "INHERIT" line, such
> > as:
> > 
> >     INHERIT += "this-class-does-not-exist"
> > 
> > Instead of checking explicitly for None, check for a false value,
> > which means
> > either 0.0 or None.
> > 
> > (Bitbake rev: 7668057f8565655611de23d143432d1c05dae3ce)
> > 
> > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > (cherry picked from commit
> > 881005ec405f26b8f7f4b41505d69579e83b69c4)
> 
> Was this the correct for me to request application of this patch to
> hardknott branch? I've never tried to submit a patch to something
> other than master.
> 
> No rush obviously, just wanted to check that I was doing it right.

Thanks, this is the right way to request a backport. But since this is
a bitbake change, should have been sent to the bitbake list. I had
picked this though so no need to re-send.

Thanks,

Anuj

Re: [OE-core] [hardknott][PATCH] bitbake: server: Fix early parsing errors preventing zombie bitbake

[Chris Laplante]

Hi Anuj,

> Thanks, this is the right way to request a backport. But since this is a bitbake
> change, should have been sent to the bitbake list. I had picked this though so
> no need to re-send.

Ah right. Thank you!
Chris