From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7491C433F5 for ; Sat, 21 May 2022 08:34:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C3B7383C7B; Sat, 21 May 2022 10:34:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="bGpNG2F/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8677C83D90; Sat, 21 May 2022 10:34:05 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0628.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::628]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 86A4583E36 for ; Sat, 21 May 2022 10:34:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bToAtvu5Q7p7llqouIOyOPXzjLNuDeyWIgZnBAPKI+MvLTN7MnDMYY2cBYwZRYDJ0zgh+3X1GDtOfCTYzpYH9kHM+NpgNc8pSUlSGBrs3KxMNWsZO6rQmfk1Kc7pe2dBCXDMQngVjGaFhFc5j0Ovv3eq6P/6fAp3ltsPQUfePyw+jhRP22JvLRQR1BkNmkHzhIB60yogg96uHU8O83PLSq1e5+1jWrJracp2n2TpY83hdp1FEact3VeTAvBjvqoYy8AEZZ62ODdm095P8U5fEJONnw1ol4YfmnqgaTscGVCbj6KEGx83x4QhFABVMD+L49d/v/I1ut647IuFWCcApQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xekv4++JQ/iEI4iroXj8vPJcr1SXboDf8RTOOGQqug8=; b=T5fL3rVHct7BLjP6ex9GeD512QlOm/gvLAriusf65OKttnTX1VvjpT24V8bN1fO6i8/StQ79euFneVrbUnumjKVlFZKVjdbEjnyClpX1zPep4TxQ/0+jvkjFmGQyNBPC8avBOsN44KUxM+PtytYhibY2HE+SamXXqpnFXDi3C09dWXPLmUol5K8BOZWKzx9d7v6/OcVacSo4LPswMbCm72KPqK0Xn03JQvglw9oj4GBHhFhGaRfPZ83LqXghi9eFK758qMqnR+juYO4AACCkrTZIGB+bP3XPzCFdITtR0OFzf7P2LtxDlt79Oq3Nbw2e71AUwuPx3eWFhpVAlLZC4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xekv4++JQ/iEI4iroXj8vPJcr1SXboDf8RTOOGQqug8=; b=bGpNG2F/nllqJMEnBJn0yWDHiqnA0SIQQwlhrZ2R7Krb1xjuFMAhDvganyIDrpJ2pff5uAac3CUXUY5zyGEvksxpLvverT/jBkpJ6qlhQzcnksrJxfjTnRWEGeHWISt0lgXZZWEqW4RsbOZrocDybgjpGTELGL2CiHkZwFwPusU= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by HE1PR0401MB2473.eurprd04.prod.outlook.com (2603:10a6:3:86::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Sat, 21 May 2022 08:33:56 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5%7]) with mapi id 15.20.5250.014; Sat, 21 May 2022 08:33:56 +0000 From: Peng Fan To: Tom Rini , "Peng Fan (OSS)" CC: "sbabic@denx.de" , "festevam@gmail.com" , "ariel.dalessandro@collabora.com" , "michael@amarulasolutions.com" , "tharvey@gateworks.com" , "sjg@chromium.org" , "alpernebiyasak@gmail.com" , "marek.behun@nic.cz" , "pali@kernel.org" , "sr@denx.de" , Ricardo Salveti , "patrick.delaunay@foss.st.com" , "u-boot@lists.denx.de" Subject: RE: [PATCH V4 1/8] spl: guard u_boot_any with X86 Thread-Topic: [PATCH V4 1/8] spl: guard u_boot_any with X86 Thread-Index: AQHYbE2C0tonoCsFIUChPnpJ0sywtq0n4fGAgAEf4ZA= Date: Sat, 21 May 2022 08:33:56 +0000 Message-ID: References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-2-peng.fan@oss.nxp.com> <20220520152127.GC13239@bill-the-cat> In-Reply-To: <20220520152127.GC13239@bill-the-cat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3aea4156-0a37-4111-ae18-08da3b04a521 x-ms-traffictypediagnostic: HE1PR0401MB2473:EE_ x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yVFLSJN7GVvwzO4y1OpJxP2N9il6R8qsHnmdyXVht+fhNMxumAItTXSNhA1HGYQDl1f6ohg0ej3dvYfUr/9qHTfZVCXKYk9W74571pfmqKDY3uhQut50MfkPsqmQS8ytE306DbzNmBe6wM/pO7bpMGimIc+YqaZWkairQ9nmQ6MTcwNe6yyVsH2cR+0uLaOnEb2qJZdt0oDs5wDRFI7jIoeYfGM+dItfm9fpEWK9HNkVBUSwvDwLV9o1uBHT/ti9M15Uoauy+4AqPi7vPKdczwDYAFzllY4s74b3GfDc+LEhP3qdC6Wd0wXHtZ1HY220MOodNiwVwjI9FCJ6e1I2Op8QybWldb9c1bgEOIFm37/yJtZ6dmx9qhwgwwSsGhWkYLO/vq7VS2RcUuQxcEHELkZtfGxJyS3VeNEB9S9F3JqIJ6XujwG7XabsIbmixfT606fMwVhZi2SleOjic+zTonsqW150Pp1+++nnDFXIiumubPyBMWWaJbmcozZfSPsSwnlvHmLS3bolZzuqpJ4tmpvAqqWVHAahcJrhsJYXXDgZV4+90YtterKUPQg5QC7X2+KLonWHzDjxL5MM3Fw/SltNtSo7yDhjZweCEbyKqYoua4IRTRdWeJETPXgVrZTuhAGx4cHW1rpd/ufGiRq83w6AMwfD5IZo/TnXmyNzCr6PYokQu3w7R7OdJkbp/A5WSbRPCUYe29HgyDFOXQ46fg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(9686003)(4744005)(7696005)(6506007)(26005)(110136005)(44832011)(83380400001)(54906003)(38070700005)(55016003)(122000001)(71200400001)(2906002)(38100700002)(8676002)(4326008)(508600001)(66556008)(66946007)(64756008)(66446008)(66476007)(76116006)(86362001)(5660300002)(8936002)(316002)(7416002)(52536014)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/QhwWKoeJJE8FjkgJofrRtqDxY25tyoo64rpv8U9MgmkJM8gOSN8M45zfV1G?= =?us-ascii?Q?FyaVd2NhIaHVZN8rQGAQzqrM8tktHjcPGMS1DgZ6TR3DKi8Cmab8cyHzB33z?= =?us-ascii?Q?ar3+3UHaLmKe+dS+Z6Ofh2lghyoGa7kvfeP5rn1BASuxrnPM4rDo4gm9mNJt?= =?us-ascii?Q?Igb1TdqSfZPhSr6i32doZj5r5taT8C7KJIHs3gXHQZFZk9L6g+QRMFQUHXTq?= =?us-ascii?Q?lJMt2mxL3Xd7SIFibz3fQ/8ieuKxfbxdlsMwiNaH+A8voaMrrXCx+Cuv0WN8?= =?us-ascii?Q?rFWxMh3LU6L8G2l/M5XrXBfN7EQulWp1dZ6HU/jnrh0Wk6klmbQzmGrDGEjo?= =?us-ascii?Q?u/30smxD+YIT378LN1TxoC3DEWPpyDQtHrVvtWKcQJEuSltGGHA8rt97QVFO?= =?us-ascii?Q?Q2A7mFnn+hiFcjgodCK0fQZf42tIk6C7BPdbKiDvIKrsNVEtLKKl60cFrV8E?= =?us-ascii?Q?x60SlXjs8eNQjoIE8OwTiR02v9n9VZkC9keWIMu9vTOHxW3d0iYzv1Wt5Xlm?= =?us-ascii?Q?WpFUV331xyU61AdFcVVANlJC7AoGduyyxRB/8n3v4axaA2FR4ZQcdMOKCOTA?= =?us-ascii?Q?dqZ3G+kvPgW5iXKNJS0ofsZdkBDqoeq/omDxwQagCCsqeJbYjTdWJT0uWnZ0?= =?us-ascii?Q?EU1nmFx+WHAPngrtJQVP20cVi4K13Qz8R7/v9yvkvddbVqBMTSUggOO3COIj?= =?us-ascii?Q?9paabUamf6pgy7S5dVbQVp9ecs3AJB89l08YsOiUNfUPduleh+i8ymIUIbLF?= =?us-ascii?Q?oO0SuksAwizLTYWPOxQ/60bJ5WhzpMynuRLm+qpTG9fi32FHvgVILkLHxqPj?= =?us-ascii?Q?z8BUbQfH47Zp1kn7n/UMt5hpr4bj6Gd03eL9QzP4iE1Zdx7COvGAmLcE/nYO?= =?us-ascii?Q?b2iSSs8/BRG1vl1tEa1E/KGsNVZ7ZujBSEDLyJxmtj6NXX4PiSTO6PhM2CbH?= =?us-ascii?Q?2yGu/JNzxmpEnoNov9FIUSbxNy+CpfzNtp5cq6LAHO2sfabugMbPccoLXXq+?= =?us-ascii?Q?zguhpp8nUOF7wmAIuxfKcye6ia/KXDgljKmxYICN528xEXbh9Fx7wNqlOX6Q?= =?us-ascii?Q?0Ia2U4aKdqzthci0vjB4ZezYhQO1EFUFhxgYZFq+TjfrZfkH34FdRHiUmRX7?= =?us-ascii?Q?cbiP1RT/x9iFkV7bMcs9E+xQUuLKtBy6tJjocaShQdpDHNV53pVu1ojnrRsd?= =?us-ascii?Q?Pyz1mvdGlSUPWSUvZSmvJNDIAZgt8v73nwXg3GJiYObLV8b4R0vkRcn4D9tT?= =?us-ascii?Q?GJI3B8+rLEsI/MyFIjzUVju6oid/fGIpSHEThndjSKkvHFcdjGSMoBSY/HNi?= =?us-ascii?Q?o3OIsgmNH8fKXM5E5V+ROi0HH0wosxapGA3H1XGNNAxhCWHVcd7wUdzJ9BxY?= =?us-ascii?Q?Ay8SwgIseoslEwjTr9BXj3QQEKHp1DG6UTVSOgaXDkGwM6EfmbNVRJMD3bSS?= =?us-ascii?Q?8LARDYmt3IU7W68UPE8RNx3cpPed8c9IWYPEV9aBxLexllZTJMKIK+/RlTTy?= =?us-ascii?Q?a6ZRAy1BzamL02bwTMatQstWy9J9CylMRvYXzoIGd4nvNtnlzO67ej7sIe8U?= =?us-ascii?Q?/K4dJjUmBeDvzxCOc21qM+sgl7TRCm2s1ZjO+SO6Dn/qMtmuCHrrX7GQMq+2?= =?us-ascii?Q?CXUHLRcEKtt7UVrezsGdqqoPKZavZpMLrQxv8TkaG3rH7WF/ghSwhVWOaXWs?= =?us-ascii?Q?vYo0VqVyokxUk3KoTP/vphQ4BQn0/yWGCVsIgwimnfw+rO6S?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3aea4156-0a37-4111-ae18-08da3b04a521 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2022 08:33:56.2390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WsLep8JGqXzIVrTsLWhUSligGX249HkKG854Y/FKskDzPslUHJtqXWFEwrPVObXDsaeV23sNa+71P7oJgcnt7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2473 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 >=20 > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: >=20 > > From: Peng Fan > > > > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > > only used on X86 for now, so guard it with X86, otherwise build break > > if we use BINMAN_SYMBOLS on i.MX. > > > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > > Signed-off-by: Peng Fan > > --- > > common/spl/spl.c | 8 ++++++-- > > common/spl/spl_ram.c | 4 ++++ > > 2 files changed, 10 insertions(+), 2 deletions(-) >=20 > I think we long term need to figure this out and address it so LTO works.= But > for now can you please guard this with a test on LTO instead, so it's cle= ar > where the problem is? Sorry, I could not get your point about guard with a test on LTO. Actually binman weak symbol will report a warning log if there is no u_boot= _any binman symbol. Since only X86 use it, I guard with X86. Thanks, Peng. >=20 > -- > Tom