From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D226C433EF for ; Sat, 20 Nov 2021 12:11:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A49FA834B0; Sat, 20 Nov 2021 13:11:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="HdzMAyW8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DE1C9834AC; Sat, 20 Nov 2021 13:11:01 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20604.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::604]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62D99834B0 for ; Sat, 20 Nov 2021 13:10:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rh9U0JUq5bjvljD5v+765JFXORQn4xcaJta+mRZ2nrPxMnIePNFC5AntxcMSvsP+Vw2McNWxupqGheIgj5HUAT8r5aDmNe5nyA/MrFXBUDxotHv0vp64rBMnS6V5/ySGDRL75JYT5Jjhx+gcbW80eknNkShNF3yXOKWblZxC+yebho1zSaAkM/SuqlTQw8q9JyQnSGUEnC91rxrRb3iub47S6vQzoip+u/qGId4iD4fFPZHlDTm3Gjr/sG0pjB8rlyJCkGy1hDNIlYLefC/PRwTkR7IDy5FCp8VuNyFBvqZRA3YC3vmKfldnh6jo59FhV2VFTl1NQ3vkeHTcfqjk5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UDuA5QQZIM6zj2OWkpJfn0axjpLDsQFd3H3vbMfbrZg=; b=DWBonSzk+GbhgKuX77xAnMS4lQ+ZUBnt4FvWIeVg3vfjt2YujKrk0554Q2ci8+sLOX1t+8xVI4xETj6j7YgBpaJ2vVpp2pd2QYIZXDLaEkXH19seq/xeNgJXqEjqlQKRlX/6jJoEDhDvxT9GLY8AeHnI4f7ibECdpdv6ttlHTJQ7uLAF/BNHVVUdE08vYHWcWadcOJOGRu31xykzmUuNbS90i88jlV5/j3WMFYajrD6F/LODhtMtbzoumdTHEZ9R8onL5O19mSKBiI/N0CadDC66TPFTNFmd0Um3rSsjm2edkUm5fe7cMXZWUvChlsRt2LKh3ZcxG0w1EMYjsc/LMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UDuA5QQZIM6zj2OWkpJfn0axjpLDsQFd3H3vbMfbrZg=; b=HdzMAyW8yohqrFulf9gqSvPlMIy/ftghLFaSIgAS3RliO31tvVYgYLieLbL7ys20onOjEeZtgwDnUCEFayKqc6DaW44T0qhU+MC+9sByfDfDMcNWDtT0c2XSD6/LSGtp9igVqXWwsbE/RT2eHsGuYkjvKuxLbQUesvtFEaUnP/0= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU2PR04MB8967.eurprd04.prod.outlook.com (2603:10a6:10:2e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Sat, 20 Nov 2021 12:10:54 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::82e:6ad2:dd1d:df43]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::82e:6ad2:dd1d:df43%9]) with mapi id 15.20.4669.016; Sat, 20 Nov 2021 12:10:54 +0000 From: "Peng Fan (OSS)" To: Peng Fan , "lukma@denx.de" , "sjg@chromium.org" , "trini@konsulko.com" , "seanga2@gmail.com" CC: "u-boot@lists.denx.de" Subject: RE: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Thread-Topic: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults Thread-Index: AQHXzF8XXEr0anZ/PESPWu0zuNgtNKwMdm0A Date: Sat, 20 Nov 2021 12:10:54 +0000 Message-ID: References: <20211029012801.15193-1-peng.fan@oss.nxp.com> In-Reply-To: <20211029012801.15193-1-peng.fan@oss.nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94cae2c9-924c-4b1c-89b4-08d9ac1ecd8d x-ms-traffictypediagnostic: DU2PR04MB8967: x-ms-exchange-sharedmailbox-routingagent-processed: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ooUc5TpcBzCkKQP+VhvU1upYxJPjCwL0yvcd1EqPz5I4PgGvFj32yZhY7qDVx0tky7wQCJ/BSPRWksXKGbIhxPmL9CvrTra7Lj90jTiPzeYCX57JbX3Pho0Q+Of5u2mv7EJWxplL0mnH3v4Hq0rVdPvVp/j/SZGrenxfw6hZZdREVi4qloNhyZvKra4SxpLKFTBkPau2uWWByxh05WdTseXgdKzYeaeyBRC6wVB9fkTAtaig1902X+87/kkldBQbZuoahFIynxPWlsU1iRIepu+Q+V8GGSNw7D0ZF8+gayUUwp415l4amR7GUb4LBQeDSq25U1+Gtg5t/kmbkPBrezskB6KasafRdj8/k/Rh+U0tQc3o+9Ol7zojoCqFlZKM2zC8SZC6NHtzZ5yczeq6mpV9TKTwZ53dJy4CnLLpaDqqFYPtzXDcKyovnioWfa8RFIp7DtqTj0e7owwvxHXPK2kj3qaB/wEryDQbK51Yeic6fohrzWm7OyHqFEA6Xw7FyWXjVjdPc1KvbSKkyphnEHWcf84mUF01aKA9ynZdJ6INaf0GrTPhYcwilud6dwb8SKqgDsRkoBxm2ufZ1DNNQuAxy5dRnduaf/wuLY/+kNlSkSIldB+Z3Q4YldKfGM35XCt7ZZfEd12PYVRfodq12ufnnHUQDYU7HmxDSnwQSEk9eNh3pSkRjIcDt2gIa7GAD0vmTlhjQILKN8fuJO7R4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(110136005)(316002)(8676002)(9686003)(38100700002)(55016002)(38070700005)(33656002)(186003)(83380400001)(5660300002)(122000001)(86362001)(66946007)(66476007)(2906002)(76116006)(4326008)(64756008)(52536014)(508600001)(26005)(7696005)(66556008)(8936002)(71200400001)(66446008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z/iuGXFHsrtA+XAtjFt1da+RITatpZlBQyNmKDvBU6NhmsaFPszAa/hTdpNv?= =?us-ascii?Q?ebiGlOI+nn91RAvg7F9SqCJ7FL8kQtx+pcJry3uBxzUtqty8xgg1005aQ3pG?= =?us-ascii?Q?UD/ERDasWI7x+8Ws85ivn/yJhqJJ8D/JWXhaGr1eYpyCPOA7MaqYaQShqZgX?= =?us-ascii?Q?JK7VRVz/24McdxTzLafxVEUBP4n88Ezt+R1LS9bEcrXb69yHKqfZh0X6PwyU?= =?us-ascii?Q?eDI5cBzqmNTwCyaH9+jAsh5DItDWWmcuA5aIffWzwa+jubqm0pl+3p2fJZbw?= =?us-ascii?Q?70Stg2qkFRUkgc3TYnI+xhM0vnXtMDzeeNEmEMticMuwuApBc6ZfUo8QLDDt?= =?us-ascii?Q?VO6NeqIJ6QmkreQg4NtgpWFxniSZfhI0ezPJN6ZIPwaBCq5+yWPpCmN24j62?= =?us-ascii?Q?MAtCQXQ62Iluf9fVXZkSegDAWGtSKnqVRot3AtUknOePAbN/mIk+250LeIeD?= =?us-ascii?Q?bE5d6FQWd0yRrVaoa1xF8qhhDggR3jTf+SVn4JmjOlLsi+UjztO2uqafv2mW?= =?us-ascii?Q?dikn6XqhmdYipqUF5xQmN0FBePfOp+ZNXDZd/1gh0SFpJBpULDVIwYjIb2du?= =?us-ascii?Q?TCr9wdNvAt++eFpPMPIR7jrcws329V3LGgAmYN34Q5hfp6jCwIk4qC2vSJTu?= =?us-ascii?Q?/GHHZqdwCoWbc9NznMdN0ufdLkCAWuyvWtTCPzUrKnHoQZvmnj2Jbb62PCSA?= =?us-ascii?Q?UQRtkz7ZY2YjyhyEAGaeuH/OH1cq0NWTaQ+xPB3w1PaOi0tw3+TGK4zL0PbS?= =?us-ascii?Q?yQICOfGoirY9atprWBLZW+0n59oe84VUWHMF4TMFpxv25bExqpGs4XJJ5KzF?= =?us-ascii?Q?ddiwVA1rEmAFwQIuUcBWiaf0UQT5h2q4fw8YRD92lhX3PIxMtGj4HlKe0lnH?= =?us-ascii?Q?BDdpsFwIwQMvaRpb9/dWQFVkVUv20zSulHymUTcUD1FXcUzamg/dAyRo6Ezq?= =?us-ascii?Q?LX0l+eLiV8vGTD4+KC89v6AMtieUrrnXM5gWRzBIVGCwmUVpZLJDOk0dRvpZ?= =?us-ascii?Q?uU42KapdlxKxuBGIDE4R7NUif2jPZ74NRQ9Kpmj35k6G85V51dz+rC/jM/vV?= =?us-ascii?Q?nddz+fzIHU6UFZZd6Z2ndeMpKkw0C+bjLbVpVjGQIs3sZcFgKIkkmMZMzFYh?= =?us-ascii?Q?jobgAJTmOL/W6KAZbMdAodKMzpTPmbWrnyjJw5tIYH2fKtY0YRoy4ZHPG3lu?= =?us-ascii?Q?cgfmZI+IC+89kZIg83T12M+wq25xzLqi2KkEN9Szlp3w3cQiY/R9bfAMB0ky?= =?us-ascii?Q?ZHqyJKmHItOUDf2yvxYi3VaWyUo0dyBt5brVFJMM7V7dRsb2bDIb/gIFc5jv?= =?us-ascii?Q?NQZ4tuQGAl9HBk/hvakZeXZUOWmOVyHzaRfXxQiZ5rpTnGXppaizbT2CSM9Q?= =?us-ascii?Q?lBuBSAHIGS5/XfKz966k621zVnqXuM8baquocDjF60T1RRlSvYdKBt7zvjDF?= =?us-ascii?Q?q92TmVQqvA28S4AfBbDTpeCxLuwhbuNfKMkxuo3KmKD3zMVetJGfJIG07ziE?= =?us-ascii?Q?kI9vcQBJzAcS9Nmv4HDD3yc1Esm41DQwMXvrXPTccL+S5UOEPsYXUuSAs5Rl?= =?us-ascii?Q?aXJv8I6MiOm5U6Sgh1G3S2eZrbjfh3VGu94h3+mHtxdR07CK3yPtjMPLwSa7?= =?us-ascii?Q?AV3ZwHR68QVDuM79owc8yMo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94cae2c9-924c-4b1c-89b4-08d9ac1ecd8d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2021 12:10:54.5604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sf4f3C2Cwu7qPdWLvkP4TRKrlXrZUfqmV+tQGxQVmca/vMJPa4DivLhWTVYMzcPgGQcAZS8Q/bB2H80NTXRb+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8967 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > Subject: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults >=20 > From: Peng Fan >=20 > Current code has a force clk_set_defaults in multiple stages, U-Boot reus= e the > same device tree and Linux Kernel device tree, but we not register all th= e clks > as Linux Kernel, so clk_set_defaults will fail and cause the clk provider > registeration fail. >=20 > So introduce a new property to ignore the default settings which could be > used by any node that wanna ignore default settings. >=20 > Reviewed-by: Simon Glass > Signed-off-by: Peng Fan > --- >=20 > V2: > Add R-b tag > Tom, Simon > After a thought, I think still put it as a u-boot thing. assigned-cloc= k-x is > actually Linux specific, however I could not add the new property to L= inux, > because we are supporting SystemReady-IR, we need the > assigned-clock-x property > in linux working and ignore it in U-Boot. Any more thoughts? Thanks, Peng. >=20 > doc/device-tree-bindings/device.txt | 3 +++ > drivers/clk/clk-uclass.c | 3 +++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/doc/device-tree-bindings/device.txt > b/doc/device-tree-bindings/device.txt > index 73ce2a3b5b..fe34ced268 100644 > --- a/doc/device-tree-bindings/device.txt > +++ b/doc/device-tree-bindings/device.txt > @@ -28,6 +28,9 @@ the acpi,compatible property. > Linux will only load the driver if the device can be detected (e.g. = on I2C > bus). Note that this is an out-of-tree Linux feature. >=20 > +Common device bindings that could be shared listed below: > + - u-boot,ignore-clk-defaults : ignore the assigned-clock-parents > + and assigned-clock-rates for a device that has the property. >=20 > Example > ------- > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index > 493018b33e..6bf3179e7b 100644 > --- a/drivers/clk/clk-uclass.c > +++ b/drivers/clk/clk-uclass.c > @@ -376,6 +376,9 @@ int clk_set_defaults(struct udevice *dev, enum > clk_defaults_stage stage) > if (!dev_has_ofnode(dev)) > return 0; >=20 > + if (ofnode_get_property(dev_ofnode(dev), "u-boot,ignore-clk-defaults", > NULL)) > + return 0; > + > /* > * To avoid setting defaults twice, don't set them before relocation. > * However, still set them for SPL. And still set them if explicitly > -- > 2.30.0