From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798CDC433F5 for ; Fri, 24 Sep 2021 20:27:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87BF5611C8 for ; Fri, 24 Sep 2021 20:27:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 87BF5611C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 209AD832C1; Fri, 24 Sep 2021 22:27:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="gcqd4XsL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 55D2B83485; Fri, 24 Sep 2021 22:27:50 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::61d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F0CD8326F for ; Fri, 24 Sep 2021 22:27:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wasim.khan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J4+BK1Ghq78oMfaH4TAF9DdM+gqVMKlHpNZuc26vTYotE1IWWBfSMZ0f5hMeF2Y1kR20W+XFVe6WFa6i20RN2DAVmtm5SH89ae9vw1HNcvevmofE9WxE3kZWg4IWsSzVPtUsz/VsoritaPrAQUHkAJtGuzkccDk4+PUdNDdZFGHyZz9Y73MI65IWD93cZpSOVD0oV10RMyrbnXUFeSYLdcmEURcp1e2JKnC2eOHpbmntVovsCjAmZNJXdXD6q7YGtiDyqCy21mTfs0nhHjhMGrrBpkiAoFmT1aS20fjZkkw9VN6DunPwmyyyKApgIEj8WQ5uSvbZXzM+GpBp7GBd/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zBpdvpQ5JMRlkJA5AnI8As/GF0roJyR9uGMxO6F/6t0=; b=fNKVw7qNa7MexEsVyAI4SeAgMwM0rWOkNIGm6dHQGQ2SSyoDfJbCN4uzEpajZmgEh2Av+TETryM3yD50xBlLgVurlW30PGq3tKQxVwMQFv5lw2HlqwKH08ejlDuySuKyofyAIyQSmTZPL70kLgtrpsjlpNvCez3a4aFtX/D+jNBdIvbUD5nLBTnk4mFWmPudTyL73DFfS9Ou4cD+zIA7XH2GWGHerz87B1z0Brb9xXXVSkvpZ+RQ1d3Mf6dOsM+qGK8d9YnzY/6p8/NuSk4mf2B0YjCg5AeBIR7DctNLUSv3sPMEetGsID9jj234BWCKNQU7TWl84seZqrR+gaQ0xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBpdvpQ5JMRlkJA5AnI8As/GF0roJyR9uGMxO6F/6t0=; b=gcqd4XsLx+Prqyd67h9S21CGXqLXAY/sR/IcftQqI/V58loNOJ6WhRsyaphmxlpsu8Cn8BTyDuk1Fkvia7fPWjG1UpjcH0mF0csE/bwc9IphL/PoUE0ZIurutoCQdw9nrJBMPqb+QOXIWrElZiJnWhYRQP+psH3GDrEqK7WXMP8= Received: from DU2PR04MB8726.eurprd04.prod.outlook.com (2603:10a6:10:2dd::9) by DB9PR04MB8462.eurprd04.prod.outlook.com (2603:10a6:10:2be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Fri, 24 Sep 2021 20:27:43 +0000 Received: from DU2PR04MB8726.eurprd04.prod.outlook.com ([fe80::c4c0:dc25:bf03:589c]) by DU2PR04MB8726.eurprd04.prod.outlook.com ([fe80::c4c0:dc25:bf03:589c%5]) with mapi id 15.20.4544.018; Fri, 24 Sep 2021 20:27:43 +0000 From: "Wasim Khan (OSS)" To: Tom Rini , "Wasim Khan (OSS)" CC: Priyanka Jain , Varun Sethi , "u-boot@lists.denx.de" Subject: RE: [PATCH] board/freescale/vid : move platform specific definitions Thread-Topic: [PATCH] board/freescale/vid : move platform specific definitions Thread-Index: AQHXrvR7XwLKWn3PyE6mM408Ap8C7quukESAgARHe4CAAD/0AIAAja5g Date: Fri, 24 Sep 2021 20:27:43 +0000 Message-ID: References: <20210921142457.3485758-1-wasim.khan@oss.nxp.com> <20210921144349.GF8579@bill-the-cat> <20210924115336.GA31748@bill-the-cat> In-Reply-To: <20210924115336.GA31748@bill-the-cat> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=oss.nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e4dda9cb-8810-429c-dcb1-08d97f99c3a1 x-ms-traffictypediagnostic: DB9PR04MB8462: x-ms-exchange-sharedmailbox-routingagent-processed: True x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OzRpM5cq6clTYIWp6m3HToF5o2ZGstAwei6JBjGAsNXok7GuecK9QbmxElNpsy4lRdxIicPZuOPbMXS8HXllJsAgBkNFmTqsgPWh7KXFhn2I+GGRY1i/0jw+iPzmd3hMEfcfVc6HUpflAgRlXQPkDOibnpF4hHQhvi2fk4LK8WHyYihkWJDVkHsjNSimeSHkM7uqfJxc7ov3hZmSv9H04UI1G/H+y/LlVw+5inyX62/4wOAPRwXHo8p8KQlyeJPU+ZHT3KtsxqANXgy/MWpLStBaoqPnq2orcRGWysCLHMV7bDiE+YaHEHXeFuZjKhEg6Pg6Yj1Mw7eDvBU36eyqtwz0s4RpemzabnA0uIx4KGvT0GnRP+u3l/AiqWubSZGlr0szOl1h2pkV98gnGwCYcMzhAFk5KgKhoS0Mhqok2Qub1+0qBMy2dawL9TXfK0V6kUGWxn4vBdw+9Y7C0XK6NcUif+n4pfiemz8WJn2yEi2iwINbTPns1VhXGKvUvMEWmuOUuNcyivvmckPYGLdlNBX8DFDRuxh/or+V4psk3LAD6t1ftY6ck8XgG/l6BguQbi85E94gXPAjzjt4rxI5kd3ZXiSP8fRomQR54S0fXydoQueVfD8f0HO7xxvxjpuhGijmvaQT3MVUQgAcFdgiGsFadTr+xJLqYOqPlle59VBN+WlWdWpCsC16+aQOAcD1VHDP1HTm4lx8qwrEZ2liqA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8726.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(66556008)(26005)(66476007)(66446008)(76116006)(71200400001)(66946007)(8676002)(54906003)(2906002)(508600001)(7696005)(186003)(83380400001)(38070700005)(33656002)(110136005)(5660300002)(86362001)(6506007)(4326008)(122000001)(38100700002)(9686003)(8936002)(316002)(52536014)(53546011)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9CEmEHREupeK8b6U8wLbmygi7YrrfTOa8FRSvEPOdMiUYc13R+N7weYrBhoy?= =?us-ascii?Q?mR2iKIT9dLukqfRd+VPIfTguHYK7BLPWVbsNRqs7WLgt7jnxmD6Wcpmow5R7?= =?us-ascii?Q?1Rn/+ZIYFyngGWkTG+YzBSLjMyxdobMYJqwYAIBj/DnSUkfd96OXvnS6A6AX?= =?us-ascii?Q?5TPVHErbua1dJAvJtFZopIrTE0uqMeMMV8XnKaKHSwLEC18POclWGDfATAcb?= =?us-ascii?Q?16F0OARaBQTmiZiTn1jOpvnqWp5eWnNLzDPnPqnJdWs2FYvqCXuH1iMWG3zs?= =?us-ascii?Q?ArcbfMAE/vYv//YgpQUBRhpKNcUVEYkxeepl96wwgiJaxtMy/nZXGneZiPhm?= =?us-ascii?Q?NLr1f6mIAq3GpRD763WGE9XWdzyO8cVcVaEHGrOkZNCP5Recdj//26/rWU3o?= =?us-ascii?Q?7itG7TGInULloeM/1+xUnTGO1dMQ+/p0ynGeq31mUx5gJeI9iAuylY9DcdCk?= =?us-ascii?Q?rhzRBPUqxa4pex9p91ztdScBHDUX8JZ+PcTYiAvQqrxzme0XN13zeTjkcznL?= =?us-ascii?Q?wdW2QAcodofKOa8hV1mGDZtCdqePmZE98b1n523rELwtLsNqoMjweRNP+AyX?= =?us-ascii?Q?Vba8UZxNMSBDqdMNsYXvXroj8w22USHM2QTA6jkVYQXmJmRmu1KGTm7xHa6Q?= =?us-ascii?Q?yHch1UTOyX85GeLXb6H6zEyHCeyE+LIr7rwvQMZDaeJh0uh4nbG58v3qxtgF?= =?us-ascii?Q?cDCg9G7KGnBAOpmL2YmP0WjxiYLbTMEJZOomvrm6n5LfY+5xIlIKHClqVsyA?= =?us-ascii?Q?bLwkYPqq6dI7yjTKIg7WeOQslxtaMu5givkPMn0IoMbuaA8g6DNkrFte3xuG?= =?us-ascii?Q?R8rWZpPlyif0DFTe7ZtGasdezaCzgVLIAJNrcO9ibPtGM+CPy62u6O2mNpPV?= =?us-ascii?Q?kGHCJgBpOs5BRhcADG+Omd024t4htn4nOHY7mdDqPmUzJjFuMYAZeGNBvbU7?= =?us-ascii?Q?7rZ73FrNoLzx7FbzhgiLFmUKVfaFUSGX+L1wEWwOxtH1rztFl9B9APHmKdb3?= =?us-ascii?Q?n5FeuupIonqXWhBU3rXnBPl7PW6BlGSJ3AH9I/Fs50vVbYo5lIkUF7GAt0R3?= =?us-ascii?Q?vUtPQA9xA4ACMRJo159HeAaxLAOmnmBkjT731/fD6AZmbFlpDj+KMAbfMIKU?= =?us-ascii?Q?4ufiSD2Bhw2DqmEU7FBl2O2RCGvBqf6XgZhbiRSGiWm37v7wtdVOaxwLzuZC?= =?us-ascii?Q?V349H+Q5kIz+ljQ0bV90mvJWjFDTjh53YwwPYkO7Uh3tV5IlL3835xOs9tGH?= =?us-ascii?Q?tUG9CB3STvPU5G9iYKNXwLvYHnQc0GsN+7rCuVDMaE6xlsBQ/veSlxLn/M0l?= =?us-ascii?Q?saukTqgGBEzaiuW6/E1mQGU7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8726.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4dda9cb-8810-429c-dcb1-08d97f99c3a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Sep 2021 20:27:43.6871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7Emv1y5DITOJbChtfA5Eg+FaFOfVGveFiggclFP6ZoNAEZqVsuCADUm/2BRAQel0Sk6l9S/AKf2/ZgC2AawG3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8462 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, > -----Original Message----- > From: U-Boot On Behalf Of Tom Rini > Sent: Friday, September 24, 2021 5:24 PM > To: Wasim Khan (OSS) > Cc: Priyanka Jain ; Varun Sethi ;= u- > boot@lists.denx.de > Subject: Re: [PATCH] board/freescale/vid : move platform specific definit= ions >=20 > On Fri, Sep 24, 2021 at 08:36:45AM +0000, Wasim Khan (OSS) wrote: > > Hi Tom, > > > > > -----Original Message----- > > > From: Tom Rini > > > Sent: Tuesday, September 21, 2021 8:14 PM > > > To: Wasim Khan (OSS) > > > Cc: Priyanka Jain ; Varun Sethi > > > ; u- boot@lists.denx.de; Wasim Khan > > > > > > Subject: Re: [PATCH] board/freescale/vid : move platform specific > > > definitions > > > > > > On Tue, Sep 21, 2021 at 04:24:57PM +0200, Wasim Khan wrote: > > > > > > > From: Wasim Khan > > > > > > > > VID is a common driver. Move platform specific definitions to > > > > platform specific header files > > > > > > > > Signed-off-by: Wasim Khan > > > > --- > > > > board/freescale/common/vid.h | 10 ---------- > > > > include/configs/lx2160a_common.h | 7 +++++++ > > > > 2 files changed, 7 insertions(+), 10 deletions(-) > > > > > > NAK. Things need to move out of include/configs/ and not in to > > > them, please find another common header file to use. > > > > > > -- > > > Tom > > > > Thank you so much for review. > > Header files 'include/configs/' are auto picked for platform we are usi= ng. > > I find it useful especially for common drivers like VID to auto pick re= quired > values for underneath platform from > 'include/configs/.h' and we don't need changes > in common driver. > > > > (arch/Kconfig) > > config SYS_CONFIG_NAME > > string > > help > > This option should contain the base name of board header file= . > > The header file include/configs/.h > > should be included from include/config.h. > > > > > > (Same is recommended for add/remove boards: doc/README.kconfig) > > Define CONFIG_SYS_CONFIG_NAME=3D"target" to include > > include/configs/.h > > > > > > Currently all NXP platforms (except LX2 series) are using > CONFIG_SYS_CONFIG_NAME to include platform specific header file for VID > driver. I extended the support for LX2 and because the changes are common= for > lx2160ardb, lx2160aqds and lx2162aqds , I added them to lx2160a_common.h. > > > > Do you want me to move changes from ' include/configs/lx2160a_common.h' > to ' include/configs/lx2160ardb.h', ' include/configs/lx2160aqds.h' and = ' > include/configs/lx2162aqds.h' ? > > > > Or you want me to avoid adding anything to > 'include/configs/.h ' files ? Is there any reason= to > do so ? >=20 > I want you to find a place outside of include/config/ for these values to= reside, > yes. The long term goal of moving everything to Kconfig means that we wi= ll not > have include/config/ headers anymore. Further, values like this which ar= e not > actually user-configurable should neither be CONFIG-prefixed (which these= are > not, good!) nor reside in include/config/ at all. There should be some > appropriate header perhaps under arch/arm/include/asm/arch-fsl-layerscape= / > to put these values. > And if they need to be shared a bit wider, a fsl-layerscape-common or sim= ilar > directory could be used (similar to arch/arm/include/asm/ti-common/). Do= es > this make sense? Thanks. >=20 > -- > Tom Thanks for explaining it to me.=20 Because VID driver is applicable for arm/x86 platforms, I need to check wha= t would be best place for the header file , but I understood your point.=20 Thanks, Wasim =20