From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E5EC433E2 for ; Wed, 2 Sep 2020 09:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F62E2071B for ; Wed, 2 Sep 2020 09:09:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="OCtM6on/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbgIBJJk (ORCPT ); Wed, 2 Sep 2020 05:09:40 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:57005 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgIBJJU (ORCPT ); Wed, 2 Sep 2020 05:09:20 -0400 Date: Wed, 02 Sep 2020 09:09:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1599037758; bh=tWZLjcjpso7hjA2WIHTYXpXERR7Rr72qonBHENyVUic=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=OCtM6on/gZ0ul9beiqs+h6tfxzqMwNoEgh0KOMhiK4wJgFngrAoHuauJBUvPBXfZR ssM3+Fp3Hl4kO/KU6fqcc5xI00srJ+T7mYBlW7KPt6coX3GdGPLb7XoKuWotg6liAn UWLMEyEo8Rd3g7rl+56KDPfy4auvXuOm9rLI8Av8jNi3V2exqaGNVmdasJjMG0s42j vz+NH/qSj4XBMGp6eLJ/6WTNrKjW62+OBXwVw8Z2yyahKMRhV+TsoAJsvIlPBEPCh3 3HdEXAjZVzWHEZLX91ti8HnEcZJSmOwJ64n4ajA/mHAa2PmFUwd3d+IKIROMUJS5zm K+YTYFZMtCjaQ== To: Daniel Vetter From: Simon Ser Cc: =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= , Haneen Mohammed , Rodrigo Siqueira , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Melissa Wen , Sidong Yang Reply-To: Simon Ser Subject: Re: [PATCH] drm/vkms: add support for gamma_set interface Message-ID: In-Reply-To: <20200901132656.GD2352366@phenom.ffwll.local> References: <20200829140647.7626-1-realwakka@gmail.com> <20200831133858.GA9280@realwakka> <20200831134852.GY6112@intel.com> <20200901132656.GD2352366@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrot= e: > On Tue, Sep 01, 2020 at 08:57:37AM +0000, Simon Ser wrote: > > > On Monday, August 31, 2020 3:48 PM, Ville Syrj=C3=A4l=C3=A4 ville.syrja= la@linux.intel.com wrote: > > > > > > > It doesn't seem like this IGT test's goal is to exercise support = for > > > > > gamma LUTs. Does the test just tries to reset the gamma LUT to li= near? > > > > > If so, I think the IGT test should be fixed to ignore "I don't su= pport > > > > > gamma" errors. > > > > > > > > It seems like that IGT test pixel-format is to make gamma lut like = below. > > > > for (i =3D 0; i < lut_size; i++) > > > > lut[i] =3D (i * 0xffff / (lut_size - 1)) & mask; > > > > And set this table to drm driver. and test begins. It's the test ab= out pixel > > > > format. I think you're right. It's not about gamma lut. > > > > > > The point of the gamma LUT stuff in the pixel format test is to throw > > > away a bunch of the lsbs so that the test passes when the result is > > > "close enough" to the 8bpc RGB reference image. Without it we would > > > never get a crc match when testing non-8bpc or YCbCr formats. > > > > OK, that makes sense. Would it be sensible to: > > > > - Don't set gamma if the pixel format being tested is 8bpc > > Hm not sure what 8bpc format you mean here, because we have C8 (needs > gamma table or doesn't work) and the 8b greyscale one with the R8 one. If > you ask for legacy 8bpc you get C8. Why do we need a gamma LUT for C8 and R8? There shouldn't be any precision loss, right? > > - Make the test skip if the pixel format is >8bpc and gamma isn't > > supported > > > > Yeah the test should skip if gamma isn't there. > -Daniel > > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342C5C433E2 for ; Wed, 2 Sep 2020 09:09:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D6332071B for ; Wed, 2 Sep 2020 09:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="OCtM6on/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D6332071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52B546E155; Wed, 2 Sep 2020 09:09:22 +0000 (UTC) Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by gabe.freedesktop.org (Postfix) with ESMTPS id 606616E155 for ; Wed, 2 Sep 2020 09:09:20 +0000 (UTC) Date: Wed, 02 Sep 2020 09:09:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1599037758; bh=tWZLjcjpso7hjA2WIHTYXpXERR7Rr72qonBHENyVUic=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=OCtM6on/gZ0ul9beiqs+h6tfxzqMwNoEgh0KOMhiK4wJgFngrAoHuauJBUvPBXfZR ssM3+Fp3Hl4kO/KU6fqcc5xI00srJ+T7mYBlW7KPt6coX3GdGPLb7XoKuWotg6liAn UWLMEyEo8Rd3g7rl+56KDPfy4auvXuOm9rLI8Av8jNi3V2exqaGNVmdasJjMG0s42j vz+NH/qSj4XBMGp6eLJ/6WTNrKjW62+OBXwVw8Z2yyahKMRhV+TsoAJsvIlPBEPCh3 3HdEXAjZVzWHEZLX91ti8HnEcZJSmOwJ64n4ajA/mHAa2PmFUwd3d+IKIROMUJS5zm K+YTYFZMtCjaQ== To: Daniel Vetter From: Simon Ser Subject: Re: [PATCH] drm/vkms: add support for gamma_set interface Message-ID: In-Reply-To: <20200901132656.GD2352366@phenom.ffwll.local> References: <20200829140647.7626-1-realwakka@gmail.com> <20200831133858.GA9280@realwakka> <20200831134852.GY6112@intel.com> <20200901132656.GD2352366@phenom.ffwll.local> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: Haneen Mohammed , Rodrigo Siqueira , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Melissa Wen , Sidong Yang Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlc2RheSwgU2VwdGVtYmVyIDEsIDIwMjAgMzoyNiBQTSwgRGFuaWVsIFZldHRlciA8ZGFu aWVsQGZmd2xsLmNoPiB3cm90ZToKCj4gT24gVHVlLCBTZXAgMDEsIDIwMjAgYXQgMDg6NTc6MzdB TSArMDAwMCwgU2ltb24gU2VyIHdyb3RlOgo+Cj4gPiBPbiBNb25kYXksIEF1Z3VzdCAzMSwgMjAy MCAzOjQ4IFBNLCBWaWxsZSBTeXJqw6Rsw6QgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPgo+ID4gPiA+ID4gSXQgZG9lc24ndCBzZWVtIGxpa2UgdGhpcyBJR1QgdGVzdCdz IGdvYWwgaXMgdG8gZXhlcmNpc2Ugc3VwcG9ydCBmb3IKPiA+ID4gPiA+IGdhbW1hIExVVHMuIERv ZXMgdGhlIHRlc3QganVzdCB0cmllcyB0byByZXNldCB0aGUgZ2FtbWEgTFVUIHRvIGxpbmVhcj8K PiA+ID4gPiA+IElmIHNvLCBJIHRoaW5rIHRoZSBJR1QgdGVzdCBzaG91bGQgYmUgZml4ZWQgdG8g aWdub3JlICJJIGRvbid0IHN1cHBvcnQKPiA+ID4gPiA+IGdhbW1hIiBlcnJvcnMuCj4gPiA+ID4K PiA+ID4gPiBJdCBzZWVtcyBsaWtlIHRoYXQgSUdUIHRlc3QgcGl4ZWwtZm9ybWF0IGlzIHRvIG1h a2UgZ2FtbWEgbHV0IGxpa2UgYmVsb3cuCj4gPiA+ID4gZm9yIChpID0gMDsgaSA8IGx1dF9zaXpl OyBpKyspCj4gPiA+ID4gbHV0W2ldID0gKGkgKiAweGZmZmYgLyAobHV0X3NpemUgLSAxKSkgJiBt YXNrOwo+ID4gPiA+IEFuZCBzZXQgdGhpcyB0YWJsZSB0byBkcm0gZHJpdmVyLiBhbmQgdGVzdCBi ZWdpbnMuIEl0J3MgdGhlIHRlc3QgYWJvdXQgcGl4ZWwKPiA+ID4gPiBmb3JtYXQuIEkgdGhpbmsg eW91J3JlIHJpZ2h0LiBJdCdzIG5vdCBhYm91dCBnYW1tYSBsdXQuCj4gPiA+Cj4gPiA+IFRoZSBw b2ludCBvZiB0aGUgZ2FtbWEgTFVUIHN0dWZmIGluIHRoZSBwaXhlbCBmb3JtYXQgdGVzdCBpcyB0 byB0aHJvdwo+ID4gPiBhd2F5IGEgYnVuY2ggb2YgdGhlIGxzYnMgc28gdGhhdCB0aGUgdGVzdCBw YXNzZXMgd2hlbiB0aGUgcmVzdWx0IGlzCj4gPiA+ICJjbG9zZSBlbm91Z2giIHRvIHRoZSA4YnBj IFJHQiByZWZlcmVuY2UgaW1hZ2UuIFdpdGhvdXQgaXQgd2Ugd291bGQKPiA+ID4gbmV2ZXIgZ2V0 IGEgY3JjIG1hdGNoIHdoZW4gdGVzdGluZyBub24tOGJwYyBvciBZQ2JDciBmb3JtYXRzLgo+ID4K PiA+IE9LLCB0aGF0IG1ha2VzIHNlbnNlLiBXb3VsZCBpdCBiZSBzZW5zaWJsZSB0bzoKPiA+Cj4g PiAtICAgRG9uJ3Qgc2V0IGdhbW1hIGlmIHRoZSBwaXhlbCBmb3JtYXQgYmVpbmcgdGVzdGVkIGlz IDhicGMKPgo+IEhtIG5vdCBzdXJlIHdoYXQgOGJwYyBmb3JtYXQgeW91IG1lYW4gaGVyZSwgYmVj YXVzZSB3ZSBoYXZlIEM4IChuZWVkcwo+IGdhbW1hIHRhYmxlIG9yIGRvZXNuJ3Qgd29yaykgYW5k IHRoZSA4YiBncmV5c2NhbGUgb25lIHdpdGggdGhlIFI4IG9uZS4gSWYKPiB5b3UgYXNrIGZvciBs ZWdhY3kgOGJwYyB5b3UgZ2V0IEM4LgoKV2h5IGRvIHdlIG5lZWQgYSBnYW1tYSBMVVQgZm9yIEM4 IGFuZCBSOD8gVGhlcmUgc2hvdWxkbid0IGJlIGFueQpwcmVjaXNpb24gbG9zcywgcmlnaHQ/Cgo+ ID4gLSAgIE1ha2UgdGhlIHRlc3Qgc2tpcCBpZiB0aGUgcGl4ZWwgZm9ybWF0IGlzID44YnBjIGFu ZCBnYW1tYSBpc24ndAo+ID4gICAgIHN1cHBvcnRlZAo+ID4KPgo+IFllYWggdGhlIHRlc3Qgc2hv dWxkIHNraXAgaWYgZ2FtbWEgaXNuJ3QgdGhlcmUuCj4gLURhbmllbAo+Cj4gPiBkcmktZGV2ZWwg bWFpbGluZyBsaXN0Cj4gPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+Cj4g LS0KPgo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=