RE: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device registration

["G, Manjunath Kondaiah" <manjugk@ti.com>]

Hi,

> -----Original Message-----
> From: Balbi, Felipe 
> Sent: Wednesday, September 15, 2010 12:41 PM
> To: G, Manjunath Kondaiah
> Cc: Balbi, Felipe; Kevin Hilman; linux-omap@vger.kernel.org; 
> Cousson, Benoit; Shilimkar, Santosh
> Subject: Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device 
> registration
> 
> Hi,
> 
> On Tue, Sep 14, 2010 at 09:11:26AM -0500, G, Manjunath Kondaiah wrote:
> >There are several places in kernel code (ex:
> >tools/perf/util/include/linux/bitops.h:static __always_inline int 
> >test_bit(unsigned int nr, const unsigned long *addr)) which 
> are using 
> >__always_inline attribute to make sure functions are inlined.
> 
> those are special cases. Generally, compiler is much better 
> than humans for choosing what should be inlined or not.
> 
> >Ok, Agreed.  We can have inline functions and expanding all 
> macros in 
> >mach-omap dma driver code.
> >However, there is common dma driver(in plat-omap) which has code for 
> >both omap1 and omap2plus which uses this macro.
> 
> well, that can be patched, right ?

In that case, the dma_read/dma_write macros will be splitted into:

static inline void omap1_dma_write(...);
static inline void omap2_dma_write(...);
static inline u32 omap1_dma_read(...);
static inline u32 omap2_dma_read(...);

i.e., Two macro definitions will expand into four internal functions.

-Manjunath