From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v7 0/8] add sample ptp slave application
Date: Fri, 13 Nov 2015 16:38:09 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C85861F@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <2862850.gOUeStJOPQ@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 13, 2015 4:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; konstatin.ananyev@intel.com
> Subject: Re: [PATCH v7 0/8] add sample ptp slave application
>
> 2015-11-13 16:09, Pablo de Lara:
> > V6->v7:
> > - Simplified common functionality for timecounters and make it more
> generic.
>
> So you chose to drop the read() callback?
> I think it's better. What was the benefit of having it?
Yes, I looked at the structure and functions differently,
with the intention of making them more independent of the IEEE1588 code,
so I removed all references to it (the read() function needed an argument with the device information).
It was just another approach, but if I wanted to take that out,
I had to change slightly the input parameters of the functions,
so now they accept an external read (cleaner indeed).
Thanks for the comments.
Pablo
next prev parent reply other threads:[~2015-11-13 16:38 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 15:20 [PATCH 0/3] add sample ptp slave application Daniel Mrzyglod
2015-10-02 15:20 ` [PATCH 1/3] ethdev: add additional ieee1588 support functions Daniel Mrzyglod
2015-10-02 15:20 ` [PATCH 2/3] ixgbe: " Daniel Mrzyglod
2015-10-02 15:20 ` [PATCH 3/3] example: PTP client slave minimal implementation Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 0/6] add sample ptp slave application Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 1/6] ethdev: add additional ieee1588 support functions Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 2/6] ixgbe: " Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 3/6] igb: " Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 4/6] i40e: " Daniel Mrzyglod
2015-10-30 11:19 ` Ananyev, Konstantin
2015-10-30 11:33 ` De Lara Guarch, Pablo
2015-10-30 11:36 ` Thomas Monjalon
2015-10-30 11:38 ` Ananyev, Konstantin
2015-10-30 9:43 ` [PATCH v2 5/6] example: PTP client slave minimal implementation Daniel Mrzyglod
2015-10-30 9:43 ` [PATCH v2 6/6] doc: add a PTPCLIENT sample guide Daniel Mrzyglod
2015-10-30 11:23 ` [PATCH v2 0/6] add sample ptp slave application Mcnamara, John
2015-11-03 16:38 ` [PATCH v3 0/7] " Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 1/7] ethdev: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 2/7] net: Add common PTP structures and functions Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 3/7] ixgbe: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 4/7] igb: " Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 5/7] i40e: " Daniel Mrzyglod
2015-11-03 16:38 ` [PATCH v3 6/7] example: PTP client slave minimal implementation Daniel Mrzyglod
2015-11-03 20:06 ` De Lara Guarch, Pablo
2015-11-03 16:38 ` [PATCH v3 7/7] doc: add a PTPCLIENT sample guide Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 0/7] add sample ptp slave application Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 1/7] ethdev: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 2/7] net: Add common PTP structures and functions Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 3/7] ixgbe: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 4/7] igb: " Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 5/7] i40e: " Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 6/7] example: PTP client slave minimal implementation Daniel Mrzyglod
2015-11-04 10:06 ` [PATCH v4 7/7] doc: add a PTPCLIENT sample guide Daniel Mrzyglod
2015-11-05 12:46 ` [PATCH v4 0/7] add sample ptp slave application Mcnamara, John
2015-11-05 15:17 ` Thomas Monjalon
2015-11-05 16:08 ` Mrzyglod, DanielX T
2015-11-05 13:37 ` Mcnamara, John
2015-11-05 14:05 ` [PATCH v5 " Daniel Mrzyglod
2015-11-05 14:06 ` [PATCH v5 1/7] ethdev: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-10 11:03 ` Thomas Monjalon
2015-11-10 11:36 ` Mcnamara, John
2015-11-10 11:58 ` Thomas Monjalon
2015-11-10 14:12 ` Mcnamara, John
2015-11-10 14:16 ` Thomas Monjalon
2015-11-10 15:18 ` Liu, Yong
2015-11-11 1:40 ` Cao, Waterman
2015-11-05 14:06 ` [PATCH v5 2/7] net: Add common PTP structures and functions Daniel Mrzyglod
2015-11-10 11:25 ` Thomas Monjalon
2015-11-11 10:45 ` Mcnamara, John
2015-11-11 11:24 ` Thomas Monjalon
2015-11-05 14:06 ` [PATCH v5 3/7] ixgbe: add additional ieee1588 support functions Daniel Mrzyglod
2015-11-05 14:06 ` [PATCH v5 4/7] igb: " Daniel Mrzyglod
2015-11-05 14:06 ` [PATCH v5 5/7] i40e: " Daniel Mrzyglod
2015-11-05 14:06 ` [PATCH v5 6/7] example: PTP client slave minimal implementation Daniel Mrzyglod
2015-11-05 14:06 ` [PATCH v5 7/7] doc: add a PTPCLIENT sample guide Daniel Mrzyglod
2015-11-05 14:10 ` [PATCH v5 0/7] add sample ptp slave application Mrzyglod, DanielX T
2015-11-05 14:30 ` Mcnamara, John
2015-11-12 12:55 ` [PATCH v6 0/8] " Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 1/8] ethdev: add additional ieee1588 support functions Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 2/8] eal: add common time structures and functions Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 3/8] ixgbe: add additional ieee1588 support functions Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 4/8] igb: " Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 5/8] i40e: " Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 6/8] testpmd: add nanosecond output for ieee1588 fwd Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 7/8] example: minimal ptp client implementation Pablo de Lara
2015-11-12 12:55 ` [PATCH v6 8/8] doc: add a ptpclient sample guide Pablo de Lara
2015-11-13 14:38 ` Thomas Monjalon
2015-11-13 14:58 ` De Lara Guarch, Pablo
2015-11-13 15:10 ` Thomas Monjalon
2015-11-13 15:15 ` De Lara Guarch, Pablo
2015-11-13 15:19 ` Thomas Monjalon
2015-11-12 13:20 ` [PATCH v6 0/8] add sample ptp slave application Mcnamara, John
2015-11-13 16:09 ` [PATCH v7 " Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 1/8] ethdev: add ieee1588 functions for device clock time Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 2/8] eal: add helpers for time conversions Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 3/8] ixgbe: support ieee1588 functions for device time Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 4/8] igb: " Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 5/8] i40e: " Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 6/8] testpmd: add nanosecond output for ieee1588 Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 7/8] example: add minimal PTP client Pablo de Lara
2015-11-13 16:09 ` [PATCH v7 8/8] doc: add a ptpclient sample guide Pablo de Lara
2015-11-13 16:28 ` [PATCH v7 0/8] add sample ptp slave application Thomas Monjalon
2015-11-13 16:38 ` De Lara Guarch, Pablo [this message]
2015-11-13 16:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C85861F@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.