Re: [PATCH] app/test: fix linkage scope of gmac plaintext array

From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
	"Jain, Deepak K" <deepak.k.jain@intel.com>,
	"Griffin, John" <john.griffin@intel.com>
Subject: Re: [PATCH] app/test: fix linkage scope of gmac plaintext array
Date: Thu, 22 Sep 2016 20:00:01 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9FC431@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1474555964-7998-1-git-send-email-arkadiuszx.kusztal@intel.com>

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Thursday, September 22, 2016 7:53 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin, John; Kusztal,
> ArkadiuszX
> Subject: [PATCH] app/test: fix linkage scope of gmac plaintext array
> 
> Array gmac_plaintext in test_cryptodev_gcm_test_vectors.h needs to be
> changed to static
> 
> Fixes: 7495f7594fed ("app/test: add GMAC authentication tests to cryptodev
> tests")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  app/test/test_cryptodev_gcm_test_vectors.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/app/test/test_cryptodev_gcm_test_vectors.h
> b/app/test/test_cryptodev_gcm_test_vectors.h
> index 4f6cb8f..f3f8bd3 100644
> --- a/app/test/test_cryptodev_gcm_test_vectors.h
> +++ b/app/test/test_cryptodev_gcm_test_vectors.h
> @@ -449,8 +449,7 @@ static const struct gcm_test_data gcm_test_case_7 = {
>  };
> 
>  /** GMAC Test Vectors */
> -
> -uint8_t gmac_plaintext[] = {
> +static uint8_t gmac_plaintext[] = {
>  			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
>  			0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10,
>  			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
> --
> 2.1.0

Squashed to 7495f7594fed ("app/test: add GMAC authentication tests to cryptodev tests"),
in dpdk-next-crypto.

Thanks,
Pablo