From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality Date: Wed, 21 Dec 2016 12:39:47 +0000 Message-ID: References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161205125540.6419-7-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "thomas.monjalon@6wind.com" , "eclan.doherty@intel.com" , "hemant.agrawal@nxp.com" To: Akhil Goyal , "dev@dpdk.org" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 72A022C58 for ; Wed, 21 Dec 2016 13:39:51 +0100 (CET) In-Reply-To: <20161205125540.6419-7-akhil.goyal@nxp.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Monday, December 05, 2016 12:56 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; eclan.doherty@intel.com; De Lara > Guarch, Pablo; hemant.agrawal@nxp.com; Akhil Goyal > Subject: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality >=20 > Signed-off-by: Akhil Goyal > Reviewed-by: Hemant Agrawal > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 + > drivers/crypto/dpaa2_sec/Makefile | 1 - > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1337 > +++++++++++++++++++++++++++ > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 516 +++++++++++ > drivers/net/dpaa2/base/dpaa2_hw_pvt.h | 25 + For the whole patch, there are some checkpatch errors that you should fix f= or the v2: http://dpdk.org/ml/archives/test-report/2016-December/005244.html Make sure that you fix also the other patches. Also, a comment below about the capabilities structure. Thanks, Pablo > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > new file mode 100644 > index 0000000..01fae77 > --- /dev/null > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > @@ -0,0 +1,516 @@ ... As far as I could see, this PMD supports AES-CBC, 3DES-CBC and SHA1 and SHA= 2 with HMAC algorithms, but you are including here more algorithms that this PMD looks like does no= t support (such as AES XCBC, GCM, etc...) > + { /* AES XCBC MAC */ > + .op =3D RTE_CRYPTO_OP_TYPE_SYMMETRIC, > + {.sym =3D { > + .xform_type =3D RTE_CRYPTO_SYM_XFORM_AUTH, > + {.auth =3D { > + .algo =3D > RTE_CRYPTO_AUTH_AES_XCBC_MAC, > + .block_size =3D 16, > + .key_size =3D { > + .min =3D 16, > + .max =3D 16, > + .increment =3D 0 > + }, > + .digest_size =3D { > + .min =3D 16, > + .max =3D 16, > + .increment =3D 0 > + }, > + .aad_size =3D { 0 } > + }, } > + }, } > + },