From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding
	bytes for GCM
Date: Fri, 6 Jan 2017 10:27:06 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476BF3DF@IRSMSX108.ger.corp.intel.com>
References: <1482481493-4369-1-git-send-email-arkadiuszx.kusztal@intel.com>
 <1482481493-4369-2-git-send-email-arkadiuszx.kusztal@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>, "Griffin, John"
 <john.griffin@intel.com>, "Jain, Deepak K" <deepak.k.jain@intel.com>,
 "Doherty, Declan" <declan.doherty@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1482481493-4369-2-git-send-email-arkadiuszx.kusztal@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

CC'ing stable mailing list.

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Friday, December 23, 2016 8:25 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K;
> Doherty, Declan; Kusztal, ArkadiuszX
> Subject: [PATCH v2 1/3] crypto/aesni_gcm: fix J0 padding bytes for GCM
>=20
> This commit fixes pre-counter block (J0) padding by clearing
> four most significant bytes before setting initial counter value.
>=20
> Fixes: b2bb3597470c ("crypto/aesni_gcm: move pre-counter block to
> driver")
>=20
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> index dba5e15..af3d60f 100644
> --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
> @@ -40,6 +40,7 @@
>  #include <rte_vdev.h>
>  #include <rte_malloc.h>
>  #include <rte_cpuflags.h>
> +#include <rte_byteorder.h>
>=20
>  #include "aesni_gcm_pmd_private.h"
>=20
> @@ -241,7 +242,8 @@ process_gcm_crypto_op(struct aesni_gcm_qp *qp,
> struct rte_crypto_sym_op *op,
>  	 * to set BE LSB to 1, driver expects that 16B is allocated
>  	 */
>  	if (op->cipher.iv.length =3D=3D 12) {
> -		op->cipher.iv.data[15] =3D 1;
> +		uint32_t *iv_padd =3D (uint32_t *)&op->cipher.iv.data[12];
> +		*iv_padd =3D rte_bswap32(1);
>  	}
>=20
>  	if (op->auth.aad.length !=3D 12 && op->auth.aad.length !=3D 8 &&
> --
> 2.1.0