From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH] tools: fix active interface detection in dpdk-devbind.py Date: Tue, 10 Jan 2017 09:22:41 +0000 Message-ID: References: <1483979853-16386-1-git-send-email-yonig@radcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: Yoni Gilad , "Jain, Deepak K" Return-path: In-Reply-To: <1483979853-16386-1-git-send-email-yonig@radcom.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yoni Gilad > Sent: Monday, January 09, 2017 4:38 PM > To: De Lara Guarch, Pablo; Jain, Deepak K > Cc: dev@dpdk.org; Yoni Gilad; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] tools: fix active interface detection in dpdk= - > devbind.py >=20 > When adding crypto devices, the "Active" and "Ssh_if" attributes of > existing network devices were reset. This causes the follwing issues: >=20 > - Network interfaces aren't marked as "*Active*" in the --status output. > - Active network interfaces can be unbound without the --force option, > causing loss of network connection. >=20 > The reset was caused by the call to devices[d].update in > get_crypto_details. >=20 > This patch prevents the update on non-crypto devices. >=20 > Fixes: cb4a1d1 ("tools: bind crypto devices") >=20 > CC: stable@dpdk.org >=20 > Signed-off-by: Yoni Gilad > --- > usertools/dpdk-devbind.py | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) >=20 > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index e057b87..1b9c651 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py > @@ -328,6 +328,9 @@ def get_crypto_details(): >=20 > # based on the basic info, get extended text details > for d in devices.keys(): > + if devices[d]["Class"][0:2] !=3D CRYPTO_BASE_CLASS: > + continue > + > # get additional info and add it to existing data > devices[d] =3D devices[d].copy() > devices[d].update(get_pci_device_details(d).items()) > -- > 1.7.1 Typo in "follwing". Also, the fixline SHA should be " cb4a1d14bf3e", the fi= rst 6 bytes. Apart from this, Acked-by: Pablo de Lara