From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v5 4/7] doc: update documentation about ARMv8 crypto PMD Date: Wed, 18 Jan 2017 19:54:58 +0000 Message-ID: References: <1484668143-32522-3-git-send-email-zbigniew.bodek@caviumnetworks.com> <1484749650-24867-1-git-send-email-zbigniew.bodek@caviumnetworks.com> <1484749650-24867-5-git-send-email-zbigniew.bodek@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "jianbo.liu@linaro.org" , "hemant.agrawal@nxp.com" To: Zbigniew Bodek , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4CB6DFAEB for ; Wed, 18 Jan 2017 20:55:02 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Zbigniew, > -----Original Message----- > From: Zbigniew Bodek [mailto:zbigniew.bodek@caviumnetworks.com] > Sent: Wednesday, January 18, 2017 7:52 PM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: Doherty, Declan; jerin.jacob@caviumnetworks.com; > jianbo.liu@linaro.org; hemant.agrawal@nxp.com > Subject: Re: [PATCH v5 4/7] doc: update documentation about ARMv8 > crypto PMD >=20 > Hello Pablo, >=20 > Thanks for the remarks. Please check my answers in-line below. >=20 > Kind regards > Zbigniew >=20 > On 18.01.2017 18:05, De Lara Guarch, Pablo wrote: > > Hi Bodek, > > > >> -----Original Message----- > >> From: zbigniew.bodek@caviumnetworks.com > >> [mailto:zbigniew.bodek@caviumnetworks.com] > >> Sent: Wednesday, January 18, 2017 2:27 PM > >> To: dev@dpdk.org > >> Cc: De Lara Guarch, Pablo; Doherty, Declan; > >> jerin.jacob@caviumnetworks.com; jianbo.liu@linaro.org; > >> hemant.agrawal@nxp.com; Zbigniew Bodek > >> Subject: [PATCH v5 4/7] doc: update documentation about ARMv8 > crypto > >> PMD > >> > >> From: Zbigniew Bodek > >> > >> Add documentation about the driver and update > >> release notes. > >> > >> Signed-off-by: Zbigniew Bodek > >> Reviewed-by: Jerin Jacob > >> --- > >> doc/guides/cryptodevs/armv8.rst | 96 > >> ++++++++++++++++++++++++++++++++++ > >> doc/guides/cryptodevs/index.rst | 1 + > >> doc/guides/rel_notes/release_17_02.rst | 5 ++ > >> 3 files changed, 102 insertions(+) > >> create mode 100644 doc/guides/cryptodevs/armv8.rst > >> > >> diff --git a/doc/guides/cryptodevs/armv8.rst > >> b/doc/guides/cryptodevs/armv8.rst > >> new file mode 100644 > >> index 0000000..ca8781e > >> --- /dev/null > >> +++ b/doc/guides/cryptodevs/armv8.rst > > > > ... > > > >> + > >> +ARMv8 Crypto Poll Mode Driver > >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > Extra "=3D=3D=3D" here. >=20 > Fixed in the upcoming patchset. >=20 > > > >> + > >> +This code provides the initial implementation of the ARMv8 crypto > PMD. > >> +The driver uses ARMv8 cryptographic extensions to process chained > >> crypto > >> +operations in an optimized way. The core functionality is provided by > >> +a low-level library, written in the assembly code. > >> + > >> +Features > >> +-------- > >> + > >> +ARMv8 Crypto PMD has support for the following algorithm pairs: > >> + > >> +Supported cipher algorithms: > >> +* ``RTE_CRYPTO_CIPHER_AES_CBC`` > > > > Add a blank like before starting a list (same below). >=20 > Also fixed. >=20 > > > >> + > >> +Supported authentication algorithms: > >> +* ``RTE_CRYPTO_AUTH_SHA1_HMAC`` > >> +* ``RTE_CRYPTO_AUTH_SHA256_HMAC`` > >> + > > > > Could you add an entry on the "Crypto Device Supported Functionality > Matrices", > > to show supported algorithms and feature flags? It is in > doc/guides/cryptodevs/overview.rst. >=20 > Yes, looking at that file I realized that we also could add "crypto > device supported feature flags" for ARM. I created another commit in the > patchset (preceding the one with the documentation update for PMD). > The method of adding this flags is similar to what has been done earlier > for other PMDs and their features. > I used two names: > * NEON - which is an ARM component so we can use this name as a unique > name. > * ARM_CE - for ARM cryptographic extensions. AFAIK there is no other > name for that. Looks good to me. >=20 > > > > There should be a column per crypto device > > (I just realized that I missed one for ZUC PMD, so I will send a patch > shortly, > > and then you can rebase it on top of it). >=20 > Done with the new flags mentioned above as well. I'm sending another > patchset now and if you have some remarks to the new commits then let's > do another round :-). Thanks! Pablo >=20 > > > > The rest of the patchset looks good to me, so once you send another > version, I will merge it. > > > > Thanks, > > Pablo > >