From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v6 2/2] test/test: add unit test for CRC
	computation
Date: Wed, 29 Mar 2017 16:12:55 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8974770EED5@IRSMSX108.ger.corp.intel.com>
References: <1490107540-66614-2-git-send-email-jasvinder.singh@intel.com>
 <1490791332-126476-1-git-send-email-jasvinder.singh@intel.com>
 <1490791332-126476-3-git-send-email-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 873ABDE5
 for <dev@dpdk.org>; Wed, 29 Mar 2017 18:12:59 +0200 (CEST)
In-Reply-To: <1490791332-126476-3-git-send-email-jasvinder.singh@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jasvinder,

> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Wednesday, March 29, 2017 1:42 PM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Doherty, Declan; De Lara Guarch, Pablo
> Subject: [PATCH v6 2/2] test/test: add unit test for CRC computation
>=20
> This patch provides a set of tests for verifying the functional
> correctness of 16-bit and 32-bit CRC APIs.
>=20
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  test/test/Makefile   |   2 +
>  test/test/test_crc.c | 241
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 243 insertions(+)
>  create mode 100644 test/test/test_crc.c
>=20

...

> diff --git a/test/test/test_crc.c b/test/test/test_crc.c
> new file mode 100644
> index 0000000..c25790d
> --- /dev/null
> +++ b/test/test/test_crc.c
> @@ -0,0 +1,241 @@

...

> +static int
> +test_crc_scalar(void)

Could you merge this and the next function in a single one,
as they are duplicated (except for the comments/printfs, which can be a par=
ameter of the function).

Apart from this:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>