From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v6 1/2] librte_net: add crc compute APIs
Date: Wed, 29 Mar 2017 16:14:34 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8974770EEE4@IRSMSX108.ger.corp.intel.com>
References: <1490107540-66614-2-git-send-email-jasvinder.singh@intel.com>
 <1490791332-126476-1-git-send-email-jasvinder.singh@intel.com>
 <1490791332-126476-2-git-send-email-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Doherty, Declan"
 <declan.doherty@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 92FEED23A
 for <dev@dpdk.org>; Wed, 29 Mar 2017 18:14:39 +0200 (CEST)
In-Reply-To: <1490791332-126476-2-git-send-email-jasvinder.singh@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Wednesday, March 29, 2017 1:42 PM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Doherty, Declan; De Lara Guarch, Pablo
> Subject: [PATCH v6 1/2] librte_net: add crc compute APIs
>=20
> APIs for selecting the architecure specific implementation and computing
> the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar
> as well as x86 intrinsic(sse4.2) versions are implemented.
>=20
> The scalar version is based on generic Look-Up Table(LUT) algorithm,
> while x86 intrinsic version uses carry-less multiplication for
> fast CRC computation.
>=20
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>

Thanks for your work addressing all my comments.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>