From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH] crypto/scheduler: add get attached slaves API Date: Wed, 29 Mar 2017 21:24:14 +0000 Message-ID: References: <1487690086-45732-1-git-send-email-roy.fan.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Zhang, Roy Fan" , "dev@dpdk.org" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7F04A1396 for ; Wed, 29 Mar 2017 23:26:19 +0200 (CEST) In-Reply-To: <1487690086-45732-1-git-send-email-roy.fan.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, > -----Original Message----- > From: Zhang, Roy Fan > Sent: Tuesday, February 21, 2017 3:15 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH] crypto/scheduler: add get attached slaves API >=20 > This patch adds an API to get the run-time slaves number and list > of a cryptodev scheduler PMD. >=20 > Signed-off-by: Fan Zhang > --- > drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 31 > ++++++++++++++++++++++ > drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 23 > ++++++++++++++++ > .../scheduler/rte_pmd_crypto_scheduler_version.map | 7 +++++ > 3 files changed, 61 insertions(+) >=20 > diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c > b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c > index 11e8143..55c0ec4 100644 > --- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c > +++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c > @@ -469,3 +469,34 @@ > rte_cryptodev_scheduler_load_user_scheduler(uint8_t scheduler_id, >=20 > return 0; > } > + > +int > +rte_cryptodev_scheduler_slaves_get(uint8_t scheduler_id, uint8_t > *slaves) > +{ > + struct rte_cryptodev *dev =3D > rte_cryptodev_pmd_get_dev(scheduler_id); > + struct scheduler_ctx *sched_ctx; > + int nb_slaves =3D 0; This variable should be uint32_t (or uint8_t, as not more than 8 slaves are= allowed). > + > + if (!dev) { > + CS_LOG_ERR("Operation not supported"); > + return -ENOTSUP; > + } > + > + if (dev->dev_type !=3D RTE_CRYPTODEV_SCHEDULER_PMD) { > + CS_LOG_ERR("Operation not supported"); > + return -ENOTSUP; > + } > + > + sched_ctx =3D dev->data->dev_private; > + > + nb_slaves =3D (int)sched_ctx->nb_slaves; > + > + if (slaves) { > + int i; uint8_t i > + > + for (i =3D 0; i < nb_slaves; i++) > + slaves[i] =3D sched_ctx->slaves[i].dev_id; > + } > + > + return 0; Shouldn't you return "nb_slaves" here (might need cast to int)? > +} > diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h > b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h > index 7ef44e7..0e32895 100644 > --- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h > +++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h > @@ -40,6 +40,11 @@ > extern "C" { > #endif >=20 > +/**< Maximum number of bonded devices per devices */ Typo: "per device". > +#ifndef RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES > +#define RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES (8) > +#endif > + > /** > * Crypto scheduler PMD operation modes > */ > @@ -143,6 +148,24 @@ rte_cryptodev_scheduler_ordering_set(uint8_t > scheduler_id, > int > rte_cryptodev_scheduler_ordering_get(uint8_t scheduler_id); >=20 > +/** > + * Get the the attached slaves' count and/or ID > + * > + *@param scheduler_id The target scheduler device ID > + * slaves If successful, the slaves' device Follow the convention for Doxygen comments. Use @param for every parameter, and start the description in the next line. > + * IDs will be written. This parameter > + * can be NULL, but otherwise please NOTE > + * it should be an uint8_t array of at least > + * > RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES > + * elements. > + * > + * @return > + * non-negative number: the number of slaves attached > + * negative integer if error occurs. > + */ > +int > +rte_cryptodev_scheduler_slaves_get(uint8_t scheduler_id, uint8_t > *slaves); > + > typedef uint16_t (*rte_cryptodev_scheduler_burst_enqueue_t)(void > *qp_ctx, > struct rte_crypto_op **ops, uint16_t nb_ops); >=20