From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v8 02/13] crypto/dpaa2_sec: add dpaa2 sec
 poll	mode driver
Date: Wed, 19 Apr 2017 17:32:17 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8974780CBEB@IRSMSX108.ger.corp.intel.com>
References: <20170410123108.26305-1-akhil.goyal@nxp.com>
 <1492616268-6307-1-git-send-email-akhil.goyal@nxp.com>
 <1492616268-6307-3-git-send-email-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Doherty, Declan" <declan.doherty@intel.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id E38E3567F
 for <dev@dpdk.org>; Wed, 19 Apr 2017 19:32:21 +0200 (CEST)
In-Reply-To: <1492616268-6307-3-git-send-email-akhil.goyal@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of
> akhil.goyal@nxp.com
> Sent: Wednesday, April 19, 2017 4:38 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan; Mcnamara, John; hemant.agrawal@nxp.com
> Subject: [dpdk-dev] [PATCH v8 02/13] crypto/dpaa2_sec: add dpaa2 sec
> poll mode driver
>=20
> From: Akhil Goyal <akhil.goyal@nxp.com>
>=20
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---


> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> new file mode 100644
> index 0000000..378df4a
> --- /dev/null
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -0,0 +1,194 @@

...

> +static int
> +dpaa2_sec_uninit(__attribute__((unused))
> +		 const struct rte_cryptodev_driver *crypto_drv,
> +		 struct rte_cryptodev *dev)
> +{
> +	if (dev->data->name =3D=3D NULL)
> +		return -EINVAL;

You can remove this, as dev->data->name is not a char[32], so it cannot be =
NULL.