From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v2 06/12] cryptodev: move vdev functions to a separate file Date: Tue, 27 Jun 2017 22:22:34 +0000 Message-ID: References: <1495639634-74846-1-git-send-email-pablo.de.lara.guarch@intel.com> <1703981.y8KKVdfaY4@xps> <8d33a2ad-b80c-1337-0db3-88aa5e6fcb07@intel.com> <1580410.hOtKtBbxIg@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Doherty, Declan" To: "De Lara Guarch, Pablo" , Thomas Monjalon , "Yigit, Ferruh" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5FF20271 for ; Wed, 28 Jun 2017 00:22:38 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, June 27, 2017 6:12 PM > To: Thomas Monjalon ; Yigit, Ferruh > > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev functions > to a separate file >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Tuesday, June 27, 2017 5:09 PM > > To: Yigit, Ferruh > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > ; Doherty, Declan > > > > Subject: Re: [dpdk-dev] [PATCH v2 06/12] cryptodev: move vdev > > functions to a separate file > > > > 27/06/2017 17:11, Ferruh Yigit: > > > On 6/27/2017 3:28 PM, Thomas Monjalon wrote: > > > > 27/06/2017 11:51, De Lara Guarch, Pablo: > > > >> From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > >>> 23/06/2017 14:52, Declan Doherty: > > > >>>> On 21/06/2017 7:28 AM, Pablo de Lara wrote: > > > >>>>> Move all functions handling virtual devices to a separate > > > >>>>> header file "rte_cryptodev_vdev.h", in order to leave only > > > >>>>> generic functions for any device in the rest of the files. > > > >>>>> > > > >>>>> Signed-off-by: Pablo de Lara > > > >>>> > > > >>>> Acked-by: Declan Doherty > > > >>> > > > >>> This patch is moving some code from a .c to a .h. > > > >>> The consequence is that driver are now compiling new functions > > > >>> from the .h and require librte_kvargs to link with. > > > >>> It is a build error in shared lib mode. > > > >>> > > > >>> Please keep the code in a .c file if possible. > > > >> > > > >> Sorry about this. I just fixed it in the subtree, so pull it > > > >> whenever you > > are ready. > > > >> Also, since ethdev have separated pci and vdev functions in > > > >> separate .h files, I preferred to be consistent and do the same. > > > > > > > > There is no reason to implement these functions in .h files. > > > > I prefer to keep them in a .c file and just export the proto in .h. > > > > > > This is same in the eth_dev too. > > > > > > These are helper functions, and implementing them in .h file has the > > > benefit of function goes into PMD library, and there is no > > > dependency from PMDs to librte_ether for these functions (there are > > > dependencies for other functions ..). > > > > > > It looks acceptable for me for helper functions to be implemented in > > > header file. But if we decide to move them into .c file, .map file > > > should be updated to export them, and I suppose ethdev also should > > > be updated to be compatible. > > > > Yes we should avoid adding code in .h. > > It is accepted only for performance reasons. > > ethdev can be reworked later. > > cryptodev can be improved now and avoid adding rte_devargs deps on > > PMDs. >=20 > Ok, will make those changes shortly. I have implemented these functions in a separated .c file and pushed it to = dpdk-next-crypto. Pablo >=20 > Pablo