From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
Date: Thu, 6 Jul 2017 07:49:31 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD6F66@IRSMSX108.ger.corp.intel.com>
References: <20170705162142.11170-1-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
To: 'Akhil Goyal' <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 53ED62C8
 for <dev@dpdk.org>; Thu,  6 Jul 2017 09:49:35 +0200 (CEST)
In-Reply-To: <20170705162142.11170-1-akhil.goyal@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 5, 2017 5:22 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
>=20
> while registering driver to dpaa2, hard coded string is used.
> It is now updated as per the latest changes in string name.
>=20
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 769a139..b0794f5 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> rte_dpaa2_sec_driver =3D {
>  	.remove =3D cryptodev_dpaa2_sec_remove,
>  };
>=20
> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> rte_dpaa2_sec_driver);
>  RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> cryptodev_driver_id);
> --
> 2.9.3

Now that the name is internal, and since this not used to create a vdev and=
 therefore,
it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pm=
d" to
"crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_<pm=
d_name>?

Thanks,
Pablo