From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v3] cryptodev: allocate driver structure statically Date: Wed, 6 Sep 2017 10:27:36 +0000 Message-ID: References: <20170731091817.41505-1-pablo.de.lara.guarch@intel.com> <20170816024151.15325-1-pablo.de.lara.guarch@intel.com> <696B43C21188DF4F9C9091AAE4789B824E29582B@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Rybalchenko, Kirill" , "Doherty, Declan" , "Trahe, Fiona" , "Jain, Deepak K" , "Griffin, John" , "jerin.jacob@caviumnetworks.com" , "akhil.goyal@nxp.com" , "hemant.agrawal@nxp.com" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A4ED9108F for ; Wed, 6 Sep 2017 12:27:39 +0200 (CEST) In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E29582B@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Rybalchenko, Kirill > Sent: Monday, September 4, 2017 11:39 AM > To: De Lara Guarch, Pablo ; Doherty, > Declan ; Trahe, Fiona ; > Jain, Deepak K ; Griffin, John > ; jerin.jacob@caviumnetworks.com; > akhil.goyal@nxp.com; hemant.agrawal@nxp.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure > statically >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Wednesday 16 August 2017 03:42 > > To: Doherty, Declan ; Trahe, Fiona > > ; Jain, Deepak K ; > > Griffin, John ; > > jerin.jacob@caviumnetworks.com; akhil.goyal@nxp.com; > > hemant.agrawal@nxp.com > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > > > Subject: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure > > statically > > > > When register a crypto driver, a cryptodev driver structure was being > > allocated, using malloc. > > Since this call may fail, it is safer to allocate this memory > > statically in each PMD, so driver registration will never fail. > > > > Coverity issue: 158645 > > > > Fixes: 7a364faef185 ("cryptodev: remove crypto device type > > enumeration") > > > > Signed-off-by: Pablo de Lara > > --- > > > > Changes in v3: > > > > - Added documentation (removed deprecation notice and added API > > Change) > > - Modified title to something more explicit > > > > Changes in v2: > > > > - Allocate statically the cryptodev driver structure, > > instead of using malloc, that can potentially fail. > > > > doc/guides/rel_notes/deprecation.rst | 6 ------ > > doc/guides/rel_notes/release_17_11.rst | 5 +++++ > > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 5 ++++- > > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +++++- > > drivers/crypto/armv8/rte_armv8_pmd.c | 9 ++++++--- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 ++++- > > drivers/crypto/kasumi/rte_kasumi_pmd.c | 5 ++++- > > drivers/crypto/null/null_crypto_pmd.c | 5 ++++- > > drivers/crypto/openssl/rte_openssl_pmd.c | 5 ++++- > > drivers/crypto/qat/rte_qat_cryptodev.c | 7 +++++-- > > drivers/crypto/scheduler/scheduler_pmd.c | 5 ++++- > > drivers/crypto/snow3g/rte_snow3g_pmd.c | 5 ++++- > > drivers/crypto/zuc/rte_zuc_pmd.c | 5 ++++- > > lib/librte_cryptodev/rte_cryptodev.c | 18 +++++------------ > > lib/librte_cryptodev/rte_cryptodev.h | 20 ------------------- > > lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 > > +++++++++++++++++++++++++++++ > > 16 files changed, 88 insertions(+), 53 deletions(-) > > >=20 > Reviewed-by: Kirill Rybalchenko >=20 Applied to dpdk-next-crypto. Pablo