From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v2 17/20] crypto/ccp: add cpu based md5 and
 sha2 family auth algo support
Date: Mon, 8 Jan 2018 17:36:07 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC6A161@IRSMSX108.ger.corp.intel.com>
References: <1512047553-118101-1-git-send-email-Ravi1.kumar@amd.com>
 <1515145198-97367-1-git-send-email-Ravi1.kumar@amd.com>
 <1515145198-97367-17-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: Ravi Kumar <Ravi1.kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id DA8331322C
 for <dev@dpdk.org>; Mon,  8 Jan 2018 18:36:11 +0100 (CET)
In-Reply-To: <1515145198-97367-17-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ravi,

> -----Original Message-----
> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> Sent: Friday, January 5, 2018 9:40 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family
> auth algo support
>=20
> Auth operations can be performed on CPU without offloading to CCP if
> CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH is enabled in DPDK
> configuration.
>=20
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

...

> --- a/drivers/crypto/ccp/ccp_crypto.c
> +++ b/drivers/crypto/ccp/ccp_crypto.c

...

>  }
>=20
> @@ -2638,13 +2874,23 @@ static inline void ccp_auth_dq_prepare(struct
> rte_crypto_op *op)  }
>=20
>  static int
> -ccp_prepare_ops(struct rte_crypto_op **op_d,
> +ccp_prepare_ops(struct ccp_qp *qp,

There is a compilation error if the PMD is enabled and
CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn.

You need to set the struct ccp_qp *qp parameter as __rte_unused,
in case this option is not enabled.

Pablo