From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
Date: Wed, 10 Jan 2018 13:41:20 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC6CCAD@IRSMSX108.ger.corp.intel.com>
References: <1515145198-97367-1-git-send-email-Ravi1.kumar@amd.com>
 <1515577379-18453-1-git-send-email-Ravi1.kumar@amd.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC6C65A@IRSMSX108.ger.corp.intel.com>
 <CY4PR12MB1509E3766BC079F6A8070CA2AE110@CY4PR12MB1509.namprd12.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Shippen, Greg" <Greg.Shippen@amd.com>
To: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id E8AB91B217
 for <dev@dpdk.org>; Wed, 10 Jan 2018 14:41:25 +0100 (CET)
In-Reply-To: <CY4PR12MB1509E3766BC079F6A8070CA2AE110@CY4PR12MB1509.namprd12.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Wednesday, January 10, 2018 10:30 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>=20
> >Hi Ravi,
> >
> >> -----Original Message-----
> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> >> Sent: Wednesday, January 10, 2018 9:43 AM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >>
> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> >> ---
> >
> >...
> >
> >> --- /dev/null
> >> +++ b/drivers/crypto/ccp/Makefile
> >> @@ -0,0 +1,55 @@
> >> +#
> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> >> +#   All rights reserved.
> >> +#
> >
> >As Hemant commented, you need to change this full license with SPDX
> tags:
> >
> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
> >
> >Could you submit a v4 with these changes today?
> >
> >Thanks,
> >Pablo
>=20
> Hi Pablo,
>=20
> Our legal team is still working on the license. We want to get the code
> reviewed in parallel.
> I will give you and update later if we can upload the v4 patch with SPDX =
tags
> today.
>=20

Ok, I have looked at the overall patchset and it looks ok to me.
The only thing that I would change is the title of patch 7/19:
I would change it to "crypto/ccp: support sessionless operations".

Regards,
Pablo

> Regards,
> Ravi