From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v7 0/3] failsafe: fix hotplug races Date: Tue, 13 Feb 2018 20:58:11 +0000 Message-ID: References: <1518369872-12324-1-git-send-email-matan@mellanox.com> <1518468702-16719-1-git-send-email-matan@mellanox.com> <20180213133152.gmz35ovsbkrrkkef@bidouze.vm.6wind.com> <3095675.L7ouegUbFy@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , =?iso-8859-1?Q?Ga=EBtan_Rivet?= To: Thomas Monjalon , Matan Azrad Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E1AC01B2C7 for ; Tue, 13 Feb 2018 21:58:16 +0100 (CET) In-Reply-To: <3095675.L7ouegUbFy@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 13, 2018 4:12 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ga=EBtan Rivet > Subject: Re: [dpdk-dev] [PATCH v7 0/3] failsafe: fix hotplug races >=20 > 13/02/2018 14:31, Ga=EBtan Rivet: > > Hi Matan, > > > > On Mon, Feb 12, 2018 at 08:51:39PM +0000, Matan Azrad wrote: > > > This series fixes failsafe race between control commands to the > asynchronic plug-out\in processes. > > > > > > > Thanks for tackling this complicated issue. > > For the series: > > > > Acked-by: Gaetan Rivet >=20 > Applied, thanks There is a compilation error due to this patch on FreeBSD: drivers/net/failsafe/failsafe_private.h:377:53: error: format specifies type 'unsigned long' but the argument has type 'pthread_t' (aka 'struct pth= read *') [-Werror,-Wformat] DEBUG("Hot-plug mutex was locked by thread %lu%s", pthread_self(), I am not sure how to print a pthread_t, so I can just report the issue. Thanks, Pablo