From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [v3,3/3] doc: add private data info in crypto guide Date: Tue, 17 Apr 2018 13:49:20 +0000 Message-ID: References: <1523861696-103397-1-git-send-email-abhinandan.gujjar@intel.com> <1523861696-103397-3-git-send-email-abhinandan.gujjar@intel.com> <5612CB344B05EE4F95FC5B729939F780706E4CB4@PGSMSX102.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Vangati, Narender" , "Rao, Nikhil" To: "Gujjar, Abhinandan S" , Akhil Goyal , "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9E007AAD1 for ; Tue, 17 Apr 2018 15:49:24 +0200 (CEST) In-Reply-To: <5612CB344B05EE4F95FC5B729939F780706E4CB4@PGSMSX102.gar.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Monday, April 16, 2018 10:36 AM > To: Akhil Goyal ; De Lara Guarch, Pablo > ; Doherty, Declan > ; jerin.jacob@caviumnetworks.com; > hemant.agrawal@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > > Subject: RE: [v3,3/3] doc: add private data info in crypto guide >=20 > Hi Akhil, >=20 > Missed out the *series* and thought the ack was only on the doc patch. > Regarding change log, Just before posting I looked at recent patches. > Most of them, didn't have change log! So, I didn't add it. > Yes, there is a typo in the subject of this patch. Does this require newe= r version > of patches? Unless there is something else to change, there is no need to send another = patchset just for this typo. About changelog, it is a good practice to add it. Also, for patchsets, it i= s good to add a cover letter, and there you could add the changelog for the entire pa= tchset. Thanks, Pablo