From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH] app/bbdev: update test vectors Date: Tue, 24 Apr 2018 14:56:51 +0000 Message-ID: References: <20180404140602.9344-1-kamilx.chalupnik@intel.com> <20180404140602.9344-7-kamilx.chalupnik@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Mokhtar, Amr" , "Chalupnik, KamilX" To: "Chalupnik, KamilX" , "dev@dpdk.org" Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 672DC2C17 for ; Tue, 24 Apr 2018 16:56:56 +0200 (CEST) In-Reply-To: <20180404140602.9344-7-kamilx.chalupnik@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of KamilX Chalupnik > Sent: Wednesday, April 4, 2018 3:06 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH] app/bbdev: update test vectors >=20 > From: "Chalupnik, KamilX" >=20 > Update test vectors directory for Wireless Baseband Device: > - creation of new vectors to test and validate BBDevice capabilities > - python script used for tests execution updated >=20 > Update the test app documentation: > - vector test names updated > - description of tests added > - usage of test app updated >=20 > Signed-off-by: KamilX Chalupnik Could you split this patch into multiple patches? You are doing several thi= ngs here, so it is better to split each thing into a different patch. Make sure that the functionality and compilation is not broken for each pat= ch. I think you can have a patch updating the names of current tests (updating = the documentation in the same patch), another patch adding the new tests (also updating the documentation) and a = last patch with the rest of the documentation changes. This way, it will be easier to review. Also, another comment below. > --- a/doc/guides/tools/testbbdev.rst > +++ b/doc/guides/tools/testbbdev.rst ... >=20 > ./test-bbdev.py -p ../../x86_64-native-linuxapp-icc/app/testbbdev > - -v ./test_vectors/bbdev_vector_td_default.data > + -v turbo_dec_default.data Shouldn't this be still under test_vectors?