From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH 4/4] crypto/dpaa_sec: update maximum
	queue	pairs to 2
Date: Mon, 7 May 2018 13:39:39 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD033D3@IRSMSX108.ger.corp.intel.com>
References: <1524156759-12931-1-git-send-email-hemant.agrawal@nxp.com>
 <1524156759-12931-4-git-send-email-hemant.agrawal@nxp.com>
 <f6cb93d5-586f-e6bb-ee7a-12855f2a9b9c@nxp.com>
 <DB3PR04MB076220A1FC14BFAEEDF7442A89B40@DB3PR04MB0762.eurprd04.prod.outlook.com>
 <a2483237-116d-2901-6830-a58268bacd24@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CCD9999@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Nipun Gupta <nipun.gupta@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, Akhil Goyal
 <akhil.goyal@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 9E4172F4F
 for <dev@dpdk.org>; Mon,  7 May 2018 15:39:46 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CCD9999@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pabl=
o
> Sent: Friday, April 20, 2018 5:00 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; dev@dpdk.org
> Cc: Nipun Gupta <nipun.gupta@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue
> pairs to 2
>=20
>=20
>=20
> > -----Original Message-----
> > From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> > Sent: Friday, April 20, 2018 11:40 AM
> > To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org; De Lara
> > Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: Nipun Gupta <nipun.gupta@nxp.com>
> > Subject: Re: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs
> > to 2
> >
> > Hi Hemant,
> > On 4/20/2018 3:53 PM, Hemant Agrawal wrote:
> > >
> > >
> > >> Hi Hemant/Nipun
> > >> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:
> > >>> From: Nipun Gupta <nipun.gupta@nxp.com>
> > >>>
> > >>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> > >>> ---
> > >>>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-
> > >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h
> > >>> b/drivers/crypto/dpaa_sec/dpaa_sec.h
> > >>> index 1433595..5b25aa1 100644
> > >>> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h
> > >>> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
> > >>> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {
> > >>>  	int tx_errs;
> > >>>  };
> > >>>
> > >>> -#define RTE_DPAA_MAX_NB_SEC_QPS 1
> > >>> +#define RTE_DPAA_MAX_NB_SEC_QPS 2
> > >>>  #define RTE_DPAA_MAX_RX_QUEUE
> > >> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS
> > >>> #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63
> > >>>
> > >>>
> > >> Why 2? I think it should be 8.
> > >>
> > > [Hemant] Ok. Sending v2
> >
> > I guess this need some testing whether it will break the existing use c=
ases or
> not.
> >
> > Pablo,
> >
> > I recommend, it would be good if you can apply the other 3 patches in
> > this series in RC1. This patch should be hold back for RC2.
>=20
> Good to me.

Any update on this?

> Thanks,
> Pablo
>=20
> >
> > Thanks,
> > Akhil