From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v2] crypto/ccp: support command line option
 to enable CPU based auth
Date: Wed, 9 May 2018 15:27:56 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD05715@IRSMSX108.ger.corp.intel.com>
References: <1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com>
 <1525869983-4705-1-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "thomas@monjalon.net" <thomas@monjalon.net>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>
To: Ravi Kumar <Ravi1.kumar@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E0C701B6E0
 for <dev@dpdk.org>; Wed,  9 May 2018 17:27:59 +0200 (CEST)
In-Reply-To: <1525869983-4705-1-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ravi,

> -----Original Message-----
> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> Sent: Wednesday, May 9, 2018 1:46 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> thomas@monjalon.net; hemant.agrawal@nxp.com
> Subject: [PATCH v2] crypto/ccp: support command line option to enable CPU
> based auth
>=20
> CCP PMD supports authentication offload to either of CCP or CPU.
> The earlier version of patch provides this option as compile time.
> This patch changes this option from compile time to run time.
> User can pass "ccp_auth_opt=3D1" as an additional arguments to vdev
> parameter to enable authentication operations on CPU.
>=20
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

...

>  RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_CCP_PMD,
> cryptodev_ccp_pmd_drv);
>  RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_CCP_PMD,
> -	"max_nb_queue_pairs=3D<int> max_nb_sessions=3D<int> socket_id=3D<int>")=
;
> +	"max_nb_queue_pairs=3D<int> "
> +	"max_nb_sessions=3D<int> "
> +	"socket_id=3D<int> "
> +	"ccp_auth_opt=3D<int>");


Die_num is not in this list. I was going to add it myself,
but then I realized that it is not actually used anywhere.
Am I missing something?

Also, I think it is worth updating the documentation of the PMD with these =
parameters.

Thanks,
Pablo