From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v4 02/18] net/nfp: solve buffer overflow
Date: Fri, 11 May 2018 08:58:20 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD0880C@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <152600312580.53146.1090136345409468008.stgit@localhost.localdomain>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> Sent: Friday, May 11, 2018 2:45 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4 02/18] net/nfp: solve buffer overflow
>
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function
> ‘nfp_pf_pci_probe’:
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160:
> 23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-
> Werror=format-overflow=]
> sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, serial);
>
> Note fw_buf still has to increase somewhat even after restricting serial[], since
> otherwise:
>
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function
> ‘nfp_pf_pci_probe’:
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3176:23:
> error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-
> Werror=format-overflow=]
> sprintf(fw_name, "%s/%s", DEFAULT_FW_PATH, card);
> ^~
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3262:32:
> err = nfp_fw_upload(dev, nsp, card_desc);
> ~~~~~~~~~
> /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3176:2:
> note: ‘sprintf’ output between 25 and 124 bytes into a destination of size 100
> sprintf(fw_name, "%s/%s", DEFAULT_FW_PATH, card);
>
> Signed-off-by: Andy Green <andy@warmcat.com>
Missing fixes line and CC stable.
Fixes: 896c265ef954 ("net/nfp: use new CPP interface")
Cc: stable@dpdk.org
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2018-05-11 8:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 1:45 [PATCH v4 00/18] Fix default build on gcc8.0.1 Andy Green
2018-05-11 1:45 ` [PATCH v4 01/18] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-11 8:11 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 02/18] net/nfp: solve buffer overflow Andy Green
2018-05-11 8:58 ` De Lara Guarch, Pablo [this message]
2018-05-11 10:13 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 03/18] bus/pci: replace strncpy dangerous code Andy Green
2018-05-11 8:17 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 04/18] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-11 8:26 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 05/18] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-11 10:09 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 06/18] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-11 10:26 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-11 10:33 ` De Lara Guarch, Pablo
2018-05-12 1:17 ` Andy Green
2018-05-11 1:45 ` [PATCH v4 08/18] net/nfp: don't memcpy out of source range Andy Green
2018-05-11 10:36 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [PATCH v4 09/18] net/qede: strncpy length constant and NUL Andy Green
2018-05-11 10:43 ` De Lara Guarch, Pablo
2018-05-11 10:48 ` Andy Green
2018-05-11 12:48 ` De Lara Guarch, Pablo
2018-05-11 13:38 ` Andy Green
2018-05-11 15:14 ` De Lara Guarch, Pablo
2018-05-11 17:13 ` Shaikh, Shahed
2018-05-11 1:46 ` [PATCH v4 10/18] net/qede: solve broken strncpy Andy Green
2018-05-11 10:47 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [PATCH v4 11/18] net/sfc: correct strncpy length Andy Green
2018-05-11 8:11 ` Andrew Rybchenko
2018-05-11 10:51 ` De Lara Guarch, Pablo
2018-05-12 1:21 ` Andy Green
2018-05-11 1:46 ` [PATCH v4 12/18] net/sfc: solve strncpy size and NUL Andy Green
2018-05-11 8:13 ` Andrew Rybchenko
2018-05-11 10:55 ` De Lara Guarch, Pablo
2018-05-12 1:24 ` Andy Green
2018-05-11 1:46 ` [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-11 15:39 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [PATCH v4 14/18] net/vdev_netvsc: 3 x strncpy misuse Andy Green
2018-05-11 10:58 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [PATCH v4 15/18] app: can't find include Andy Green
2018-05-11 11:04 ` De Lara Guarch, Pablo
2018-05-11 11:12 ` Andy Green
2018-05-11 13:20 ` De Lara Guarch, Pablo
2018-05-12 0:52 ` Andy Green
2018-05-11 1:46 ` [PATCH v4 16/18] app/proc-info: sprintf overrun bug Andy Green
2018-05-11 12:26 ` De Lara Guarch, Pablo
2018-05-12 1:33 ` Andy Green
2018-05-11 1:46 ` [PATCH v4 17/18] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-11 12:55 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [PATCH v4 18/18] " Andy Green
2018-05-11 13:02 ` De Lara Guarch, Pablo
2018-05-12 1:39 ` Andy Green
2018-05-11 11:14 ` [PATCH v4 00/18] Fix default build on gcc8.0.1 Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD0880C@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.