From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v3 00/38] crypto/qat: refactor to support multiple services Date: Thu, 14 Jun 2018 10:59:59 +0000 Message-ID: References: <1523040732-3290-1-git-send-email-fiona.trahe@intel.com> <1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Jozwiak, TomaszX" , "Trahe, Fiona" , "Jozwiak, TomaszX" , "dev@dpdk.org" Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 35BE61DCED for ; Thu, 14 Jun 2018 13:00:03 +0200 (CEST) In-Reply-To: <1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Wednesday, June 13, 2018 1:14 PM > To: Trahe, Fiona ; Jozwiak, TomaszX > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 00/38] crypto/qat: refactor to support mult= iple > services >=20 > From: Pablo de Lara >=20 > The QAT crypto PMD was peppered with references to rte_cryptodev artefact= s. > Also the pci device it presented to the API layer was entirely owned by t= he one > cryptodev device instance created by the probe. > This patchset refactors the PMD so one pci device can present out multipl= e > different device instances to implement different APIs, specifically cryp= todev > and compressdev instances. > The code is refactored into > - common code which handles the pci device discovery, configuration, > queue-pair setup, stats gathering and data-path enqueue and dequeue. > - service-specific code for symmetric crypto, which is a thin layer > implementing the cryptodev API and using the common code. > - place-holder files for service-specific code to support asymmetric > crypto and compression services in future. > The code is all still in the crypto/qat directory as it is functionally u= nchanged, still > only supporting a symmetric crypto service. The code will move to > drivers/common, /crypto and /compress in a future patch when this is need= ed > for a compression PMD. >=20 > Changes for v3: > - fixed some commit messages > - fixed compilation issue in one of the patches > - split two commits into multiple commits >=20 > Changes for v2: > - fixed some bugs compiled in when debug enabled > - added patch to remove MAX_NB_SESSIONS from config file > - removed SPDX license patch as already applied > - documented device name formats >=20 Applied to dpdk-next-crypto. Thanks, Pablo