From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos
	in cryptodev
Date: Mon, 25 Jun 2018 21:34:14 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DB939@IRSMSX108.ger.corp.intel.com>
References: <1526450713-17299-1-git-send-email-shally.verma@caviumnetworks.com>
 <1526450713-17299-2-git-send-email-shally.verma@caviumnetworks.com>
 <E115CCD9D858EF4F90C690B0DCB4D8977F8D5ABF@IRSMSX108.ger.corp.intel.com>
 <CY4PR0701MB36346DC980CC2027B0AC9543F0750@CY4PR0701MB3634.namprd07.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>, "akhil.goyal@nxp.com"
 <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Athreya, Narayana
 Prasad" <NarayanaPrasad.Athreya@cavium.com>, "Sahu, Sunila"
 <Sunila.Sahu@cavium.com>, "Gupta, Ashish" <Ashish.Gupta@cavium.com>
To: "Verma, Shally" <Shally.Verma@cavium.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 169D737A2
 for <dev@dpdk.org>; Mon, 25 Jun 2018 23:34:18 +0200 (CEST)
In-Reply-To: <CY4PR0701MB36346DC980CC2027B0AC9543F0750@CY4PR0701MB3634.namprd07.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shally,

> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Friday, June 22, 2018 4:39 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com;
> dev@dpdk.org; Athreya, Narayana Prasad
> <NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila
> <Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
> Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in crypto=
dev
>=20
> Hi Pablo
>=20
> >-----Original Message-----
> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 15 June 2018 14:10
> >To: Verma, Shally <Shally.Verma@cavium.com>
> >Cc: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com;
> >dev@dpdk.org; Athreya, Narayana Prasad
> ><NarayanaPrasad.Athreya@cavium.com>; Sahu, Sunila
> ><Sunila.Sahu@cavium.com>; Gupta, Ashish <Ashish.Gupta@cavium.com>
> >Subject: RE: [PATCH v3 1/6] lib/cryptodev: add asymmetric algos in
> >cryptodev
> >
> //snip
>=20
> >
> >...
> >
> >> +/**
> >> + * Asymmetric Cryptographic Operation.
> >> + *
> >> + * Structure describing asymmetric crypto operation params.
> >> + *
> >> + */
> >> +struct rte_crypto_asym_op {
> >> +     struct rte_cryptodev_asym_session *session;
> >> +     /**< Handle for the initialised session context */
> >> +
> >
> >Looking at the xform structure, it looks like a chain of xforms is possi=
ble.
> >Looking at this union, this case wouldn't be possible, as only one item =
from the
> union can be set.
>=20
> [Shally] xforms, which support chaining, would need to have op_type in th=
eir
> respective xform struct.
> Example  struct rte_crypto_dh_xform,  where app can chain Deffie-hellman
> public and/or shared secret compute and DSA sign compute.
>=20
> +struct rte_crypto_dh_xform {
> +	enum rte_crypto_asym_op_type type;
> +	/**< Setup xform for key generate or shared secret compute */ and DSA
> +xforms struct
>=20
> test_cryptodev_asym illustrates how to setup chained dh+dsa ops.

Are you talking about test_dh_gen_kp? Because this is the only function
where I see that there is a chain of xforms.
In this case, both xforms are the same type (RTE_CRYPTO_ASYM_XFORM_DH),
and the operation only sets parameters for rte_crypto_dh_op_param.
I would expect that dh_op_param and dsa_op_param would need to be set, whic=
h couldn't be done.

Thanks,
Pablo

>=20
> Thanks
> Shally
>=20
>=20
> >
> //snip