From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH] cryptodev: fix ABI breakage Date: Wed, 27 Jun 2018 21:14:10 +0000 Message-ID: References: <20180613093648.6070-1-pablo.de.lara.guarch@intel.com> <5612CB344B05EE4F95FC5B729939F78070793376@PGSMSX102.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: "Gujjar, Abhinandan S" , "Doherty, Declan" Return-path: In-Reply-To: <5612CB344B05EE4F95FC5B729939F78070793376@PGSMSX102.gar.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Wednesday, June 13, 2018 11:01 AM > To: De Lara Guarch, Pablo ; Doherty, Decl= an > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] cryptodev: fix ABI breakage >=20 >=20 >=20 > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, June 13, 2018 3:07 PM > > To: Doherty, Declan ; Gujjar, Abhinandan S > > > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > ; stable@dpdk.org > > Subject: [PATCH] cryptodev: fix ABI breakage > > > > In 17.08, the crypto operation was restructured, and some reserved > > bytes (5) were added to have the mempool pointer aligned to 64 bits, > > since the structure is expected to be aligned to 64 bits, allowing > > future additions with no ABI breakage needed. > > > > In 18.05, a new 2-byte field was added, so the reserved bytes were redu= ced to > 3. > > However, this field was added after the first 3 bytes of the > > structure, causing it to be placed in an offset of 4 bytes, and > > therefore, forcing the mempool pointer to be placed after 16 bytes, > > instead of a 8 bytes, causing unintentionally the ABI breakage. > > > > This commit fixes the breakage, by swapping the reserved bytes and the > > private_data_offset field, so the latter is aligned to 2 bytes and the > > offset of the mempool pointer returns to its original offset, > > 8 bytes. > > > > Fixes: 54c836846603 ("cryptodev: set private data for session-less > > mode") > > Cc: stable@dpdk.org > > > > Reported-by: Konstantin Ananyev > > Signed-off-by: Pablo de Lara ... > Acked-by: Abhinandan Gujjar >=20 > > 2.17.0 Applied to dpdk-next-crypto. Pablo