Re: [PATCH v3 09/16] cryptodev: remove max number of sessions parameter

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi 

> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Friday, June 29, 2018 9:04 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com;
> shally.verma@caviumnetworks.com; ravi1.kumar@amd.com;
> jerin.jacob@caviumnetworks.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Trahe, Fiona <fiona.trahe@intel.com>; tdu@semihalf.com;
> jianjay.zhou@huawei.com; dev@dpdk.org
> Subject: Re: [PATCH v3 09/16] cryptodev: remove max number of sessions
> parameter
> 
> Hello Pablo,
> 
> On Thu, Jun 28, 2018 at 01:52:57AM +0100, Pablo de Lara wrote:
> > Most crypto PMDs do not have a limitation of the number of the
> > sessions that can be handled internally. The value that was set before
> > was not actually used at all, since the sessions are created at the
> > application level.
> > Therefore, this value is not parsed from the initial crypto parameters
> > anymore and it is set to 0, meaning that there is no actual limit.
> >
> 
> [...]
> 
> > diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> > b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> > index 3f8de37b7..07850098b 100644
> > --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> > +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> > @@ -471,7 +471,8 @@ mrvl_crypto_pmd_info_get(struct rte_cryptodev *dev,
> >  		dev_info->feature_flags = dev->feature_flags;
> >  		dev_info->capabilities = mrvl_crypto_pmd_capabilities;
> >  		dev_info->max_nb_queue_pairs = internals->max_nb_qpairs;
> > -		dev_info->sym.max_nb_sessions = internals->max_nb_sessions;
> > +		/* No limit of number of sessions */
> > +		dev_info->sym.max_nb_sessions = 0;
> 
> In this case we want to set a limit, right?
> 

Hi Tomasz,

Yes, you are right, I made a mistake here. Thanks for spotting it :)

Will send another version with this fixed.

Pablo